October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: FB: ISingleAsyncOperationFactory.Initialize
by lhornyak＠redhat.com 08 Oct '12

08 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: FB: ISingleAsyncOperationFactory.Initialize ...................................................................... core: FB: ISingleAsyncOperationFactory.Initialize Renamed the Initiazlize(ArrayList) method to initialize(ArrayList) in ISingleAsyncOperationFactory and its implementing classes, in order to solve the FindBugs warning about it (NM_METHOD_NAMING_CONVENTION). Change-Id: I87524bf25e8bc2b2289b6255caf384b03bcfc533 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 6 files changed, 8 insertions(+), 8 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87524bf25e8bc2b2289b6255caf384b03bcfc533 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: FB: ISingleAsyncOperation.Execute(int)
by lhornyak＠redhat.com 08 Oct '12

08 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: FB: ISingleAsyncOperation.Execute(int) ...................................................................... core: FB: ISingleAsyncOperation.Execute(int) Renamed the Execute(int) method to execute(int) in ISingleAsyncOperation and its implementing classes, in order to solve the FindBugs warning about it (NM_METHOD_NAMING_CONVENTION). Change-Id: Ie734cca9af6a5863495acd492ebd83d141edb6b2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperation.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 9 files changed, 9 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie734cca9af6a5863495acd492ebd83d141edb6b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Typo in tasks tab of webadmin (#863294)
by shavivi＠redhat.com 07 Oct '12

07 Oct '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: Typo in tasks tab of webadmin (#863294) ...................................................................... webadmin: Typo in tasks tab of webadmin (#863294) text change 'till' to 'until' https://bugzilla.redhat.com/863294 Change-Id: I97390702b216e52699fd240543deca74ec5ce793 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/conf/ca/SignReq.sh M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/java/org/ovirt/engine/core/notifier/NotificationServiceTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java 5 files changed, 7 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97390702b216e52699fd240543deca74ec5ce793 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: use utc dates when communicating with openssl
by dfediuck＠redhat.com 07 Oct '12

07 Oct '12

Doron Fediuck has submitted this change and it was merged. Change subject: pki: use utc dates when communicating with openssl ...................................................................... pki: use utc dates when communicating with openssl openssl has an issue with complex timezones, so better to feed it with utc dates. Change-Id: I446bd9cc712b345bcf267bf6f5cd23dfc9fdea97 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/ca/installCA.sh M backend/manager/conf/ca/installCA_dev.sh M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M packaging/fedora/setup/engine-setup.py 4 files changed, 9 insertions(+), 21 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I446bd9cc712b345bcf267bf6f5cd23dfc9fdea97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: LinkHelper cleanup
by lhornyak＠redhat.com 05 Oct '12

05 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: LinkHelper cleanup ...................................................................... core: LinkHelper cleanup - naming viloation - uses StringBuilder instead of temporary strings Change-Id: Iae8ea4dbe1e8e85b9d963a82b1af5929ccfecff4 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae8ea4dbe1e8e85b9d963a82b1af5929ccfecff4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-dwh[master]: packaging: Replace JBoss service name with ovirt-engine
by ydary＠redhat.com 04 Oct '12

04 Oct '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Replace JBoss service name with ovirt-engine ...................................................................... packaging: Replace JBoss service name with ovirt-engine Change-Id: Iff9f4a0463d97876b1325441ef643310646342e4 Bug-Url: https://bugzilla.redhat.com/858569 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 33 insertions(+), 33 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff9f4a0463d97876b1325441ef643310646342e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: Extend host mac address to support IB HCA
by ydary＠redhat.com 04 Oct '12

04 Oct '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: Extend host mac address to support IB HCA ...................................................................... history: Extend host mac address to support IB HCA The host mac address field is extended to 59 so it could store InfiniBand HCA mac address. Bug-Url: https://bugzilla.redhat.com/823397 Change-Id: I366282076f0f44602d5180837d5fb06bd61c1113 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.1.item A data-warehouse/historydbscripts_postgres/upgrade/03_00_0150_extend_host_mac_address_size.sql 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366282076f0f44602d5180837d5fb06bd61c1113 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added engine-setup and engine-upgrade man pages
by juan.hernandez＠redhat.com 04 Oct '12

04 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Added engine-setup and engine-upgrade man pages ...................................................................... packaging: Added engine-setup and engine-upgrade man pages Change-Id: I8389a70d284676287ca6b9fee6e4a67fbf7f6343 Signed-off-by: Alex Lourie <alourie(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/742418 Bug-Url: https://bugzilla.redhat.com/742420 --- M Makefile A packaging/engine-setup.8 A packaging/engine-upgrade.8 M packaging/fedora/spec/ovirt-engine.spec.in 4 files changed, 145 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8389a70d284676287ca6b9fee6e4a67fbf7f6343 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: recover from DB restart
by yzaslavs＠redhat.com 04 Oct '12

04 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: recover from DB restart ...................................................................... core: recover from DB restart This patch adds a validation on connection borrowing in order to cope with db connection failure. Bug-Url: https://bugzilla.redhat.com/857684 Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff31 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/conf/standalone.xml M packaging/fedora/engine-service.xml.in 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Using editable combo for volume option key
by gchaplik＠redhat.com 04 Oct '12

04 Oct '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Using editable combo for volume option key ...................................................................... webadmin: Using editable combo for volume option key In the Volume option dialog, the keys will be shown in a combo, the user can either select a key from the list or type his own key and provide the value for it. 'user.cifs' option is added explicitly to the key list as it will not available in the original key list. Change-Id: I48ac5232d95dc01b9f38160c00e37c02dcd44f0a Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.ui.xml 5 files changed, 125 insertions(+), 35 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48ac5232d95dc01b9f38160c00e37c02dcd44f0a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0