December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove unused permissions classes
by derez＠redhat.com 27 Dec '12

27 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: core: remove unused permissions classes ...................................................................... core: remove unused permissions classes Remove 3 unused classes related to tags and permissions Change-Id: Ibfe5f8fcc98203ad0c837e6bac68a8022c6c1d6d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDetachTagToEntityCommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachTagFromPermissionsCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags_permissions_map.java 3 files changed, 0 insertions(+), 78 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe5f8fcc98203ad0c837e6bac68a8022c6c1d6d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move MacPoolManager to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move MacPoolManager to network package ...................................................................... engine: Move MacPoolManager to network package This class is used for networking logic and so it should reside in network package. Change-Id: Ie367865ce12b021875013a9ca5b71d1f407cb257 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolExceededMaxException.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 13 files changed, 11 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie367865ce12b021875013a9ca5b71d1f407cb257 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move host network commands to their package
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Move host network commands to their package ...................................................................... engine: Move host network commands to their package Moved host network related commands to their correct package. Change-Id: I40630f7638b532902950bd48ca084c59530b3eba Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/CommitNetworkChangesCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsBondCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsNetworkCommand.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 11 files changed, 24 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40630f7638b532902950bd48ca084c59530b3eba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move cluster network commands to their package
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Move cluster network commands to their package ...................................................................... engine: Move cluster network commands to their package Moved cluster network related commands to their correct package. Change-Id: I8f327681a86e6ed152fd2174ea033f4fb868ed16 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommandTest.java 4 files changed, 10 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f327681a86e6ed152fd2174ea033f4fb868ed16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Extract SetNetworkStatus method
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Extract SetNetworkStatus method ...................................................................... engine: Extract SetNetworkStatus method This method is used in a variety of places and is not necessarily related to AttachNetworkToVdsGroupCommand. This is why it was moved to a dedicated class that will hold such methods. Some warnings were fixed on the new method, and the name was changed to comply with Java naming conventions and with meaning. Change-Id: Ia8f0e864c82b3977e1428e4854d85ca4c6e8a7ff Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 11 files changed, 103 insertions(+), 67 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8f0e864c82b3977e1428e4854d85ca4c6e8a7ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move template NIC commands to their package
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Move template NIC commands to their package ...................................................................... engine: Move template NIC commands to their package Moved template NIC related commands to their correct package. Change-Id: Ibc1d26bb606820abe12ceff32d626f7bbf1003e9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/RemoveVmTemplateInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc1d26bb606820abe12ceff32d626f7bbf1003e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Moved VM NIC commands to their package
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Moved VM NIC commands to their package ...................................................................... engine: Moved VM NIC commands to their package Moved VM NIC related commands to their correct package. Change-Id: I407633698acb9e9bd11c77f4a737482e24cd743e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 4 files changed, 14 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I407633698acb9e9bd11c77f4a737482e24cd743e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move DC network commands to their package
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Move DC network commands to their package ...................................................................... engine: Move DC network commands to their package Moved DC network related commands to their correct package. Change-Id: Ic739407f435c20e7a91e19d046a7e671665bb64d Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 4 files changed, 5 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic739407f435c20e7a91e19d046a7e671665bb64d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add network command packages to factory
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add network command packages to factory ...................................................................... engine: Add network command packages to factory Added to factory to allow creating command that are in org.ovirt.engine.core.bll.network packages. Change-Id: I08936f9e16e205c2f39c72a41ec14b85f4f1c320 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08936f9e16e205c2f39c72a41ec14b85f4f1c320 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:fixing GeneralDbDAOTest
by yzaslavs＠redhat.com 26 Dec '12

26 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core:fixing GeneralDbDAOTest ...................................................................... core:fixing GeneralDbDAOTest Adding @size annotation to new field added : pmProxyPreferences Change-Id: I32c2bbe32f721f53aeff326f51f3f46251a5acf1 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32c2bbe32f721f53aeff326f51f3f46251a5acf1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0