December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: added logging to common utils
by ydary＠redhat.com 26 Dec '12

26 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added logging to common utils ...................................................................... packaging: added logging to common utils - Also added defaults to db values. - Get db config will now return false instead of exception if value not found. Change-Id: I7c6e6c51ce7958dea45c91cb19dcdc8a6d93fe8b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 28 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c6e6c51ce7958dea45c91cb19dcdc8a6d93fe8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: changed version checking in setup time
by ydary＠redhat.com 26 Dec '12

26 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed version checking in setup time ...................................................................... packaging: changed version checking in setup time Change-Id: I262e06294247b4483545c84023211a57160ffd20 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I262e06294247b4483545c84023211a57160ffd20 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Validation added in Import Cluster
by sanjal＠redhat.com 26 Dec '12

26 Dec '12

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Validation added in Import Cluster ...................................................................... engine: Validation added in Import Cluster - Validation added to check whether the given server or any server in the importing cluster is already part of the existing cluster by checking with the database. - Renamed GetGlusterServersQuery to GetGlusterServersForImportQuery, since it is related to import cluster operation. Change-Id: I8323f2dcc4f278dfbc01f99ebe18b0f2bd0296ca Bug-Url: https://bugzilla.redhat.com/884292 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 7 files changed, 150 insertions(+), 87 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/9784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8323f2dcc4f278dfbc01f99ebe18b0f2bd0296ca Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommand canDoAction cleanup
by tnisan＠redhat.com 26 Dec '12

26 Dec '12

Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommand canDoAction cleanup ...................................................................... core: UpdateVmDiskCommand canDoAction cleanup Change-Id: Id74d24f991a1c00b92dec72125148a6a9fa75d5f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 70 insertions(+), 72 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74d24f991a1c00b92dec72125148a6a9fa75d5f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix usb mapping on update vm call
by mpastern＠redhat.com 26 Dec '12

26 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix usb mapping on update vm call ...................................................................... restapi: fix usb mapping on update vm call Change the way usb policy is set on update vm/template request which is received through rest api. The full mapping is described in the bug-url. Specifically, the new mapping states that if no usb setting is defined in the update request, the previous usb policy will remain as is (instead of being set to DISABLED as it was before), thus it solves bug #875881. UsbResourceUtils class methods moved to VmMapper class, and it was removed on the way (the same was done for UsbResourceUtilsTest class, its methods moved to VmMapperTest class). Change-Id: If74bf6ede2fc0f932db8dfcd7951b6bcf90b7744 Bug-Url: https://bugzilla.redhat.com/875881 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/UsbResourceUtils.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/test/UsbResourceUtilsTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 9 files changed, 334 insertions(+), 146 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If74bf6ede2fc0f932db8dfcd7951b6bcf90b7744 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: added packaging to ovirt reports.
by ydary＠redhat.com 26 Dec '12

26 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added packaging to ovirt reports. ...................................................................... packaging: added packaging to ovirt reports. - now has make file and setup. - included python3 compatibility for 'make tarball'. - add project version to pom.xml Change-Id: I96cffaebfa0ae93e004be717b547b4d3496220e4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A Makefile A packaging/common_utils.py A packaging/decorators.py A packaging/default_master.properties A packaging/ovirt-engine-reports-setup.py A packaging/ovirt-engine-reports.spec.in M pom.xml M reports/jars/pom.xml A server-customizations/META-INF/MANIFEST.MF A server-customizations/WEB-INF/applicationContext-logging.xml A server-customizations/WEB-INF/applicationContext-security-web.xml A server-customizations/WEB-INF/applicationContext.xml A server-customizations/WEB-INF/classes/jasperreports.properties A server-customizations/WEB-INF/decorators/decorator.jsp A server-customizations/WEB-INF/decorators/minimalDecorator.jsp A server-customizations/WEB-INF/jsp/modules/login/login.jsp A server-customizations/WEB-INF/log4j.properties A server-customizations/WEB-INF/web.xml 18 files changed, 4,771 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96cffaebfa0ae93e004be717b547b4d3496220e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: call Failed to runVms on different thread
by ofrenkel＠redhat.com 26 Dec '12

26 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: call Failed to runVms on different thread ...................................................................... core: call Failed to runVms on different thread On a busy system we can hit a deadlock in a situation where 2 Vdsmanager are failing to run a VM and are notifying each other a FailedToRunVm VDS command. This fix reduces the probability of the deadlock by notifying other hosts in a new thread to try and conclude blocking VdsManager thread to terminate more quickly and release the lock. Change-Id: If4d760aa270a3f07b13d1579d7b02c838cb4dd15 Bug-Url: https://bugzilla.redhat.com/878890 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 22 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4d760aa270a3f07b13d1579d7b02c838cb4dd15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change var network_cluster to networkCluster
by masayag＠redhat.com 26 Dec '12

26 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Change var network_cluster to networkCluster ...................................................................... engine: Change var network_cluster to networkCluster Change-Id: If6d1690c6b435c36a24a5f24c34cf3bb355ae76c Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworkDisplayByClusterIdQuery.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6d1690c6b435c36a24a5f24c34cf3bb355ae76c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Renamed network_cluster.java to NetworkCluster.java
by masayag＠redhat.com 26 Dec '12

26 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Renamed network_cluster.java to NetworkCluster.java ...................................................................... core: Renamed network_cluster.java to NetworkCluster.java Change-Id: Idd904858b208f15b0483f52dfee6478b837747f6 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworkDisplayByClusterIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupsAndNetworksByNetworkIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateDisplayToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsGroupsAndNetworksByNetworkIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsGroupParameter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/NetworkClusterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkCluster.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkClusterDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkClusterDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkClusterDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkClusterDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkClusterPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkClusterStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkStatusColumn.java 36 files changed, 176 insertions(+), 176 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd904858b208f15b0483f52dfee6478b837747f6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin:[RFE]: Support proxy management in GUI
by emesika＠redhat.com 26 Dec '12

26 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: webadmin:[RFE]: Support proxy management in GUI ...................................................................... webadmin:[RFE]: Support proxy management in GUI This patch adds the origin and custom_event_id fields to the Events TAB display (both on general events & for an entity instance) Change-Id: I59e2ecfafe3c20b0c3925780b6bf8051fe7bfa3f Signed-off-by: Alexey Chub <achub(a)redhat.com> Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 7 files changed, 340 insertions(+), 34 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e2ecfafe3c20b0c3925780b6bf8051fe7bfa3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0