December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove obsolete StorageDomainTemplateQuery
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: core: remove obsolete StorageDomainTemplateQuery ...................................................................... core: remove obsolete StorageDomainTemplateQuery Cleanup - removing obsolete query: StorageDomainTemplateQuery Change-Id: I9e090b64dd8b47a9c79dc8ad6a1c3caab62031b6 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/disk_images_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesByStorageDomainAndTemplateQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainTemplateQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java 8 files changed, 0 insertions(+), 106 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e090b64dd8b47a9c79dc8ad6a1c3caab62031b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: log message on evaluateCorrelationId failure
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: core: log message on evaluateCorrelationId failure ...................................................................... core: log message on evaluateCorrelationId failure Added a log message warning for evaluateCorrelationId() failure reasons (the method validates correlationId). Change-Id: I4e9916d549709dc83df29f1df642aef141b80e24 Bug-Url: https://bugzilla.redhat.com/886824 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e9916d549709dc83df29f1df642aef141b80e24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: local storage - missing correlation ID
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: local storage - missing correlation ID ...................................................................... webadmin: local storage - missing correlation ID Configure local storage: added correlation ID for AddEmptyStoragePool action. Change-Id: Ic7f331fb34238b85030e8be0bbed64998395121c Bug-Url: https://bugzilla.redhat.com/886824 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f331fb34238b85030e8be0bbed64998395121c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: VmInterfaceListModelTable style modifications
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VmInterfaceListModelTable style modifications ...................................................................... webadmin: VmInterfaceListModelTable style modifications Modified inner panels' margins in VmInterfaceListModelTable (removed redundant custom styling). Change-Id: I867c7b3ce7971539cfe90f0e3d3c4161d63199d9 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.ui.xml 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/10324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I867c7b3ce7971539cfe90f0e3d3c4161d63199d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: VmSnapshotListModelTable style modifications
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VmSnapshotListModelTable style modifications ...................................................................... webadmin: VmSnapshotListModelTable style modifications Modified inner panels' margins in VmSnapshotListModelTable (removed redundant custom styling). Change-Id: Ie2b98ab6136c483ca4740a2e088efc225a2b0a15 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2b98ab6136c483ca4740a2e088efc225a2b0a15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: remove unused true always enabled
by Alon Bar-Lev 23 Dec '12

23 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: remove unused true always enabled ...................................................................... vdsm: bridge: remove unused true always enabled Change-Id: I0784d0fdcc89f4774fdc883512d7ee2dafe0b49c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/bridge.py 1 file changed, 4 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0784d0fdcc89f4774fdc883512d7ee2dafe0b49c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: missing translation in Quota ($VmName)
by gchaplik＠redhat.com 23 Dec '12

23 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: missing translation in Quota ($VmName) ...................................................................... core: missing translation in Quota ($VmName) Change-Id: I4777fa20f4663e1ab47e611bbc80aec26ee84166 Bug-Url: https://bugzilla.redhat.com/871103 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4777fa20f4663e1ab47e611bbc80aec26ee84166 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix volume option dialog hang issue
by gchaplik＠redhat.com 23 Dec '12

23 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix volume option dialog hang issue ...................................................................... webadmin: Fix volume option dialog hang issue When there are no UP servers in the cluster, we will not able to fecth the volume option help. An error message will be shown to user in case of any failures while fetching the option list. Change-Id: I4264cabaeffc3c931069b4b368900a4c950f688f Bug-Url: https://bugzilla.redhat.com/864649 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.ui.xml 5 files changed, 61 insertions(+), 24 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4264cabaeffc3c931069b4b368900a4c950f688f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Removed duplicate call to onSuccess in RunQuery
by gchaplik＠redhat.com 23 Dec '12

23 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Removed duplicate call to onSuccess in RunQuery ...................................................................... webadmin: Removed duplicate call to onSuccess in RunQuery In case of handleFailure=true, the onSuccess method was called twice. This leads to multiple invocation of the callback code. It is fixed now. Change-Id: Ic762d09330c5f721c65867dd6b1b9ff517842d64 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic762d09330c5f721c65867dd6b1b9ff517842d64 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix brick advanced details hang issue
by gchaplik＠redhat.com 23 Dec '12

23 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix brick advanced details hang issue ...................................................................... webadmin: Fix brick advanced details hang issue Brick Advanced details query might fail when the corresponding brick process is down. An error message will be shown in Advanced details popup if the query is failed. Change-Id: Ie880c7eb7435f96bd081473dcffe78c10f1658cd Bug-Url: https://bugzilla.redhat.com/886411 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.ui.xml 5 files changed, 39 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie880c7eb7435f96bd081473dcffe78c10f1658cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0