December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Make EntityObject class final
by vszocs＠redhat.com 21 Dec '12

21 Dec '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Make EntityObject class final ...................................................................... webadmin: Make EntityObject class final Making EntityObject class final just to be on safe side with regard to GWT JavaScript overlay type (JavaScriptObject subclass) handling. Change-Id: I40efd579131b84d5602c071a481415fccc77e3a2 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40efd579131b84d5602c071a481415fccc77e3a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove KerberosUpgrade
by juan.hernandez＠redhat.com 20 Dec '12

20 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove KerberosUpgrade ...................................................................... core: Remove KerberosUpgrade This class is no longer used. Change-Id: Ic224053927f9f9c71077324593686c8d26909fd7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosUpgrade.java 1 file changed, 0 insertions(+), 208 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic224053927f9f9c71077324593686c8d26909fd7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixed invalid HTML in index and 404.
by juan.hernandez＠redhat.com 20 Dec '12

20 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: core: Fixed invalid HTML in index and 404. ...................................................................... core: Fixed invalid HTML in index and 404. index.html added missing closing div tag. 404.html moved body content inside body tag. userportal: Fixed invalid HTML in 404.html 404.html moved body content inside body tag. webadmin: Fixed invalid HTML in 404.html 404.html moved body content inside body tag. Signed-off-by: Alexander Wels <awels(a)redhat.com> Change-Id: I35c86ae0d309b6a469b47d7dc8e6c0d28c7f9909 --- M backend/manager/modules/root/src/main/webapp/404.html M backend/manager/modules/root/src/main/webapp/index.html M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/404.html M frontend/webadmin/modules/webadmin/src/main/webapp/404.html 4 files changed, 4 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35c86ae0d309b6a469b47d7dc8e6c0d28c7f9909 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Updated spec file to follow packaging guide lines (BZ#772608...
by bazulay＠redhat.com 20 Dec '12

20 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: Updated spec file to follow packaging guide lines (BZ#772608) ...................................................................... Updated spec file to follow packaging guide lines (BZ#772608) * Bumped the ovirt-guest-agent version in configure.ac to 1.0.6 as preparation for the next release * Updated INSTALL to the current version * autogen.sh is now using autoreconf -ivf * Added m4 folder Changes to spec file: - Introduced ovirt-guest-agent-service noarch package which provides ovirt-guest-agent and avoids duplication of the same package content - Fixed various rpmlint errors and warnings - Added required build requires - Removed unnecessary build requires - Removed unnecessary call to autoreconf in setup section - Marked config files as such - Excluded unwanted files instead of deleting them - Moved folder creation and symlink creation from spec to autotools - License file change reflected - Removed systemd unit file installation - Removed creation of log and lock folders Changes to build system: - Added creation of /usr/share/ovirt-guest-agent - Added creation of symlinks for: - ovirt-hibernate - ovirt-shutdown - ovirt-locksession - Systemd unit files are now installed, if systemd is detected - Log and lock folders for ovirt-guest-agent are now created on install - Added missing -fPIC for the pam module - Various improvements to configure.ac and several Makefile.am files in regards of installation directory detection and installation handling Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=772608 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M INSTALL M Makefile.am M autogen.sh M configure.ac M gdm-plugin/Makefile.am M kdm-plugin/Makefile.am A m4/.keep M ovirt-guest-agent.spec M ovirt-guest-agent/Makefile.am M pam-ovirt-cred/Makefile.am 10 files changed, 164 insertions(+), 111 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd Gerrit-PatchSet: 19 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: gluster: packages: fix typo
by Alon Bar-Lev 20 Dec '12

20 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: gluster: packages: fix typo ...................................................................... gluster: packages: fix typo Change-Id: If8ec7636ce77fc5cebf0175ec500effb38ce24af Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/gluster/packages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8ec7636ce77fc5cebf0175ec500effb38ce24af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added storage domains inventory br47 (#772918)
by ydary＠redhat.com 20 Dec '12

20 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added storage domains inventory br47 (#772918) ...................................................................... reports: added storage domains inventory br47 (#772918) This report displays a list of all storage domains of the selected data center. Bug-Url: https://bugzilla.redhat.com/772918 Change-Id: I514b33be29676b797d35b3fbb23b6450bd5751b1 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Inventory/.folder.xml M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/full details br1.jrxml.data A reports/repository_files/resources/Reports/Inventory/storage_domains_inventory_br47.xml A reports/repository_files/resources/Reports/Inventory/storage_domains_inventory_br47_files/chart.data A reports/repository_files/resources/Reports/Inventory/storage_domains_inventory_br47_files/full details.jrxml.data A reports/repository_files/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/P_Storage_Type.xml M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data 9 files changed, 854 insertions(+), 34 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I514b33be29676b797d35b3fbb23b6450bd5751b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix Remove Storage error message(#863097)
by mlipchuk＠redhat.com 20 Dec '12

20 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix Remove Storage error message(#863097) ...................................................................... core: Fix Remove Storage error message(#863097) setActionMessageParameters() was not set for RemoveStorageDomainCommand, nor for base class StorageDomainCommandBase(). When the lock could not be acquired in CommandBase.acquireLockInternal() both VAR__TYPE__STORAGE__DOMAIN and VAR__ACTION__REMOVE were not added to the VdcBllMessages, resulting in ${action} and ${type} appearing in the error message. This patch implements setActionMessageParameters() in StorageDomainCommandBase and in RemoveStorageDomainCommand, and removes the setting of VAR__TYPE__STORAGE__DOMAIN and VAR__ACTION__REMOVE in other flows, as it is not needed there anymore. Adjusted and added tests, also added assert messages in CommandAssertUtils. Change-Id: I8b737545c0519cc2034bb6eec36afcc38da26059 Bug-Url: https://bugzilla.redhat.com/863097 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandAssertUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java 5 files changed, 34 insertions(+), 22 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/10265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b737545c0519cc2034bb6eec36afcc38da26059 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing SPM election in case that we have IrsNoMaster...
by mkublin＠redhat.com 20 Dec '12

20 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing SPM election in case that we have IrsNoMasterDomainException ...................................................................... engine: Fixing SPM election in case that we have IrsNoMasterDomainException The following patch should add a current host to tried ones, otherwise the host will not be added and in case of throwing IrsNoMasterDomainException we will never trigger a reconstruct and will continue to perfrom a spm election for next 5 minutes. The error is that list of tried ids is left empty Change-Id: I14af7f4459b54a0d74bece777d72da8b1a0e2b84 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14af7f4459b54a0d74bece777d72da8b1a0e2b84 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add clear message for live snapshot fail
by amureini＠redhat.com 20 Dec '12

20 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: add clear message for live snapshot fail ...................................................................... core: add clear message for live snapshot fail Add a new, clear message when live snapshot fails for a host which is up in a data center with compatibility version 3.0. Change-Id: I7b6dfc138951baddc991a82a4c9e64f60499428a Bug-Url: https://bugzilla.redhat.com/873156 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 24 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b6dfc138951baddc991a82a4c9e64f60499428a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extract code to methods in ImagesHandler
by amureini＠redhat.com 20 Dec '12

20 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Extract code to methods in ImagesHandler ...................................................................... core: Extract code to methods in ImagesHandler Extract code to isVMDown and checking for storage pool validity to external methods to make PerformImagesChecks more readable. Change-Id: I363f7bf24ca9b5d408a61ba9159b6e5f2a5c46e0 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 22 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363f7bf24ca9b5d408a61ba9159b6e5f2a5c46e0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0