December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: reports: removed tabs from files
by ydary＠redhat.com 11 Dec '12

11 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: removed tabs from files ...................................................................... reports: removed tabs from files Change-Id: Ib886c6ad1a30c88dbd3ec110e65191fa72a200bb Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_functions.sql M data-warehouse/historydbscripts_postgres/create_views_3_1.sql M data-warehouse/historydbscripts_postgres/create_views_3_2.sql 3 files changed, 14 insertions(+), 14 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib886c6ad1a30c88dbd3ec110e65191fa72a200bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools : engine-manage-domains confirm delete domain
by yzaslavs＠redhat.com 11 Dec '12

11 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : engine-manage-domains confirm delete domain ...................................................................... tools : engine-manage-domains confirm delete domain When user deletes a domain using engine-manage-domains a confirmation of delete message needs to be presented confirming the operation. A new command line option -forceDelete has been added to bypass the confirmation message. Change-Id: I770269eccdc4a2d0645d96cf48b660ad22d42f9d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879938 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/conf/kerberos/engine-manage-domains M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 2 files changed, 31 insertions(+), 9 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I770269eccdc4a2d0645d96cf48b660ad22d42f9d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: added 3.2 views.
by ydary＠redhat.com 11 Dec '12

11 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: added 3.2 views. ...................................................................... history: added 3.2 views. Change-Id: I15c43f19d3dbac350f081e509b322cd70c77bf4a Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/create_views_3_2.sql M data-warehouse/historydbscripts_postgres/dbcustomfunctions.sh 2 files changed, 829 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15c43f19d3dbac350f081e509b322cd70c77bf4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Network object serialization is missing the name fiel...
by masayag＠redhat.com 11 Dec '12

11 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: core : Network object serialization is missing the name field ...................................................................... core : Network object serialization is missing the name field When deleting a Network and using compensation the Network entity is being serialized to JSON using the jackson serializer and persisted into the DB so this change can be rolled back in case of a failure/crash. Using @JsonIgnore annotation on property when using jackson 1.9 and above causes the field/field properties to be ignored by the jackson serializer as mentioned on it's documentation: "Before version 1.9, this annotation worked purely on method-by-method (or field-by-field) basis; annotation on one method or field did not imply ignoring other methods or fields. However, with version 1.9 and above, annotations associated with various accessors (getter, setter, field, constructor parameter) of a logical property are combined; meaning that annotations in one (say, setter) can have effects on all of them (if getter or field has nothing indicating otherwise)." The @JsonIgnore annotation on getName() method causes the network name to not be serialized - so in case of compensation on that entity the executed SQL's doesn't contain the correct name value - which at the moment causes a constraint violation as network table has 'not null' constraint on the 'name' column which means that the whole compensation will roll back and might leave the db in inconsistent state. Change-Id: Ibf08e8b4cd99aa726885ee53f356edc22a6f4324 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf08e8b4cd99aa726885ee53f356edc22a6f4324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: improving log at JNDI action
by yzaslavs＠redhat.com 11 Dec '12

11 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: improving log at JNDI action ...................................................................... core: improving log at JNDI action This patch improves error log (at debug level) in case of exception at JNDI action Bug-Url: Change-Id: Iee63307810ef9d035745aa1df23e8db4133702be Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee63307810ef9d035745aa1df23e8db4133702be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Deleted tab character
by mpastern＠redhat.com 11 Dec '12

11 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Deleted tab character ...................................................................... restapi: Deleted tab character Deleted tab character from yaml api descriptor. Change-Id: Ia74a8b2d3e8e68e186a59cdcf736e954a15873ce Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia74a8b2d3e8e68e186a59cdcf736e954a15873ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: CPU pinning validation cleanup
by lhornyak＠redhat.com 11 Dec '12

11 Dec '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: CPU pinning validation cleanup ...................................................................... core: CPU pinning validation cleanup isPinningAndMigrationValid renamed to validatePinningAndMigration Change-Id: I2b9788aa3505d9a6657d9eaa9c47af63852c02fa Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b9788aa3505d9a6657d9eaa9c47af63852c02fa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change VMDevice.toString() (#885984)
by amureini＠redhat.com 11 Dec '12

11 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Change VMDevice.toString() (#885984) ...................................................................... core: Change VMDevice.toString() (#885984) In VMDevice.toString the device alias property was serialized as alias. Changed to deviceAlias just to be clear. Change-Id: I28720d0d843c9be4225437bd8f8b39c981fab1e5 Bug-Url: https://bugzilla.redhat.com/885984 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28720d0d843c9be4225437bd8f8b39c981fab1e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: move keystorePass to decrypted section
by juan.hernandez＠redhat.com 11 Dec '12

11 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: move keystorePass to decrypted section ...................................................................... packaging: setup: move keystorePass to decrypted section The keystorePass need to be stored before encrypted fields can be stored, as it is the password for opening the key to encrypt the other fields required by engine-config. Change-Id: Ib9963db3e0218f855534c5c4534c6481beedf9f1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9963db3e0218f855534c5c4534c6481beedf9f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup StorageDomainCommandBase
by lhornyak＠redhat.com 11 Dec '12

11 Dec '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup StorageDomainCommandBase ...................................................................... core: cleanup StorageDomainCommandBase - use failCanDoAction Change-Id: Iec6389f02859bc5cd3fd16857b76afb85894ba09 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6389f02859bc5cd3fd16857b76afb85894ba09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0