December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: NPEs and wrong persisted information when reusing LUNs
by amureini＠redhat.com 11 Dec '12

11 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: NPEs and wrong persisted information when reusing LUNs ...................................................................... core: NPEs and wrong persisted information when reusing LUNs Generally, the following issues caused that a created storage domain on pre-existing luns storage led to NPEs and wrong data shown to the user during execution of GetLunsByVgIdQuery. This patch fixes the following issues: 1. When removing a domain that used LUN storage and there's a disk used by that LUN - LUNs volume_group_id still contains the removed domain id which doesn't exist anymore. 2. When extending a domain to use an existing LUN, the domain id isn't set to that LUN which causes to NPE in GetLunsByVgIdQuery or wrong data provided to the user. 3. When creating a domain from an existing LUN, the domain id isn't set to this LUN which might causes to NPE in GetLunsByVgIdQuery or wrong data provided to the user. 4. When removing LUN disk which isn't used as storage domain (and therefore - not used anymore), the LUN remained in the DB. Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875909 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDAOTest.java 12 files changed, 87 insertions(+), 26 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/9229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandlerTest: fix typo in assertion
by mlipchuk＠redhat.com 10 Dec '12

10 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: ImagesHandlerTest: fix typo in assertion ...................................................................... core: ImagesHandlerTest: fix typo in assertion Fixed a typo in an assertion method difined->defined. Change-Id: I7ed1f93afd34a80f9f5843e75a7570fb75e1750f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed1f93afd34a80f9f5843e75a7570fb75e1750f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Unit test ImagesHandler.getSuggestedAlias
by amureini＠redhat.com 10 Dec '12

10 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Unit test ImagesHandler.getSuggestedAlias ...................................................................... core: Unit test ImagesHandler.getSuggestedAlias Added a test suite for ImagesHandler.getSuggestedAlias. Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java 2 files changed, 46 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: javadoc ImagesHandler.getSuggestedDiskAlias
by amureini＠redhat.com 10 Dec '12

10 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: javadoc ImagesHandler.getSuggestedDiskAlias ...................................................................... core: javadoc ImagesHandler.getSuggestedDiskAlias Improved the documentation of ImagesHandler.getSuggestedDiskAlias, to make it slightly clearer. Change-Id: Ifb41697e19bf63e9897c96007ebda8cfcdbfb2af Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb41697e19bf63e9897c96007ebda8cfcdbfb2af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-live[master]: root commit
by mgoldboi＠redhat.com 10 Dec '12

10 Dec '12

Moran Goldboim has submitted this change and it was merged. Change subject: root commit ...................................................................... root commit Change-Id: Ib7777fd28388bb9fafb84cfb7318548243914748 Signed-off-by: Moran Goldboim <mgoldboi(a)redhat.com> --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: Moran Goldboim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7777fd28388bb9fafb84cfb7318548243914748 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: replaced hard-coded service name with a const
by oschreib＠redhat.com 10 Dec '12

10 Dec '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: replaced hard-coded service name with a const ...................................................................... packaging: replaced hard-coded service name with a const Change-Id: Ide45b6f39132b2cab9859828ff94e8788ee80189 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide45b6f39132b2cab9859828ff94e8788ee80189 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Privileged user cannot create VM via API (#876460)
by mpastern＠redhat.com 10 Dec '12

10 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Privileged user cannot create VM via API (#876460) ...................................................................... restapi: Privileged user cannot create VM via API (#876460) PowerUser can create VM from GUI but the operation fails from API. /api/vms to create a VM throws insufficient permissions error. Change-Id: I604883bc48dce3f326046d59534fb9134c1bbb29 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=876460 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 13 files changed, 127 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I604883bc48dce3f326046d59534fb9134c1bbb29 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Mapping of empty name in user object (#B861098)
by mpastern＠redhat.com 10 Dec '12

10 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Mapping of empty name in user object (#B861098) ...................................................................... restapi: Mapping of empty name in user object (#B861098) When retrieving list of users using /api/users, empty name tag is added to the xml returned when the user does not belong to a group. The group should be omitted from the groups list if it is empty. Change-Id: I1444e755797b101a216fd2e20537dd6e2aaefb33 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=861098 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1444e755797b101a216fd2e20537dd6e2aaefb33 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: API should expose hypervisor version (#829625)
by mpastern＠redhat.com 10 Dec '12

10 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: API should expose hypervisor version (#829625) ...................................................................... restapi: API should expose hypervisor version (#829625) Restapi should include the hypervisor version in /api/hosts and /api/hosts/xxx A new version and os element has been added to the xml to expose the vdsm and host os information. Change-Id: Id8d3d090ae4c0ba489f3c7484d5c232c55f3c059 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=829625 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 3 files changed, 82 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8d3d090ae4c0ba489f3c7484d5c232c55f3c059 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: saveDiskImageDynamic
by amureini＠redhat.com 09 Dec '12

09 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: saveDiskImageDynamic ...................................................................... core: ImportVm cleanup: saveDiskImageDynamic Extracted the saveDiskImageDynamic(DiskImage) method instead of multiple blocks of the same code. Change-Id: Iba9d746c239e627b0db403fa1e1028a775e0d2ab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 13 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba9d746c239e627b0db403fa1e1028a775e0d2ab Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0