May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UnPowerMock StorageDomainCommandBaseTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock StorageDomainCommandBaseTest ...................................................................... core: UnPowerMock StorageDomainCommandBaseTest Replaced (unneeded) PowerMock imports with Mockito imports. Change-Id: Ia6c4a16d4465e1607ceb676648ecfdd2f73a9972 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBaseTest.java 1 file changed, 9 insertions(+), 15 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c4a16d4465e1607ceb676648ecfdd2f73a9972 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock IsVmWithSameNameExistQueryTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock IsVmWithSameNameExistQueryTest ...................................................................... core: UnPowerMock IsVmWithSameNameExistQueryTest Removed PowerMock dependency from IsVmWithSameNameExistQueryTest and replaced it with spying the query. Change-Id: Ia0495a9acc5f4358567a1040668e64d31b46c265 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVmWithSameNameExistQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/IsVmWithSameNameExistQueryTest.java 2 files changed, 8 insertions(+), 11 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0495a9acc5f4358567a1040668e64d31b46c265 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock GetLunsByVgIdTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock GetLunsByVgIdTest ...................................................................... core: UnPowerMock GetLunsByVgIdTest Removed PowerMock depedency from GetLunsByVgIdTest and replaced it with spying the DAOs. In order to achieve this a minor refactoring was required in GetLunsByVgIdQuery, making it use the standard getDbFacade() instead of implementing its own getDb(). Change-Id: I7a742edf5f06bb19ddf87947a437ec2763eb257a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java 2 files changed, 30 insertions(+), 31 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a742edf5f06bb19ddf87947a437ec2763eb257a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't use Hibernate helper
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Don't use Hibernate helper ...................................................................... core: Don't use Hibernate helper The commons-lang StringUtils.isEmpty() method is equivalent and simplifies packaging. Change-Id: I9569262fcac5d6439911d7fc830bbe4b406bf2f6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9569262fcac5d6439911d7fc830bbe4b406bf2f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock RestoreAllSnapshotCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock RestoreAllSnapshotCommandTest ...................................................................... core: UnPowerMock RestoreAllSnapshotCommandTest Removed PowerMock dependency from RestoreAllSnapshotCommandTest and replaced it by spying the command. In order to achieve this improvement, some minor refactoring was required in RestoreAllSnapshotsCommand and VmCommand. Change-Id: I75c9f5952b318e0efaed0b8c83ccfe74475e62be Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java 3 files changed, 63 insertions(+), 46 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75c9f5952b318e0efaed0b8c83ccfe74475e62be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock TagsDirectorTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock TagsDirectorTest ...................................................................... core: UnPowerMock TagsDirectorTest Removed PowerMock dependency from TagsDirectorTest. A call to PowerMockito.spy() was repalced with a call to Mockito.spy(). Change-Id: Idc0b95c1b0656b1da798cb9256093e0e15a5de27 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java 1 file changed, 20 insertions(+), 20 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc0b95c1b0656b1da798cb9256093e0e15a5de27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock MoveOrCopyDiskCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock MoveOrCopyDiskCommandTest ...................................................................... core: UnPowerMock MoveOrCopyDiskCommandTest Removed PowerMock dependency from MoveOrCopyDiskCommandTest. In order to facilitate this change several protected methods were created in the MoveOrCopyDiskCommand, in order to allow spying out the dependency on StorageDomainChecker and ImagesHandler. Change-Id: I75fa03b0bcb0229a662a72fd01902f6883ef8983 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 48 insertions(+), 43 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75fa03b0bcb0229a662a72fd01902f6883ef8983 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock RemoveVdsCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock RemoveVdsCommandTest ...................................................................... core: UnPowerMock RemoveVdsCommandTest Removed unused @RunWith(PowerMockRunner.class) decleration. Change-Id: I5d80392f20fb6dd21781c2c0e21c28e92c39b1e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d80392f20fb6dd21781c2c0e21c28e92c39b1e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock SetupNetworksParametersTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock SetupNetworksParametersTest ...................................................................... core: UnPowerMock SetupNetworksParametersTest Removed PowerMock dependency from SetupNetworksParametersTest by replacing a call to the deprecated ConfigMocker with the new MockConfigRule. Change-Id: Id2100c5d6b04233b07d3641ddee738f9771cefe9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java 1 file changed, 11 insertions(+), 19 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2100c5d6b04233b07d3641ddee738f9771cefe9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock GetVmByVmIdQueryTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock GetVmByVmIdQueryTest ...................................................................... core: UnPowerMock GetVmByVmIdQueryTest Removed PowerMock dependecy from GetVmByVmIdQueryTest. Before this patch, the test was not a good unit test - it did not test just the query, but also VmHandler's functionallity, which should have been tested separately. This patch turns the test into a strict unit teset, which only test's the query's functionallity, and this PowerMock is no longer needed. Change-Id: Ieaf73c28f2321e564d9c9d336dbf33a89e7a2929 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmIdQueryTest.java 2 files changed, 10 insertions(+), 40 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieaf73c28f2321e564d9c9d336dbf33a89e7a2929 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0