May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UnPowerMock DeactivateStorageDomainCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock DeactivateStorageDomainCommandTest ...................................................................... core: UnPowerMock DeactivateStorageDomainCommandTest Removed PowerMock dependency from DeactivateStorageDomainCommandTest, and replaced it with spying the command directly. In order to facilitate the change, ExecuteTransactionAnswer was extracted from AttachStorageDomainToPoolCommandTest and turned into a top-level class. Change-Id: Ifc9c0882e76c17232e285be59a5ffb16b9128fc8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExecuteTransactionAnswer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java 3 files changed, 62 insertions(+), 65 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc9c0882e76c17232e285be59a5ffb16b9128fc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Prepare DeactiveStorageDomainCommand testing
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Prepare DeactiveStorageDomainCommand testing ...................................................................... core: Prepare DeactiveStorageDomainCommand testing Did some refactoring and extraced/pulled-up several resource accessors to facilitate testing in later patches. Change-Id: I9f477348352180ba2348a515a00dae5f4660056e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 4 files changed, 83 insertions(+), 88 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f477348352180ba2348a515a00dae5f4660056e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock AttachStorageDomainToPoolCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock AttachStorageDomainToPoolCommandTest ...................................................................... core: UnPowerMock AttachStorageDomainToPoolCommandTest Removed PowerMock dependency from AttachStorageDomainToPoolCommandTest. To facilitate this change, so minor refactorings were required in AttachStorageDomainToPoolCommand and StorageHandlingCommandBase. Change-Id: I09cb7a1171c9522f28ee15e8b59c3ca7793bfeae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 3 files changed, 94 insertions(+), 93 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09cb7a1171c9522f28ee15e8b59c3ca7793bfeae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: CommandAssertUtils
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: CommandAssertUtils ...................................................................... core: CommandAssertUtils Introduced a new utility class, CommandAssertUtils, which allows using the assertions in BaseMockitoTest statically instead of having to extend it. BaseMockitoTest's functionallity was refactored to call CommandAssertUtils, but the API was left unchanged, for backwards compatibility. Change-Id: I87fd965f937c44f36d943d0e12f0ec052585828e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BaseMockitoTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandAssertUtils.java 2 files changed, 30 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87fd965f937c44f36d943d0e12f0ec052585828e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock RemoveStoragePoolCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock RemoveStoragePoolCommandTest ...................................................................... core: UnPowerMock RemoveStoragePoolCommandTest Removed PowerMock dependency from RemoveStoragePoolCommandTest - it was simply not needed. Change-Id: I14c4a18eb2b4412582e83b536c391287b54851a3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommandTest.java 1 file changed, 4 insertions(+), 14 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14c4a18eb2b4412582e83b536c391287b54851a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock InstallVdsCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock InstallVdsCommandTest ...................................................................... core: UnPowerMock InstallVdsCommandTest Removed dependency on PowerMock from InstallVdsCommandTest. This was done by spying the getVdsDAO() method and using MockConfigRule instead of statically mocking DbFacade and Config. Change-Id: Ibe00bbf18f5d114b9ccb50b3637e21d706a79e10 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/InstallVdsCommandTest.java 1 file changed, 25 insertions(+), 31 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe00bbf18f5d114b9ccb50b3637e21d706a79e10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up time zone query tests
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Clean up time zone query tests ...................................................................... core: Clean up time zone query tests Used MockConfigRule instead of ugly direct mocking on Config. Change-Id: I5e9604598ad5d4a44117842a684c356fbe9de69b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractSysprepQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDefualtTimeZoneQueryTest.java 2 files changed, 7 insertions(+), 23 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e9604598ad5d4a44117842a684c356fbe9de69b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup IConfigUtilsInterface
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup IConfigUtilsInterface ...................................................................... core: Cleanup IConfigUtilsInterface Replaced FCQN with import. Change-Id: I6aa10ad0d8df8dc4066a202209a45b380f147f79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/IConfigUtilsInterface.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6aa10ad0d8df8dc4066a202209a45b380f147f79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock UpdateVmDiskCommandTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock UpdateVmDiskCommandTest ...................................................................... core: UnPowerMock UpdateVmDiskCommandTest Removed PowerMock dependecy from UpdateVmDiskCommandTest, and replaced it with spying some DAO accessors. In order to facilitate this change some refactoring was required in VmCommand and AbstractDiskVmCommand to expose these methods. Change-Id: I580a52a31e08214ee07e14c33d0ad1ee2320d22b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 4 files changed, 71 insertions(+), 66 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I580a52a31e08214ee07e14c33d0ad1ee2320d22b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock GetVmsRelatedToQuotaIdTest
by lhornyak＠redhat.com 25 May '12

25 May '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock GetVmsRelatedToQuotaIdTest ...................................................................... core: UnPowerMock GetVmsRelatedToQuotaIdTest Removed PoerMock dependency by spying the query instead. A minor refactor in GetVmsRelatedToQuotaIdQuery to call getDbFacade() instead of DbFacade.getInstance() was required. Change-Id: Ib36c4791b57e783e4fe109afcca9cebcc71dde19 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdTest.java 2 files changed, 5 insertions(+), 19 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib36c4791b57e783e4fe109afcca9cebcc71dde19 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0