June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: small l&f fix-ups
by gchaplik＠redhat.com 21 Jun '12

21 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: small l&f fix-ups ...................................................................... webadmin: small l&f fix-ups *edit cluster: 'Enable Ovirt..' to 'Enable Virt' *new host: fixing syle in override ip checkbox label Change-Id: I343f52177a9e72cfcc39bf26a27f1e499ff0cee3 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 3 files changed, 13 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I343f52177a9e72cfcc39bf26a27f1e499ff0cee3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: uesrportal: enable edit console iff vm is up
by gchaplik＠redhat.com 21 Jun '12

21 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: uesrportal: enable edit console iff vm is up ...................................................................... uesrportal: enable edit console iff vm is up currently, in user portal (basic view) we can edit a VM's console, even when it's not up. Change-Id: I0baaafd84555872062e9d44a15801aef81f8be16 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0baaafd84555872062e9d44a15801aef81f8be16 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: changed version from 3.0. to 3.1 (#8174...
by lhornyak＠redhat.com 21 Jun '12

21 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: userportal,webadmin: changed version from 3.0. to 3.1 (#817494) ...................................................................... userportal,webadmin: changed version from 3.0. to 3.1 (#817494) https://bugzilla.redhat.com/817494 In about dialog changed the version from 3.0.0.0 to 3.1.0.0 Change-Id: I010b3af1b74e137e4a8ac8312e2c276f306af6a7 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I010b3af1b74e137e4a8ac8312e2c276f306af6a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Unable to add bond through SetupNetworks (#828351)
by mkolesni＠redhat.com 21 Jun '12

21 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Unable to add bond through SetupNetworks (#828351) ...................................................................... core: Unable to add bond through SetupNetworks (#828351) https://bugzilla.redhat.com/828351 Creating a bond via rest-api using SetupNetworks commands ended with NPE since the boot protocol wasn't provided for a bond. The patch prevent from setting a boot protocol if wasn't specified, instead its value will be set to none by vdsm. Change-Id: Ia81ac5a350e033ae07c7e2708573492529d00d89 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/5568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia81ac5a350e033ae07c7e2708573492529d00d89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: changed the IsVmTemlateWithSameNameExist to user
by tnisan＠redhat.com 21 Jun '12

21 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: engine: changed the IsVmTemlateWithSameNameExist to user ...................................................................... engine: changed the IsVmTemlateWithSameNameExist to user Since the IsVmTemlateWithSameNameExist is called from user portal when editing the template, it needed to be a user query. It can be defined as a user query while not actually filtering the result, since it does not return any sensitive information. The same approach is used in IsVmWithSameNameExist. Change-Id: Ic03e9dfb2e00e7957f6a077917b85c41ffffcecd Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic03e9dfb2e00e7957f6a077917b85c41ffffcecd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Return 1 from StoreUtils on error
by lhornyak＠redhat.com 21 Jun '12

21 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Return 1 from StoreUtils on error ...................................................................... core: Return 1 from StoreUtils on error The StoreUtils class should return 1 when an exception is generated during the execution of the tool. Change-Id: Icc6d3c0f26128bfc2418bbb4da85440909003b59 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/StoreUtils.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc6d3c0f26128bfc2418bbb4da85440909003b59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: there is no validation on domain status when deleting ...
by mkublin＠redhat.com 21 Jun '12

21 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: there is no validation on domain status when deleting snapshot (#834021) ...................................................................... core: there is no validation on domain status when deleting snapshot (#834021) https://bugzilla.redhat.com/834021 The bug is not correct a validation does exist, but in order to validate a call to vdsm is send, it is not needed for that case, because the engines knows that status of domain at DB is maintaince. So, in order to solve a problem I change order of checks Change-Id: I5fc120f5fffbad125b71b0d8339484f37bd016b1 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fc120f5fffbad125b71b0d8339484f37bd016b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Close store file after use
by lhornyak＠redhat.com 21 Jun '12

21 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Close store file after use ...................................................................... core: Close store file after use We need to close the keystore file after using it, otherwise we will have a file descriptor leak. Change-Id: I3b0546374668113de4b50871e0fdd985740e04cf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b0546374668113de4b50871e0fdd985740e04cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Robert Middleswarth <robert(a)middleswarth.net>

1 0

Change in ovirt-engine[master]: core: Deadlock on reconstruct master flow (#795105)
by mkublin＠redhat.com 21 Jun '12

21 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Deadlock on reconstruct master flow (#795105) ...................................................................... core: Deadlock on reconstruct master flow (#795105) https://bugzilla.redhat.com/795105 The following fix should solve a deadlock which was caused because of during reconstract flow were taken IrsProxyData.syncObj lock and we tried to take VdsManger._lockObj lock. The second thread started domain recovery and take a VdsManger._lockObj and tried to take IrsProxyData.syncObj These happend because of reconstruct already had succeeded and almost finished, that's why domain failover run with out any problem. Solution we don't need to run reconstruct inside critical section protected by IrsProxyData.syncObj Change-Id: I1e077a0722c4ae5a277fd85f11b8d0a353182c15 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 38 insertions(+), 32 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e077a0722c4ae5a277fd85f11b8d0a353182c15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Edit storage - incorrect number of LUN paths
by derez＠redhat.com 20 Jun '12

20 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Edit storage - incorrect number of LUN paths ...................................................................... webadmin: Edit storage - incorrect number of LUN paths When editing iSCSI/FCP storage domain, LUNs' paths size hasn't been reflected properly. Fixed by using 'GetDeviceList' LUNs entities, instead of 'GetLunsByVgId' (which doesn't update 'path' value). Change-Id: Ia0e1cf888579ca9a8f1a14f113143e7423501ac0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 18 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e1cf888579ca9a8f1a14f113143e7423501ac0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0