June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: No red warning when export template that already e...
by gchaplik＠redhat.com 28 Jun '12

28 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: No red warning when export template that already exists. ...................................................................... webadmin: No red warning when export template that already exists. Template -> select one -> Export If this template has already been exported, the popup shuld contain a red message which warns that this has already been exported. The problem was in TemplateListModel.showWarningOnExistingTemplates method which used synchronous queries to retrive storage_pool and templates on the export domain which does not work on the GWT envirotnment. Fixed by extracting and generalizing the correct logic from VmListModel to a common parent VmBaseListModel and calling this common logic. Added also a progress animation, until all the required data are fetched from server, so will not happen, that the window will not contain the warning message for a while and will look like there is no warning. Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 3 files changed, 309 insertions(+), 347 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: allow snapshots for imported templates
by ofrenkel＠redhat.com 28 Jun '12

28 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: allow snapshots for imported templates ...................................................................... core: allow snapshots for imported templates when importing template, the AllowSnapshot is not initialized, so by default its false, making all the disks not allowed to have snapshots. this value is copied to the vms and is problematic. when importing template, it is safe to assume that the AllowSnapshot is true for the disks, as we only export disks that AllowSnapshot is true. (this already happens for vms, this patch fix this for templates) Change-Id: I12413c8b63a0085bbdb68419318eea77a95c85dd Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12413c8b63a0085bbdb68419318eea77a95c85dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: tools: ISO Uploader not refreshing domains (#832158)
by kroberts＠redhat.com 27 Jun '12

27 Jun '12

Keith Robertson has submitted this change and it was merged. Change subject: tools: ISO Uploader not refreshing domains (#832158) ...................................................................... tools: ISO Uploader not refreshing domains (#832158) https://bugzilla.redhat.com/832158 Signed-off-by: Keith Robertson <kroberts(a)redhat.com> Change-Id: If84760f6d7c2657467e5fbd848b0c534455fae72 Signed-off-by: Keith Robertson <kroberts(a)redhat.com> --- M src/engine-iso-uploader.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved Keith Robertson: Verified -- To view, visit http://gerrit.ovirt.org/5464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If84760f6d7c2657467e5fbd848b0c534455fae72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: GlusterOnly - hiding load column in cluster host s...
by gchaplik＠redhat.com 27 Jun '12

27 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: GlusterOnly - hiding load column in cluster host subtab ...................................................................... webadmin: GlusterOnly - hiding load column in cluster host subtab Load column in host sub tab in Cluster will be hidden if the ApplicationMode doesn't support VIRT. Change-Id: I3cc7ae901ef603a5ec90da008e16bca1ad3c0107 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterHostView.java 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cc7ae901ef603a5ec90da008e16bca1ad3c0107 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding null check for cluster in VolumePopup
by gchaplik＠redhat.com 27 Jun '12

27 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding null check for cluster in VolumePopup ...................................................................... webadmin: Adding null check for cluster in VolumePopup A NPE was thrown in the user tries to add bricks without selecting any cluster. Add Bricks button will be disabled if the cluster list empty or no cluster selected. Change-Id: Ia249bd879351ede027492f9a44acddf27fe7a530 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia249bd879351ede027492f9a44acddf27fe7a530 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: SetupNetworks- Split unassigned networks
by gchaplik＠redhat.com 27 Jun '12

27 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: SetupNetworks- Split unassigned networks ...................................................................... webadmin: SetupNetworks- Split unassigned networks https://bugzilla.redhat.com/823881 SetupNetworks- Split unassigned networks panel to required and non-required panels. Change-Id: I8630a2afff46b4daf86c6e95c84b65bd92d2800a Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java 5 files changed, 80 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8630a2afff46b4daf86c6e95c84b65bd92d2800a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hourglass on Add-Edit block storage dialog
by derez＠redhat.com 27 Jun '12

27 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: hourglass on Add-Edit block storage dialog ...................................................................... webadmin: hourglass on Add-Edit block storage dialog * Fixing 'hour-glass' on block storage domain Add-Edit Dialog. * Fixing included LUNs indication ('V' icon). Change-Id: Ie04e20a91a26f12829b97d54586c85566761d173 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java 7 files changed, 156 insertions(+), 75 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie04e20a91a26f12829b97d54586c85566761d173 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: calling GetLunsByVgId query by Host ID
by derez＠redhat.com 27 Jun '12

27 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: calling GetLunsByVgId query by Host ID ...................................................................... webadmin: calling GetLunsByVgId query by Host ID Edit Block Storage dialog: * Fetching LUNs stored in DB using 'GetLunsByVgId'. * Passing host's ID in query's parameters for calling GetDeviceList: (needed for updating path count for each LUN). Change-Id: Iaf817d0dc33a30b4cad2d7746c86ca9f813581da Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 25 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf817d0dc33a30b4cad2d7746c86ca9f813581da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: GetLunsByVgId - update LUNs path count
by derez＠redhat.com 27 Jun '12

27 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: core: GetLunsByVgId - update LUNs path count ...................................................................... core: GetLunsByVgId - update LUNs path count GetLunsByVgId query should return a list of LUNs by a VG ID: * The query fetches from DB all LUNs associated with the VG. * In order to update 'PathsDictionary' for each LUN, ** calling 'GetDeviceList' (gets all LUNs available from the specified host) ** LUN's 'PathsDictionary' is initialized by parsing 'pathstatus' ** update LUNs from DB objects Change-Id: I7cf04c2026d6d49238516e4490b801e594b74fcb Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetLunsByVgIdParameters.java 4 files changed, 116 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cf04c2026d6d49238516e4490b801e594b74fcb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:upgrade from rhevm is not possible
by emesika＠redhat.com 27 Jun '12

27 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core:upgrade from rhevm is not possible ...................................................................... core:upgrade from rhevm is not possible upgrade from rhevm is not possible (ISO list is empty) Removing a redundant check in the UI that although query validations checks in the core passed, did another check and removed items from the list of ISO returned from core. The problem was that when the vdsm getCapabilities fail, the OS version is null/empty. We should enable the user upgrade using available ISO files event if getCapabilities fails. Apart from that, the deleted UI code does a check that is already handled by BLL code and anyway should not be done by UI. Change-Id: I4992c74b0f05cd3da7829c5749c1b95eba353f8a Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4992c74b0f05cd3da7829c5749c1b95eba353f8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0