June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Gluster Volume - Summary tab changes, localization
by gchaplik＠redhat.com 04 Jun '12

04 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume - Summary tab changes, localization ...................................................................... webadmin: Gluster Volume - Summary tab changes, localization Volume type in summary sub tab is localized. Replica and Stripe counts will be visible according to volume type. Change-Id: I139feb546a0a86c8a223f4b1bf04e92d8dffd992 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java 4 files changed, 84 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I139feb546a0a86c8a223f4b1bf04e92d8dffd992 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: RunMultipleAction - execution status checks remove...
by gchaplik＠redhat.com 04 Jun '12

04 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: RunMultipleAction - execution status checks removed ...................................................................... webadmin: RunMultipleAction - execution status checks removed In case of RunMutipleAction, the execution of the actions are asynchronous in the Backend, so the execution statuses should not be checked in the Frontend. Only CanDoAction can be checked as it is synchronous. Change-Id: I6b99d3374a7f76110c5939633e4625d3e9e65db0 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b99d3374a7f76110c5939633e4625d3e9e65db0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixing findbugs issue at StorageListmodel
by gchaplik＠redhat.com 04 Jun '12

04 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixing findbugs issue at StorageListmodel ...................................................................... webadmin: Fixing findbugs issue at StorageListmodel equals should be used instead of == Change-Id: I7857433c45364b1a33c533417f032ac2bba9e8c2 Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7857433c45364b1a33c533417f032ac2bba9e8c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: styling quota threshold & grace
by gchaplik＠redhat.com 04 Jun '12

04 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: styling quota threshold & grace ...................................................................... webadmin: styling quota threshold & grace adding ui slider widgets Change-Id: I25e15e6eeeee7901ef155412d917ecdaf4540a3e Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.ui.xml 4 files changed, 139 insertions(+), 42 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25e15e6eeeee7901ef155412d917ecdaf4540a3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fixing quota ui bugs
by gchaplik＠redhat.com 04 Jun '12

04 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fixing quota ui bugs ...................................................................... webadmin: fixing quota ui bugs Change-Id: I7a9c2e76817aaddd020a84a4e97d7839378b8822 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java 2 files changed, 35 insertions(+), 12 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a9c2e76817aaddd020a84a4e97d7839378b8822 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : duplicate HDD name during creating new HDD (#769885)
by mkublin＠redhat.com 04 Jun '12

04 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core : duplicate HDD name during creating new HDD (#769885) ...................................................................... core : duplicate HDD name during creating new HDD (#769885) https://bugzilla.redhat.com/769885 The following bug was caused because of race inside lock of vm process, from now there are no need for uniqnes of hdd names and also no need to lock vm when we are adding a disk. A patch contains the following: 1. Removed lock from vm 2. Adding compenstaion at AddDiskToVmCommand 3. Fixing bug with compensation at AddDiskCommand 4. Using a new lock mechanism fixing races Change-Id: Ic4dbf9c451205b8c3a4c3510661a5d410c9a8195 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java 5 files changed, 110 insertions(+), 80 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4dbf9c451205b8c3a4c3510661a5d410c9a8195 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume - hide rebalance, replace brick
by gchaplik＠redhat.com 04 Jun '12

04 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume - hide rebalance, replace brick ...................................................................... webadmin: Gluster Volume - hide rebalance, replace brick Rebalce and Replace bricks actions will be hidden for now as these will only start the process and there is no tracking as well currently. Host General tab items were wrongly hidden in all modes. Now a check is added to hide only in GlusterOnly. Change-Id: I4176870f55675a2ede82b2a97a0c6541438785c5 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 3 files changed, 10 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4176870f55675a2ede82b2a97a0c6541438785c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add query for getting storages by image id
by mlipchuk＠redhat.com 04 Jun '12

04 Jun '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add query for getting storages by image id ...................................................................... core: Add query for getting storages by image id Adding new query for fetching all storage domains by image id. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I21f5230cdd0239e6b2975e1c1dfd9f7e494071d6 --- M backend/manager/dbscripts/storages_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 9 files changed, 151 insertions(+), 57 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f5230cdd0239e6b2975e1c1dfd9f7e494071d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: changing jbossas to ovirt-engine in service restart in...
by yzaslavs＠redhat.com 04 Jun '12

04 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: changing jbossas to ovirt-engine in service restart in utlities ...................................................................... core: changing jbossas to ovirt-engine in service restart in utlities In the new ovirt service, the service is you need to restart is ovirt-engine, and not the jboss service. Changed the documentation in the utilities accordingly. Change-Id: I9b26bcdf8073dd693aeefe955f8bf476a41ba284 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java M backend/manager/tools/engine-config/src/main/resources/engine-config 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b26bcdf8073dd693aeefe955f8bf476a41ba284 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: resstapi: Fix missing "actions" under vm nics
by mpastern＠redhat.com 04 Jun '12

04 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: resstapi: Fix missing "actions" under vm nics ...................................................................... resstapi: Fix missing "actions" under vm nics Change-Id: I3b2b0506351d7cbafcd3ee4de6a478c26a6b5caa Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b2b0506351d7cbafcd3ee4de6a478c26a6b5caa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0