August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ImportVmCommand - changed method UpdateVmImSpm() name
by derez＠redhat.com 12 Aug '12

12 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core: ImportVmCommand - changed method UpdateVmImSpm() name ...................................................................... core: ImportVmCommand - changed method UpdateVmImSpm() name changed the method's name to updateVmInSpm to meet java naming standards Change-Id: Id48b6283fdd06dd2d14046516b91caaf52771155 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id48b6283fdd06dd2d14046516b91caaf52771155 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: reomve redundant upgrade to config entry
by rgolan＠redhat.com 12 Aug '12

12 Aug '12

Roy Golan has submitted this change and it was merged. Change subject: core: reomve redundant upgrade to config entry ...................................................................... core: reomve redundant upgrade to config entry this upgrade is already handled in dbscripts/upgrade/preupgrade/000_config.sql Change-Id: I7b7700b75b2eaa42e8dadd9790b8a39cd0be6700 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- D backend/manager/dbscripts/upgrade/03_01_0820_add_domains_ldap_provider_types 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b7700b75b2eaa42e8dadd9790b8a39cd0be6700 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cannot replace management network nic (#840888)
by masayag＠redhat.com 12 Aug '12

12 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Cannot replace management network nic (#840888) ...................................................................... core: Cannot replace management network nic (#840888) https://bugzilla.redhat.com/840888 The patch allows to replace the underlying interface for the management network. It verifies no previous network is attached to the destination nic and also deny updating the management network to non-management network. Change-Id: Id8504509b0204ef4d16d7519f9bb57f519307614 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 38 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8504509b0204ef4d16d7519f9bb57f519307614 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Response Body For Activate-Deactivate Disk
by oliel＠redhat.com 12 Aug '12

12 Aug '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Response Body For Activate-Deactivate Disk ...................................................................... restapi: Response Body For Activate-Deactivate Disk Change-Id: Ic05e80172552faec173c833a7c812856b7829147 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic05e80172552faec173c833a7c812856b7829147 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix Response Body For Setup-Networks
by oliel＠redhat.com 12 Aug '12

12 Aug '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix Response Body For Setup-Networks ...................................................................... restapi: Fix Response Body For Setup-Networks Change-Id: Ic25e80167722fabc173c833a7c872856b7829147 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic25e80167722fabc173c833a7c872856b7829147 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RegisterVdsQuery - removed uneeded logger
by oourfali＠redhat.com 12 Aug '12

12 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: RegisterVdsQuery - removed uneeded logger ...................................................................... core: RegisterVdsQuery - removed uneeded logger there is a logger already defined in this class hirerchy, therefore removed the one defined in RegisterVdsQuery Change-Id: I81ef8763d9d62e54b01ccf24f33d73c03bc05cb0 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ef8763d9d62e54b01ccf24f33d73c03bc05cb0 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Make NetworkOperationsConnectivity configurable (#8407...
by masayag＠redhat.com 12 Aug '12

12 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Make NetworkOperationsConnectivity configurable (#840746) ...................................................................... core: Make NetworkOperationsConnectivity configurable (#840746) https://bugzilla.redhat.com/840746 The patch exposes NetworkConnectivityCheckTimeoutInSeconds configuration value via the engine-config tool and assign to it valid values of: 10-160 seconds. The lower boundary (10) designed to prevent preliminary rollback. The upper boundary (160) designed to remain a reasonable period for rollback before the default value of vdsTimeout (180 seconds). The last assumption is made since there is no support dependency between two configuration values. If a user increases the default value of vdsTimeout, same can be done for NetworkConnectivityCheckTimeoutInSeconds by extending the valid value as specified in /etc/ovirt-engine/engine-config/engine-config.properties Change-Id: Ie8425e3a10636f5a409c6748f6f17858c3ff666c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8425e3a10636f5a409c6748f6f17858c3ff666c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Change error message when using occupied or reser...
by oschreib＠redhat.com 12 Aug '12

12 Aug '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Change error message when using occupied or reserved ports (#BZ813688) ...................................................................... packaging: Change error message when using occupied or reserved ports (#BZ813688) https://bugzilla.redhat.com/show_bug.cgi?id=813688 When user is trying use an occupied or reserved ports for engine or DB, engine-setup prints to a user unclear error message. This patch improves error message that will be provided to a user. Change-Id: Idf2128a9bdd96eab550e96483b6447969755cef8 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf2128a9bdd96eab550e96483b6447969755cef8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: quota fix-ups (#845059)
by gchaplik＠redhat.com 12 Aug '12

12 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: quota fix-ups (#845059) ...................................................................... core: quota fix-ups (#845059) https://bugzilla.redhat.com/845059 * mixup in checking memory validation (org checked vcpu in mistake) * end with failure to add disk clean quota Change-Id: I286dbc97c8f8ed7a2dfb60cc761bf381b5433105 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I286dbc97c8f8ed7a2dfb60cc761bf381b5433105 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Moved configuring ovirt-engine to utils.
by oschreib＠redhat.com 12 Aug '12

12 Aug '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Moved configuring ovirt-engine to utils. ...................................................................... packaging: Moved configuring ovirt-engine to utils. * Moved editSyconfig function that edits the ovirt-engine configuration. * Moved encryptDbPassword and configEncryptedPass functions that encrypt db password and update the ovirt-engine configuration. Change-Id: Iaeec79b342ebdd1b4ffabee32fd878313d8df725 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py 2 files changed, 78 insertions(+), 56 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeec79b342ebdd1b4ffabee32fd878313d8df725 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0