August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: cleanup DiskConditionFieldAutoCompleter
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup DiskConditionFieldAutoCompleter ...................................................................... core: cleanup DiskConditionFieldAutoCompleter - replaced variable.equals("CONSTANT") and StringHelper.EqOp(variable, "CONSTANT") to "CONSTANT".equals(variable) Change-Id: I04ce9a88d2799c9abb89d3676833234319005e70 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java 1 file changed, 15 insertions(+), 18 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04ce9a88d2799c9abb89d3676833234319005e70 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix null-support in search queries (#845297)
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: fix null-support in search queries (#845297) ...................................................................... core: fix null-support in search queries (#845297) Fixes the support for searching columns with null values. In this case, the generated sql-syntax must be 'is null'/'is not null'. The query syntax now handles the 'null' string as special value. Change-Id: Ia8931d12b5dc4450eddfc6f2a669bd87cae4ae57 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8931d12b5dc4450eddfc6f2a669bd87cae4ae57 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter cleanup
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: BaseConditionFieldAutoCompleter cleanup ...................................................................... core: BaseConditionFieldAutoCompleter cleanup - replaced variable.equals("CONSTANT") with "CONSTANT".equals(variable) - replaced StringHelper.EqOp(variable, "CONSTANT") with "CONSTANT".equals(variable) Change-Id: Ibbe7bff1b6c620ef58ffc8ff99f2e8b6a486e0bf Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 1 file changed, 13 insertions(+), 28 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbe7bff1b6c620ef58ffc8ff99f2e8b6a486e0bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: autocompletion support for NULL (#845297)
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: autocompletion support for NULL (#845297) ...................................................................... core: autocompletion support for NULL (#845297) https://bugzilla.redhat.com/845297 Autocompletion support for search queries Change-Id: Ide95b10b7ee5e94af1a9413c48c32820d3cd70da Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NullableStringAutoCompleter.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml 2 files changed, 35 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide95b10b7ee5e94af1a9413c48c32820d3cd70da Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup V
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup V ...................................................................... core: SyntaxChecker cleanup V - moves the processing logic to generateSafeConditionStatement, only - the old generateConditionStatment is generating a safeValue, this value is passed over to generateSafeConditionStatement, the originalValue and isSafe are no longer passed Change-Id: I4034db4e89dfd4450a3d2f01c8adbd018e914468 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4034db4e89dfd4450a3d2f01c8adbd018e914468 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup IV
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup IV ...................................................................... core: SyntaxChecker cleanup IV - refactored customizedRelation initialization to a separate method (buildCustomizedRelation) Change-Id: I76c4c8acd6e4236027927c74d8daa0fbda0a51cb Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 33 insertions(+), 13 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c4c8acd6e4236027927c74d8daa0fbda0a51cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup III
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup III ...................................................................... core: SyntaxChecker cleanup III - refactored the computation of the customizedValue value to a new method (buildCustomizedValue) Change-Id: I3bfa411978cff11db35069f5bf363dbedbb881ba Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 36 insertions(+), 19 deletions(-) Approvals: Laszlo Hornyak: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bfa411978cff11db35069f5bf363dbedbb881ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Option with empty name and value ...
by emesika＠redhat.com 10 Aug '12

10 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Option with empty name and value ... ...................................................................... core: Option with empty name and value ... Option with empty name and value in the request's xml to rest-api should not be allowed. The problem is not with the PM options, this is working without a problem. There is a leading blank in the UUID of the DC in the request that caused the exception. Adding a check for DC ID validity in canDoAction of ConnectStorageToVdsCommand command. Change-Id: I8d53cc13dc6669e02020cf1a5bfacb4fc1285b74 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d53cc13dc6669e02020cf1a5bfacb4fc1285b74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)
by emesika＠redhat.com 10 Aug '12

10 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: misleading error when trying to fen(#843168) ...................................................................... core: misleading error when trying to fen(#843168) ovirt-engine-backend: misleading error when trying to fence host without PM configured https://bugzilla.redhat.com/843168 Problem was that the code in the canDoAction of the base class was not adding any message if fencing is not configured in the host and also retries the operation event though there is no chance that it will succeed. Changing the code to add a message when Start/Stop is called on a non configured Host. Make StopVdsCommand call the super.canDoAction in the same manner as StartVdsCommand does. Change-Id: I7aab4f6a7c70fa5e18db106ea15a7b20b709db28 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java 2 files changed, 10 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aab4f6a7c70fa5e18db106ea15a7b20b709db28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)
by emesika＠redhat.com 10 Aug '12

10 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core:we do not clean alerts from the weba(#840495) ...................................................................... core:we do not clean alerts from the weba(#840495) we do not clean alerts from the webadmin once fixed https://bugzilla.redhat.com/840495 Changing the Alert text as suggested in the bug. Change-Id: Iefc3d948e73403933a1ea129a7c50818fedcf610 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefc3d948e73403933a1ea129a7c50818fedcf610 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0