August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: NPE in remove from export domain (#847652)
by gchaplik＠redhat.com 28 Aug '12

28 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: NPE in remove from export domain (#847652) ...................................................................... core: NPE in remove from export domain (#847652) https://bugzilla.redhat.com/847652 While removing VM/Template from export domain, in endCommand we construct the command again and try to fetch the vm/template, which will fail (because the vm/template doesn't exist), therefore, we need a Null check there. Change-Id: I8b65227d94ba426b943181398fcd06b6137638fa Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 2 files changed, 16 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b65227d94ba426b943181398fcd06b6137638fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove check for permissions on pool on detach user fr...
by ofrenkel＠redhat.com 28 Aug '12

28 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove check for permissions on pool on detach user from vm (#850741) ...................................................................... core: remove check for permissions on pool on detach user from vm (#850741) https://bugzilla.redhat.com/show_bug.cgi?id=850741 When detaching user from pool-vm, there is a check that the user has permissions on the pool. this check is not correct since user may have lost his permissions on the pool before stopping the vm, this check was removed. anyway user is detached from vms in this pool so it has no meaning. Change-Id: I3bfb1a741c6be33427e94d944a8c41d3553cba80 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bfb1a741c6be33427e94d944a8c41d3553cba80 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, packaging: Don't use JBoss default ports (#831193)
by juan.hernandez＠redhat.com 28 Aug '12

28 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: core, packaging: Don't use JBoss default ports (#831193) ...................................................................... core, packaging: Don't use JBoss default ports (#831193) https://bugzilla.redhat.com/831193 This patch changes the default ports used by the engine so that they don't conflict with the default ports used by JBoss. The port numbers proposed are the following: http: 8700 https: 8701 ajp: 8702 remoting: 8703 txn-recovery: 8704 txn-status: 8705 Why these port numbers and not others? 1. They are not allocated according to /etc/services. 2. They are reasonably low. 3. The 8700-8731 range is not allocated by IANA, so we could request them for ovirt-engine, to reduce the chances of conflicts in the future. 4. 8700 is reasonabley easy to remember. 5. They are reasonably far away from the ranges used by VNC and spice displays of virtual machines. Change-Id: I3c0ffcab66fe9ae6f3dcb932040feb4421e18bf6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/conf/engine.conf.defaults M backend/manager/conf/standalone.xml M backend/manager/dbscripts/config_devel.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkHelperTest.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/error-notifier.conf M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/notifier.conf M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M packaging/fedora/engine-service.xml.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/ovirt_port80.py 16 files changed, 36 insertions(+), 36 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c0ffcab66fe9ae6f3dcb932040feb4421e18bf6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: vm migration in case of failure is..(#818289)
by emesika＠redhat.com 28 Aug '12

28 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: vm migration in case of failure is..(#818289) ...................................................................... core: vm migration in case of failure is..(#818289) ovirt-engine-backend [Task Manager]: vm migration in case of failure is not logged in task manager. https://bugzilla.redhat.com/show_bug.cgi?id=818289 The bug was that not all calls to VdcActionType.SetNonOperationalVds set the job execution context. Adding creation of job execution context to all places where a call to VdcActionType.SetNonOperationalVds is issued. Change-Id: I0d4599498f3c604c703e008601b1bc5f4972fe51 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 5 files changed, 10 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d4599498f3c604c703e008601b1bc5f4972fe51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Updated backups folder creation
by juan.hernandez＠redhat.com 27 Aug '12

27 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated backups folder creation ...................................................................... packaging: Updated backups folder creation Change-Id: I0e79b78f4448bbe5f20b4836983e916b60c06acd Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alex Lourie: Verified; Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e79b78f4448bbe5f20b4836983e916b60c06acd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Deatch network doesn't closed in case of an error ...
by alkaplan＠redhat.com 27 Aug '12

27 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Deatch network doesn't closed in case of an error (#849889) ...................................................................... webadmin: Deatch network doesn't closed in case of an error (#849889) https://bugzilla.redhat.com/849889 If after detaching a network from a vm the is an error, the detach dialog remain open. Change-Id: I156a2d0cbbd559fed6966fcffad571545a7f1518 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I156a2d0cbbd559fed6966fcffad571545a7f1518 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add confirm dialog to "save network configuration"...
by alkaplan＠redhat.com 27 Aug '12

27 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add confirm dialog to "save network configuration" (#823922) ...................................................................... webadmin: Add confirm dialog to "save network configuration" (#823922) https://bugzilla.redhat.com/823922 The dialog should be added just to the "save network configuration" action on SubTabHostInterface, not to the check box on (SetupNetwork, Add/Edit, detach...) Change-Id: Ic36412f1075b13ec34a4f959a4ab615ed18ae03e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 57 insertions(+), 20 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36412f1075b13ec34a4f959a4ab615ed18ae03e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix potential NPE in MainTabHostView
by ecohen＠redhat.com 27 Aug '12

27 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE in MainTabHostView ...................................................................... webadmin: Fix potential NPE in MainTabHostView In Host "Load" column, fixed potential NPE coming from getProgressValue() method. Change-Id: I2552b3a917b848472ba9964e49d0e60d45cba0d3 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2552b3a917b848472ba9964e49d0e60d45cba0d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: call AttachDiskToVm with RunAction (#849443)
by derez＠redhat.com 27 Aug '12

27 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: call AttachDiskToVm with RunAction (#849443) ...................................................................... webadmin: call AttachDiskToVm with RunAction (#849443) https://bugzilla.redhat.com/849443 Calling AttachDiskToVm using RunAction instead of RunMultipleAction - in order to ensure PCI limit check (regarding IDE/virtIO disks limit). Change-Id: Ic771ef86926c471ed46524c77a0fdfafc00c63cf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 5 files changed, 53 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic771ef86926c471ed46524c77a0fdfafc00c63cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added functions references for cleaner code.
by juan.hernandez＠redhat.com 27 Aug '12

27 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Added functions references for cleaner code. ...................................................................... packaging: Added functions references for cleaner code. Change-Id: Ic8fec87bf8dc99e990cb62d85e2915246f38fbac Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fec87bf8dc99e990cb62d85e2915246f38fbac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0