August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, ui: prevent cow shareable disk creation (#848021)
by derez＠redhat.com 27 Aug '12

27 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core,ui: prevent cow shareable disk creation (#848021) ...................................................................... core,ui: prevent cow shareable disk creation (#848021) https://bugzilla.redhat.com/848021 Preventing creation of shareable DiskImage that is COW formatted (since the combination is unsupported). core: * Added validations to AddDiskCommand and UpdateVmDiskCommand (updated tests accordingly). * Added error messages in VdcBllMessages and AppErrors. ui: * Added validations to 'Add Disk' dialog (I.e. disabled Shareable check-box for unsupported combinations). Change-Id: Ie9594978c0b509fd540803e9dc4137266bd0501b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 230 insertions(+), 29 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9594978c0b509fd540803e9dc4137266bd0501b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Cant add correlation id to detach HostNIC #851031
by mpastern＠redhat.com 27 Aug '12

27 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Cant add correlation id to detach HostNIC #851031 ...................................................................... restapi: Cant add correlation id to detach HostNIC #851031 https://bugzilla.redhat.com/show_bug.cgi?id=851031 Change-Id: Ied9786ee4f7e3542269bbecd1a3d1de545abfd08 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied9786ee4f7e3542269bbecd1a3d1de545abfd08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Cant add correlation id to restore snapshot #851232
by mpastern＠redhat.com 27 Aug '12

27 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Cant add correlation id to restore snapshot #851232 ...................................................................... restapi: Cant add correlation id to restore snapshot #851232 https://bugzilla.redhat.com/show_bug.cgi?id=851232 Change-Id: I4446db705d3bb3713b6adef2b74c7c9f81179d74 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4446db705d3bb3713b6adef2b74c7c9f81179d74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: update guest agent info on GetAllVmsQuery (#848048)
by ofrenkel＠redhat.com 27 Aug '12

27 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: update guest agent info on GetAllVmsQuery (#848048) ...................................................................... core: update guest agent info on GetAllVmsQuery (#848048) https://bugzilla.redhat.com/show_bug.cgi?id=848048 GetAllVmsQuery did not return guest agent info, causing user-portal not sending vmLogon, so SSO couldn't work. Change-Id: I99fdfaba14c2fee767aed48d86cf149c10439175 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsQuery.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99fdfaba14c2fee767aed48d86cf149c10439175 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove old mocking references from bll's pom
by mkolesni＠redhat.com 27 Aug '12

27 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Remove old mocking references from bll's pom ...................................................................... core: Remove old mocking references from bll's pom Removed references to PowerMock and EasyMock that are no longer by bll's tests. Change-Id: Ib3ea009b7a5eec2a65d5c62fd247dad20225cda4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/pom.xml 1 file changed, 0 insertions(+), 31 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ea009b7a5eec2a65d5c62fd247dad20225cda4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix quota calc for stateless (#848107)
by dfediuck＠redhat.com 26 Aug '12

26 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix quota calc for stateless (#848107) ...................................................................... core: Fix quota calc for stateless (#848107) https://bugzilla.redhat.com/848107 The quota calculation for stateless vm runs was wrong and the error message shown in the UI was uninformative. The calculation was fixed - the size of storage consumed from the quota is the size of the snapshot taken in order to run in stateless mode. The informative error messages are forwarded from the backend. Added a release for storage quota when a vm is stopped or removed. The caching of the quota is actuly dropped - so the next time it will be called it will be recalculated from the DB. Change-Id: I4fa99abecfb48a1fc04b7906be8167846ecc629e Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 170 insertions(+), 17 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fa99abecfb48a1fc04b7906be8167846ecc629e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: bad value mapping causes audio device AC97 to be ignor...
by emesika＠redhat.com 26 Aug '12

26 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: bad value mapping causes audio device AC97 to be ignored (#850823) ...................................................................... core: bad value mapping causes audio device AC97 to be ignored (#850823) Change-Id: I437eee25988de0b3ee74fe46ba79e2d708c3d37d Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437eee25988de0b3ee74fe46ba79e2d708c3d37d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix updating a Vm console type will update video devic...
by emesika＠redhat.com 26 Aug '12

26 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix updating a Vm console type will update video devices ...................................................................... core: fix updating a Vm console type will update video devices if the console type has changed or the number of monitors, the video devices should be updated as well. Change-Id: I8c859b262b95bed476add0b8177dc89f3d25e063 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c859b262b95bed476add0b8177dc89f3d25e063 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)
by emesika＠redhat.com 26 Aug '12

26 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix adding the right video device type (#849635) ...................................................................... core: fix adding the right video device type (#849635) https://bugzilla.redhat.com/show_bug.cgi?id=849635 when adding a new VM the console type chosen by the user (spice,vnc) should be reflected in creating appropriate underlying video device in vm_device table, i.e qxl for spice and cirrus for vnc. Verified: - Adding Server/Desktop VM with spice/vnc console from blank/other templates. - Make Template from VM - Create Vm from snapshot - Import/Export VM/Template Change-Id: I3d28d171b53eb5d44a97f0956384b1012ab5cd1f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 5 files changed, 57 insertions(+), 36 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d28d171b53eb5d44a97f0956384b1012ab5cd1f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: unable to remove more then one quota at a time (#8...
by gchaplik＠redhat.com 26 Aug '12

26 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: unable to remove more then one quota at a time (#848816) ...................................................................... webadmin: unable to remove more then one quota at a time (#848816) https://bugzilla.redhat.com/848816 Problem: Remove button got grayed out if more then one quota was selected Solution: Fixed remove button disable condiotion Change-Id: Iad182fbdcf7b621757b57e17ec516794ab708dbc Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad182fbdcf7b621757b57e17ec516794ab708dbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0