September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: reports: open reports via webadmin - host or vm gives except...
by ydary＠redhat.com 16 Sep '12

16 Sep '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: open reports via webadmin - host or vm gives exception (#855865) ...................................................................... reports: open reports via webadmin - host or vm gives exception (#855865) https://bugzilla.redhat.com/855865 Exception tends to occur in the reports integration. The details of this exception is: org.ovirt.authentication.EngineUserDetails cannot be cast to com.jaspersoft.jasperserver.api.metadata.user.domain.User This shouldn't happen, as jasper is supposed to convert the EngineUserDetails from the token to its own user details, and leave the original details in originalAuthentication field. However, in this patch, when re-authentication is needed, we leave the current authentication object, setting only our user details. That way, jasper doesn't need to recreate their own user details every time. Change-Id: Ie9c2ce53018e2b9d08edb5d0162c584c81ac03d5 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M reports/jars/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c2ce53018e2b9d08edb5d0162c584c81ac03d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Renamed AddVmDynamic() to addVmDynamic() in AddVmComma...
by lhornyak＠redhat.com 14 Sep '12

14 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Renamed AddVmDynamic() to addVmDynamic() in AddVmCommand. ...................................................................... core: Renamed AddVmDynamic() to addVmDynamic() in AddVmCommand. Renamed AddVmDynamic() to addVmDynamic() in AddVmCommand to conform to conform java style. Change-Id: Iaca090a5d0e66b79c2b8c4e90c335aef6a041fc7 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaca090a5d0e66b79c2b8c4e90c335aef6a041fc7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: Renamed CanAddVm to canAddVm AddVmCommand class.
by lhornyak＠redhat.com 14 Sep '12

14 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Renamed CanAddVm to canAddVm AddVmCommand class. ...................................................................... core: Renamed CanAddVm to canAddVm AddVmCommand class. This makes the method name conform to java style. Change-Id: Id7a141ce3cf1be4215d34ec663cd8635fc709674 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7a141ce3cf1be4215d34ec663cd8635fc709674 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Power Management for ilo3 is not...(#855835)
by yzaslavs＠redhat.com 14 Sep '12

14 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Power Management for ilo3 is not...(#855835) ...................................................................... core: Power Management for ilo3 is not...(#855835) core: Power Management for ilo3 is not enabled for 3.1 https://bugzilla.redhat.com/855835 Change-Id: Ibdcff697cd4d2da2bdbcd33528bb1f7a71ba8744 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdcff697cd4d2da2bdbcd33528bb1f7a71ba8744 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix for Find bug error
by yzaslavs＠redhat.com 14 Sep '12

14 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fix for Find bug error ...................................................................... engine: Fix for Find bug error Build #2499 Change-Id: Ie040cff6cb94e53ce35a35c83752ee3da1cbd313 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie040cff6cb94e53ce35a35c83752ee3da1cbd313 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Updating the usage of the new location of .pgpass
by ydary＠redhat.com 14 Sep '12

14 Sep '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Updating the usage of the new location of .pgpass ...................................................................... packaging: Updating the usage of the new location of .pgpass * Updated usage of the new .pgpass location (/etc/ovirt-engine/) * Updated some utility functions * Updated system execution functions and usage. * Updated a new location of engine-config utility * Updated fetching parameters from /etc/sysconfig/ovirt-engine instead of deprecated web-conf.js Change-Id: I366282076f0f44602d5180837d5fb06bd61c11a3 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/dbcustomfunctions.sh M data-warehouse/historydbscripts_postgres/ovirt-engine-history-db-install.sh M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 4 files changed, 30 insertions(+), 16 deletions(-) Approvals: Alex Lourie: Verified Moran Goldboim: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366282076f0f44602d5180837d5fb06bd61c11a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Import VM should not be blocked when collapse.(#766657)
by mlipchuk＠redhat.com 13 Sep '12

13 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Import VM should not be blocked when collapse.(#766657) ...................................................................... core:Import VM should not be blocked when collapse.(#766657) https://bugzilla.redhat.com/766657 Import VM to block domain should be blocked only for images which have sparse volume type and RAW volume format. Block storage domains do not support RAW sparse volumes, so those disks can not be imported to ISCSI domain. If user will choose to copy collapse the VM images, he can choose to override the disks configuration to be cow sparse or raw preallocated, which are supported by the target block storage domains, and the VM can be imported. The proposed fix, performs the validation on the configuration, in two cases: 1. When user sends copy collapse indication as true, and chooses a valid configuration for volume format and type for storage domain. 2. when user imports a VM with valid disks configuration without copy collapse. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 18 insertions(+), 5 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Firewall configuration modified to support virt and ...
by yzaslavs＠redhat.com 13 Sep '12

13 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Firewall configuration modified to support virt and gluster iptable rules. ...................................................................... engine: Firewall configuration modified to support virt and gluster iptable rules. - Added a place holder to support additional iptable rules for supported services (e.g. virt, gluster etc.,) in Generic iptables config. - virt and gluster iptables rules are added in config. Change-Id: I5a5958e870d3315316a59e1038101b2511bf8815 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 3 files changed, 102 insertions(+), 4 deletions(-) Approvals: Selvasundaram: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a5958e870d3315316a59e1038101b2511bf8815 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change import vm/template messages (#840874)
by gchaplik＠redhat.com 13 Sep '12

13 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Change import vm/template messages (#840874) ...................................................................... core: Change import vm/template messages (#840874) https://bugzilla.redhat.com/840874 The log messages for importing vm/template ere changed to include the destination data center and cluster instead of the destination storage domain. Change-Id: I16d5dd92a930b3023d4b59e75e849e778dde50fc Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16d5dd92a930b3023d4b59e75e849e778dde50fc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Peer probe gluster servers on bootstrap
by oourfali＠redhat.com 13 Sep '12

13 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Peer probe gluster servers on bootstrap ...................................................................... engine: Peer probe gluster servers on bootstrap Whenever the gluster server comes up, do peer probe if not done already. Change-Id: I13c8de35ac596d89d2a9c631c4a8ef26996ea860 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServersListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterServersListReturnForXmlRpc.java 9 files changed, 138 insertions(+), 16 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c8de35ac596d89d2a9c631c4a8ef26996ea860 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0