September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: cleanup LoginBaseCommand
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup LoginBaseCommand ...................................................................... core: cleanup LoginBaseCommand - use failCanDoAction Change-Id: I41349b4f908fd16f57cabe287b704c99e1724545 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41349b4f908fd16f57cabe287b704c99e1724545 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup AdddSANStorageDomainCommand
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup AdddSANStorageDomainCommand ...................................................................... core: cleanup AdddSANStorageDomainCommand - import java.util - use failCanDoAction Change-Id: Idbaaaddb294ff9b9ec0e8bad3c73337381c41740 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbaaaddb294ff9b9ec0e8bad3c73337381c41740 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor canDoActionMesage simplification
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor canDoActionMesage simplification ...................................................................... core: minor canDoActionMesage simplification Adds an alternative call similar to the original addCanDoActionMessage that always returns false, so callers in case of error found can simply use return failCanDoAction(VdcBllMessages.foo); Change-Id: I863e1524a145ce815aa4214488292e13df465557 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I863e1524a145ce815aa4214488292e13df465557 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: do not remove DC if more than one domain (#806952)
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: do not remove DC if more than one domain (#806952) ...................................................................... core: do not remove DC if more than one domain (#806952) https://bugzilla.redhat.com/806952 Adds validation to canDoAction method to stop the user removing DC if there are more than one storage domains in the DC. Change-Id: I9cfd5547c467aa5bce77e768775401c980ed0de7 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 11 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cfd5547c467aa5bce77e768775401c980ed0de7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup RemoveStoragePoolCommand II
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup RemoveStoragePoolCommand II ...................................................................... core: cleanup RemoveStoragePoolCommand II - added early returns instead of the oversized if statements Change-Id: Ie4d29566bbf0c2b35c7e833d1e456f14bb125666 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 31 insertions(+), 34 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4d29566bbf0c2b35c7e833d1e456f14bb125666 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup RemoveStoragePoolCommand
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup RemoveStoragePoolCommand ...................................................................... core: cleanup RemoveStoragePoolCommand - cleared up a strange reference duplication in canDoAction Change-Id: I687c84b2e62873c70691071d4b59819086aa42b8 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I687c84b2e62873c70691071d4b59819086aa42b8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, webadmin: Host pinning is ignored on Template creatio...
by tjelinek＠redhat.com 07 Sep '12

07 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine,webadmin: Host pinning is ignored on Template creation (#845570) ...................................................................... engine,webadmin: Host pinning is ignored on Template creation (#845570) https://bugzilla.redhat.com/845570 VM main tab -> select VM which has host pinning set up -> make template The template will not have the host pinning settings set. The problem was, that this has been ignored on frontend, backend and DB function level. Added it everywhere. In user portal the host pinning will not be copyed, because the frontend will ignore it (UserPortalListModel). This is correct - the host pinning has to be completely ignored in UP. Change-Id: Ie341ff1aa9c8e4bc9cbc4ab05b55664a7e0fd416 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 3 files changed, 15 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie341ff1aa9c8e4bc9cbc4ab05b55664a7e0fd416 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Update Tag Makes Redundant Call
by oliel＠redhat.com 06 Sep '12

06 Sep '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Update Tag Makes Redundant Call ...................................................................... restapi: Update Tag Makes Redundant Call When updating a tag to have its existing parent (no change), MoveTag command is activated anyway. Change-Id: I01ddc4f951b43a66cc44152df7ff67fb4f87f6b1 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagResourceTest.java 2 files changed, 20 insertions(+), 5 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01ddc4f951b43a66cc44152df7ff67fb4f87f6b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Edit pool hangs when the pool has no VMs (#852297)
by ecohen＠redhat.com 06 Sep '12

06 Sep '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Edit pool hangs when the pool has no VMs (#852297) ...................................................................... webadmin: Edit pool hangs when the pool has no VMs (#852297) https://bugzilla.redhat.com/852297 When the pool has no VMs, it makes no sense to have the pool itself. This patch adds a behavior, that when the user detaches all the VMs from the pool, show a message to the user, and when the user approves this operation, it deletes the pool itself. The pool is deleted in the RemoveVmFromPoolRunner using the RemoveVmPoolCommand when there is no more VMs left in the pool and the operation is explicitly enabled by removePoolUponDetachAllVMs parameter on the RemoveVmFromPoolParameters. Change-Id: I3b8f47e6dd5ce8149ba78c7c25455997b3bf62eb Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromPoolParameters.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolVmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/PoolModule.java 8 files changed, 133 insertions(+), 40 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8f47e6dd5ce8149ba78c7c25455997b3bf62eb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add validation for create/edit pool (#849426)
by tjelinek＠redhat.com 06 Sep '12

06 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Add validation for create/edit pool (#849426) ...................................................................... webadmin: Add validation for create/edit pool (#849426) https://bugzilla.redhat.com/849426 The VM name length is limited. When the new pool is created, the names of the VMs in the pool is limited as well. When the limit is, say 6 chars, then when you create a pool with name like 'pool' with 10 VMs in it, the names of the VMs will be pool-1, pool-2,..., pool-10. But the pool-10 is 7 chars long and the creation of such a VM fails. This patch adds a validation to the new/edit pool dialog which prevents the user from doing this. The behavior of the validation is the following: New Pool: The name field gets validated with a message like: 'The max allowed name length is X for Y VMs in pool' Edit Pool: The 'Increase number of VMs in pool by' gets validated with a message like: 'The max allowed num of VMs is X when the length of the pool name is Y' Where the X is 'num of vms already assigned' + 'num of VMs by which the pool should be increased' Change-Id: I66f765ceb0567beb006d1ef4f45db3902ef95ea6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ExistingPoolNameLengthValidation.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NewPoolNameLengthValidation.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameLengthValidation.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/ExistingPoolNameLengthValidationTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameLengthValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 9 files changed, 251 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66f765ceb0567beb006d1ef4f45db3902ef95ea6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0