September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Sysprep can not handle values with dollar
by tjelinek＠redhat.com 06 Sep '12

06 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Sysprep can not handle values with dollar ...................................................................... core: Sysprep can not handle values with dollar The values which are replaced in SysprepHandler can not contain a dollar '$' sign. Fixed by changing the SysprepHandler to use StringBuilder and to use Matcher.quoteReplacement(value) The changed functionality is tested in SysprepHandlerTest.java Change-Id: I6e93afea963c3f69cbabaf413ffebb5c7a7e0b51 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java 2 files changed, 110 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e93afea963c3f69cbabaf413ffebb5c7a7e0b51 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AsyncTaskDAO: make log final
by mlipchuk＠redhat.com 06 Sep '12

06 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: AsyncTaskDAO: make log final ...................................................................... core: AsyncTaskDAO: make log final Made the logger final to stress that it's immutable. If we can also gain a slight performance advantage here, all the better. Change-Id: If8de2c586d10f6655aaeac86861d8763b750a02d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8de2c586d10f6655aaeac86861d8763b750a02d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SPMAsyncTask: incomplete switch warning
by mlipchuk＠redhat.com 06 Sep '12

06 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: SPMAsyncTask: incomplete switch warning ...................................................................... core: SPMAsyncTask: incomplete switch warning Suppressed a warning about an incomplete switch statement to avoid Eclipse "noise" when working on this class. Change-Id: I9b586fb08998ae10877c821afe99daf591c111a2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b586fb08998ae10877c821afe99daf591c111a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SPMAsyncTask: fix typo in comment
by mlipchuk＠redhat.com 06 Sep '12

06 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: SPMAsyncTask: fix typo in comment ...................................................................... core: SPMAsyncTask: fix typo in comment Fixed a typo in an inline comment. Change-Id: I13622300451f6953af94db9b10f25dc36c732c4b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13622300451f6953af94db9b10f25dc36c732c4b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: List Possible Enum Values For Bad Input
by oliel＠redhat.com 06 Sep '12

06 Sep '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: List Possible Enum Values For Bad Input ...................................................................... restapi: List Possible Enum Values For Bad Input Change-Id: I87c0d2cd125ac1f58684ce6b0cbd84e48746d138 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/EnumValidator.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/EnumValidatorTest.java 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87c0d2cd125ac1f58684ce6b0cbd84e48746d138 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RSDL: Add Disk - Possible To Supply Name
by oliel＠redhat.com 06 Sep '12

06 Sep '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: RSDL: Add Disk - Possible To Supply Name ...................................................................... restapi: RSDL: Add Disk - Possible To Supply Name Change-Id: Ibc761c058b3929010bf04e1075cdff11614e515f Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc761c058b3929010bf04e1075cdff11614e515f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RSDL Host Install - Expose Root Password Param
by oliel＠redhat.com 06 Sep '12

06 Sep '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: RSDL Host Install - Expose Root Password Param ...................................................................... restapi: RSDL Host Install - Expose Root Password Param Change-Id: I51949228ee546c935477d6e05f44287d05b3212d Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51949228ee546c935477d6e05f44287d05b3212d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: filtered header not passed on VM start (#854296)
by oourfali＠redhat.com 05 Sep '12

05 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: rest: filtered header not passed on VM start (#854296) ...................................................................... rest: filtered header not passed on VM start (#854296) https://bugzilla.redhat.com/854296 When using the SDK, using the filtered API, starting a VM fails, as the filtered header isn't passed. This patch fixes this issue, by adding it to the rsdl_metadata_v-3.1.yaml file. Change-Id: Ib34e7ac018641b6844e66e12ade11532fcfa852f Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib34e7ac018641b6844e66e12ade11532fcfa852f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix stateless VM quota calculation(#854491)
by dfediuck＠redhat.com 05 Sep '12

05 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix stateless VM quota calculation(#854491) ...................................................................... core: Fix stateless VM quota calculation(#854491) https://bugzilla.redhat.com/854491 The validateAndSetQuota() was called twice. The second time was on the internal run (after the quota was already counted). Change-Id: Ie60437296cdaf068f6afe402e4d5366c70ee5058 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie60437296cdaf068f6afe402e4d5366c70ee5058 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Prevent move to empty quota (#845070)
by dfediuck＠redhat.com 05 Sep '12

05 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Prevent move to empty quota (#845070) ...................................................................... engine: Prevent move to empty quota (#845070) https://bugzilla.redhat.com/845070 When a user was moving a disk to a domain with no defined quota (when quota is enforced) he got an uninformative error. The ability to move to a domain with no quota was blocked using the validate mechanism. When quota is enforced the user must choose a domain with a defined quota. The massage was fixed to inform the user that the selected domain has no assigned quota (in case a quota is available but not relevant). Change-Id: Iab0baf6f583f06197286a976211bada4a0654cb2 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/SelectedQuotaValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 56 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab0baf6f583f06197286a976211bada4a0654cb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0