September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Removed un needed run of code in Suppres mode
by yzaslavs＠redhat.com 27 Sep '12

27 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Removed un needed run of code in Suppres mode ...................................................................... core: Removed un needed run of code in Suppres mode The following patch will remove un needed run of code in Suppress mode. The following code is already run with out scope of any transaction, no need explicity to remove it. Motivation: less code - better redability, less look ups - better performance, less anonymous class - better memory. Change-Id: I87050e78abf0e468ebae5348f6e01c9ce46c7581 Bug-Url: NA Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 13 insertions(+), 28 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87050e78abf0e468ebae5348f6e01c9ce46c7581 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed un needed run of code in Suppres mode
by yzaslavs＠redhat.com 27 Sep '12

27 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Removed un needed run of code in Suppres mode ...................................................................... core: Removed un needed run of code in Suppres mode The following patch will remove un needed run of code in Suppress mode. The following code is already run with out scope of any transaction, no need explicity to remove it. Motivation: less code - better redability, less look ups - better performance, less anonymous class - better memory. Change-Id: Ia2e2ec7a0f8ba5b540582343980714d678575328 Bug-Url: NA Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2e2ec7a0f8ba5b540582343980714d678575328 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed un needed run of code in Suppres mode
by yzaslavs＠redhat.com 27 Sep '12

27 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Removed un needed run of code in Suppres mode ...................................................................... core: Removed un needed run of code in Suppres mode The following patch will remove un needed run of code in Suppress mode. The following code is already run with out scope of any transaction, no need explicity to remove it. Motivation: less code - better redability, less look ups - better performance, less anonymous class - better memory. Change-Id: Ib79f8f8d5321de125efee17e5ae4083245885f32 Bug-Url: NA Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 56 insertions(+), 68 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib79f8f8d5321de125efee17e5ae4083245885f32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reduced un needed look up for TransactionManager
by yzaslavs＠redhat.com 27 Sep '12

27 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Reduced un needed look up for TransactionManager ...................................................................... core: Reduced un needed look up for TransactionManager The following patch will remove un needed look up for TransactionManager in case of running a piece of code at scope Suppress or Required. Change-Id: I10cc4f7e46560ff97df199582db4f3687badc030 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionSupport.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10cc4f7e46560ff97df199582db4f3687badc030 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Call getNetworkDao Instead of DAO (#858654)
by msalem＠redhat.com 27 Sep '12

27 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: Call getNetworkDao Instead of DAO (#858654) ...................................................................... core: Call getNetworkDao Instead of DAO (#858654) Bug-Url: https://bugzilla.redhat.com/858654 Change-Id: I38ba13cc1cc56f72fe5e139d0a82f55053117b03 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38ba13cc1cc56f72fe5e139d0a82f55053117b03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Allow Non-Required Networks Not On Host (#858654)
by msalem＠redhat.com 27 Sep '12

27 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: Allow Non-Required Networks Not On Host (#858654) ...................................................................... core: Allow Non-Required Networks Not On Host (#858654) https://bugzilla.redhat.com/858654 This patch adds the ConfigValue OnlyRequiredNetworksMandatoryForVdsSelection. When set to true, it allows selecting a Vds for running a VM, even if a Non-Required Network that is on an active vNic of the VM, is not attached to any Host Nic. When set to false, does not change behaviour. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I4909a658bf729d839c9f01268f1295e43391a2c3 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 3 files changed, 42 insertions(+), 11 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4909a658bf729d839c9f01268f1295e43391a2c3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: GetStoragePoolInfoVDSCommand cleanup
by lhornyak＠redhat.com 27 Sep '12

27 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: GetStoragePoolInfoVDSCommand cleanup ...................................................................... core: GetStoragePoolInfoVDSCommand cleanup - import java.util instead of fqn Change-Id: I0c0855ad303ca2d5e60ff0f9bbd91af4f3939a38 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetStoragePoolInfoVDSCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c0855ad303ca2d5e60ff0f9bbd91af4f3939a38 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: remove redundant nullcheck
by lhornyak＠redhat.com 27 Sep '12

27 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove redundant nullcheck ...................................................................... core: remove redundant nullcheck storageDomainFromList.getstatus() != null does not have to be performed, since if it is StorageDomainStatus.Active, then it can not be null at the same time. Change-Id: Ib5dcc5684b99ad5796d185aeac1e64a7c904df35 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5dcc5684b99ad5796d185aeac1e64a7c904df35 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: minor AddStorageDomainCommon cleanup
by lhornyak＠redhat.com 27 Sep '12

27 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor AddStorageDomainCommon cleanup ...................................................................... core: minor AddStorageDomainCommon cleanup removed the unnecesary temporary variable Change-Id: If6dff088dae4ab5c472c68e65c3e1ffb5d35a451 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommon.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6dff088dae4ab5c472c68e65c3e1ffb5d35a451 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: Fix stateless VM Quota double-count
by dfediuck＠redhat.com 27 Sep '12

27 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix stateless VM Quota double-count ...................................................................... core: Fix stateless VM Quota double-count The cluster quota was counted twice when running a VM in stateless mode (only when the stateless is triggered by the 'stateless' flag in the VM edit pop-up and not when its triggered by the 'stateless' flag in the Run once pop-up). Change-Id: If62d10a4e7ff0477a7cf324a28f09e4c493e5689 Bug-Url: https://bugzilla.redhat.com/854491 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/8223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If62d10a4e7ff0477a7cf324a28f09e4c493e5689 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0