September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: replace Date with long for time variable
by rgolan＠redhat.com 25 Sep '12

25 Sep '12

Roy Golan has submitted this change and it was merged. Change subject: core: replace Date with long for time variable ...................................................................... core: replace Date with long for time variable Change-Id: I50473b6fddaf06f2cedffb2a7c45a8507c1a7014 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 5 insertions(+), 8 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50473b6fddaf06f2cedffb2a7c45a8507c1a7014 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsInstallerSSHTest: assume POSIX
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: VdsInstallerSSHTest: assume POSIX ...................................................................... core: VdsInstallerSSHTest: assume POSIX VdsInstallerSSHTest implicitly assumes POSIX compliant SSH handling of the local OS. This patch makes that assumption explicit (using org.junit.Assume) in order to prevent the test from failing on OSs it can't run on. Change-Id: I9fd29845da489836d4b8bc19449be54f30fa5e7a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/8188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd29845da489836d4b8bc19449be54f30fa5e7a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Handling add first/removing last domain (#858769)
by yzaslavs＠redhat.com 25 Sep '12

25 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Handling add first/removing last domain (#858769) ...................................................................... tools: Handling add first/removing last domain (#858769) https://bugzilla.redhat.com/858769 This patch fixes issues with adding first/removing last domain and changing the value of option AdUserPassword Change-Id: I4fcfc9cf68131e80a481d8d1962f3afc1c30ae7f Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java 5 files changed, 29 insertions(+), 15 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fcfc9cf68131e80a481d8d1962f3afc1c30ae7f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: import: storage drop down is empty (#856976)
by gchaplik＠redhat.com 25 Sep '12

25 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: import: storage drop down is empty (#856976) ...................................................................... webadmin: import: storage drop down is empty (#856976) https://bugzilla.redhat.com/856976 In case 2 different vms (or more) are dependent on a template, only one vm disks will have a storage dropdown filled (that happened because each vm override the other vm disks). Change-Id: Ib29a104cd7069586798ec87b1e06d74e51c3e6be Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib29a104cd7069586798ec87b1e06d74e51c3e6be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: import: validate quota in enforce mode (#855635)
by gchaplik＠redhat.com 25 Sep '12

25 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: import: validate quota in enforce mode (#855635) ...................................................................... webadmin: import: validate quota in enforce mode (#855635) https://bugzilla.redhat.com/855635 Import VM/Template dialogs: Perform a client side validation on quota availability, when quota in enforce mode. Change-Id: Ic2fc674c18e805cdd2b54a32b85f037e8d4fca5f Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 49 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2fc674c18e805cdd2b54a32b85f037e8d4fca5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Stop->Power Off (#857327)
by tjelinek＠redhat.com 25 Sep '12

25 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Stop->Power Off (#857327) ...................................................................... userportal,webadmin: Stop->Power Off (#857327) https://bugzilla.redhat.com/857327 Changed the label of stopping of the VM from Stop to Power Off. The constants moved to CommonApplicationConstants Change-Id: I589689d139dfd6cfb7adae366f4254f448fd33fd Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 5 files changed, 10 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I589689d139dfd6cfb7adae366f4254f448fd33fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: SearchResultsLimit race condition (#853904)
by oourfali＠redhat.com 25 Sep '12

25 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: userportal: SearchResultsLimit race condition (#853904) ...................................................................... userportal: SearchResultsLimit race condition (#853904) https://bugzilla.redhat.com/853904 SearchableListModel - a race condition in SearchResultsLimit configuration value fetching prevented auto-refresh mechanism. * SearchableListModel -> Search() If 'SearchResultsLimit' isn't fetched yet, 'searchRequested' flag is marked on RequestSearch(). * RequestSearch() Clear model's items and raise changed events (affects only for first search). * 'GetSearchResultsLimit' -> OnSuccess() Search command should be invoked iff 'searchRequested' and model's timer isn't running (since Search starts the timer). Checking 'getIsTimerDisabled' is not sufficient since the timer is being started only *after* SearchResultsLimit value is fetched. * MainTabBasicDetailsView Add clear() method for cleaning details pane. Change-Id: Ibac4f4126feadbaec90ecc4981a9a23079ee715a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 5 files changed, 41 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibac4f4126feadbaec90ecc4981a9a23079ee715a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: SanStorageTargetToLunList FindBugs
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SanStorageTargetToLunList FindBugs ...................................................................... webadmin: SanStorageTargetToLunList FindBugs Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE. The items variable is clearly not null here, since isEmpty() is called on it beforehand, so the conditional statement can be safely removed. Change-Id: I645d6ce09a94d3a0d1d98e7514720c439e7c3492 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I645d6ce09a94d3a0d1d98e7514720c439e7c3492 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: SanStorageLunToTargetList FindBugs
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SanStorageLunToTargetList FindBugs ...................................................................... webadmin: SanStorageLunToTargetList FindBugs Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE. The items variable is clearly not null here, since isEmpty() is called on it beforehand, so the conditional statement can be safely removed. Change-Id: Icc4623dfb81aa3354d761536f35f351bd58964a0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc4623dfb81aa3354d761536f35f351bd58964a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "userportal: SearchResultsLimit race condition (#8539...
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: Revert "userportal: SearchResultsLimit race condition (#853904)" ...................................................................... Revert "userportal: SearchResultsLimit race condition (#853904)" This reverts commit 018d88cd3dfd521fbcbb6fc1a6e3acc0c8a39a87 Causes a NPE in TagListModel during WebAdmin startup. A fixed patch will be suggested. --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java 3 files changed, 4 insertions(+), 37 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee499669af30b4b620b9fa9bd86b775b4f9e1eee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0