January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: prevent db updates due to change in lastStartTime
by ofrenkel＠redhat.com 06 Jan '13

06 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: prevent db updates due to change in lastStartTime ...................................................................... core: prevent db updates due to change in lastStartTime This patch prevents unneccesary updates of VMs by VdsUpdateRunTimeInfo monitoring in case the 'lastStartTime' attribute is the only attribute of the VM that is changed (received with a different value from vdsm). The 'lastStartTime' attribute is always received from vdsm with null value, which is different from its value in the engine, thus VdsUpdateRunTimeInfo thinks that the VM is changed and update it in the DB (and that happens in every monitoring iteration). The solution is to remove 'lastStartTime' attribute from the list of attributes which are, when received from vdsm, compared to their values in the engine in order to decide whether the VM is changed. Change-Id: I8193defc1833e33bb3f8809d8416012c6dc27aea Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8193defc1833e33bb3f8809d8416012c6dc27aea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: changed upgrade file syntex to work with pg 8.4
by ydary＠redhat.com 06 Jan '13

06 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: changed upgrade file syntex to work with pg 8.4 ...................................................................... history: changed upgrade file syntex to work with pg 8.4 Change-Id: Iac6f4188c9f6d0d0a59bc371bee35f8bb6f401af Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/upgrade/03_02_0030_drop_auto_suspend_column.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac6f4188c9f6d0d0a59bc371bee35f8bb6f401af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix db restore usage comment
by emesika＠redhat.com 05 Jan '13

05 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fix db restore usage comment ...................................................................... core: fix db restore usage comment If the restore.sh is invoked with a DB name that is different than the name appearing in the backup file, restore will fail. this patch only added this information to the script usage comments. Change-Id: Ibe11f2684c72686d183323c96f73a86d6cf1f8ea Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/restore.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe11f2684c72686d183323c96f73a86d6cf1f8ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: database restore fixes
by emesika＠redhat.com 05 Jan '13

05 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: database restore fixes ...................................................................... core: database restore fixes This patch enables restoring the database from a old backup and will perform all necessary data and schema updates using the upgrade.sh script that is executed after the restore is completed. The upgrade step also forces truncation of the async_tasks and business_entity_snapshot tables since those tables contain data that is relevant for asynchronous tasks and might lead to exceptions if restored. You can omit the execution of the upgrade step with the -o flag. The recommended way for restoring your database is. 1) backup current with backup.sh 2) run restore.sh and give other database instance name as the target 3) edit JBOSS standalone.xml to run the new restored database instance 4) verify that all tasks in the application are completed 5) restart JBOSS Change-Id: Ib2fc6b61e8e679db40acf2a074fc4737873d5707 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/restore.sh 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2fc6b61e8e679db40acf2a074fc4737873d5707 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update Common.gwt.xml to reflect correct file name.
by lhornyak＠redhat.com 04 Jan '13

04 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Update Common.gwt.xml to reflect correct file name. ...................................................................... core: Update Common.gwt.xml to reflect correct file name. This change was left out of patch http://gerrit.ovirt.org/#/c/10052/ Change-Id: If8bac766e9821374da67c1a0991ed666b409fd71 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Sharad Mishra: Verified -- To view, visit http://gerrit.ovirt.org/10657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8bac766e9821374da67c1a0991ed666b409fd71 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unused class.
by lhornyak＠redhat.com 04 Jan '13

04 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Removed unused class. ...................................................................... core: Removed unused class. license_usage.java was not being used. Change-Id: I1a6d595ad52b184c4e088ef6b61495128c4f0f74 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/create_tables.sql A backend/manager/dbscripts/upgrade/03_02_0280_drop_licenses.sql D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/license_usage.java 3 files changed, 3 insertions(+), 85 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a6d595ad52b184c4e088ef6b61495128c4f0f74 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Update network referencing only attached clusters
by mkolesni＠redhat.com 04 Jan '13

04 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Update network referencing only attached clusters ...................................................................... engine: Update network referencing only attached clusters Changed the query to be of the cluster attachments of the network, since what we're interested in is only the clusters that are attached to the network, both for checking VMs and for changing the network status. Change-Id: I54a7ea672c1686f1a11f20ad06e076c84a7b1190 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 11 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a7ea672c1686f1a11f20ad06e076c84a7b1190 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use same query for update network
by mkolesni＠redhat.com 04 Jan '13

04 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Use same query for update network ...................................................................... engine: Use same query for update network Update network should use the same query as add since there is no need to query for all the networks in the system just the ones in the DC of the network. Change-Id: I2580d61101ff36fd1a623c8962be7eea4ebc3bdc Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2580d61101ff36fd1a623c8962be7eea4ebc3bdc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Validate DC exists on add network
by mkolesni＠redhat.com 04 Jan '13

04 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Validate DC exists on add network ...................................................................... engine: Validate DC exists on add network Since the DC is mandatory it makes sense to validate that it exists instead of possibly failing the command on FK violation. Change-Id: I3ea1f4a58011814803740bc5c93fd87d00df8d41 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 3 files changed, 10 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ea1f4a58011814803740bc5c93fd87d00df8d41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove "floating network" support in add
by mkolesni＠redhat.com 04 Jan '13

04 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Remove "floating network" support in add ...................................................................... engine: Remove "floating network" support in add Removed support of so called "floating network" from AddNetworkCommand since this state is not currently supported in the system, and either way clients always send a DC ID in the parameters. Change-Id: Icb323fd274f0991bc0d7d4d831f65925ff078978 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb323fd274f0991bc0d7d4d831f65925ff078978 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0