January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Change data center ID to not null in Network
by mkolesni＠redhat.com 04 Jan '13

04 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change data center ID to not null in Network ...................................................................... core: Change data center ID to not null in Network Data center ID cannot be sent null since this state is not supported. Currently the clients don't send it null anyway so no change is necessary there. Change-Id: I4ed489cb4b0730bb04e7902a8fd73db094b8e6cd Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed489cb4b0730bb04e7902a8fd73db094b8e6cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix NPE in update network
by mkolesni＠redhat.com 04 Jan '13

04 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Fix NPE in update network ...................................................................... engine: Fix NPE in update network Clusters field setting was mistakenly removed, putting it back in a form that is not as ugly as it was before, but now update network won't cause NPE :) Change-Id: I9c56912740d8e790bb741cd2a70a7197d5f41be8 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c56912740d8e790bb741cd2a70a7197d5f41be8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added requirement to openjdk 1.7.0.9-2.3.3.2
by juan.hernandez＠redhat.com 03 Jan '13

03 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Added requirement to openjdk 1.7.0.9-2.3.3.2 ...................................................................... packaging: Added requirement to openjdk 1.7.0.9-2.3.3.2 It is required to upgrade to the described jdk in order to have the functionality of the below bug (i.e - usage of dns_lookup_realm and dns_lookup_kdc set to true instead of hardcoded DC info) Bug-Url: https://bugzilla.redhat.com/868852 Change-Id: Icaadd9eb23016b4866e5cfa49f119378f13fdf1c Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaadd9eb23016b4866e5cfa49f119378f13fdf1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing API rsdl
by mpastern＠redhat.com 03 Jan '13

03 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: core: fixing API rsdl ...................................................................... core: fixing API rsdl Fixing error in the Events definitions in RSDL yaml file. Change-Id: Iba4a4c53896bd86e0891d807946565e967c31e91 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba4a4c53896bd86e0891d807946565e967c31e91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Update volumes by id instead of name
by sanjal＠redhat.com 03 Jan '13

03 Jan '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Update volumes by id instead of name ...................................................................... gluster: Update volumes by id instead of name Modifying the logic to compare fetched volumes with existing volumes to use volume ids instead of name. This handles the rare scenario where someone deletes a volume and creates a new one with exactly same name from the gluster CLI, in quick succession. Change-Id: If9053da4294b7c5aa762645737a2effccd5a9c4d Bug-Url: https://bugzilla.redhat.com/888144 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java 3 files changed, 36 insertions(+), 31 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9053da4294b7c5aa762645737a2effccd5a9c4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add validation to cpu pinning
by dfediuck＠redhat.com 03 Jan '13

03 Jan '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Add validation to cpu pinning ...................................................................... engine: Add validation to cpu pinning Validation the following conditions: - syntax is correct - all given vcpus exist (e.i vcpu number < max cpu# on vm) - only one definition for each vcpu - if defined, a vcpu is pinned to at least one pcpu (e.g 0#1-2,^1,^2 isn't valid) - in cluster 3.2 verify all pcpu given exists (e.i pcpu number < max thread# on host) *pcpu is not verified in cluster < 3.2 as we cannot know the nuber for sure. Change-Id: I690b60fcde6bf337058246ef9b1ee24fa3b7220a Bug-Url: https://bugzilla.redhat.com/871726 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 251 insertions(+), 37 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I690b60fcde6bf337058246ef9b1ee24fa3b7220a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Andrew Cathrow <andrew(a)cathrow.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-upgrade - check for free space before upgr...
by juan.hernandez＠redhat.com 03 Jan '13

03 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-upgrade - check for free space before upgrade ...................................................................... packaging: engine-upgrade - check for free space before upgrade Add pre-run check to engine-upgrade, so it will verify that enough free space is available for the upcoming database backup + rpm installation. Change-Id: I90eae48aea70187dc88c79044a353089f69350a0 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/output_messages.py 4 files changed, 122 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90eae48aea70187dc88c79044a353089f69350a0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup
by ofrenkel＠redhat.com 03 Jan '13

03 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: OvfReader cleanup ...................................................................... core: OvfReader cleanup - Rename GigabyteToBytes method to convertGigabyteToBytes - Rename the methods in IOvfBuilder so that they will start with lower case letter instead of upper case letter - Remove unnecessary parentheses Change-Id: I30cb764dd0a303138b703f1cce1e943fb1e59fc8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 6 files changed, 31 insertions(+), 31 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30cb764dd0a303138b703f1cce1e943fb1e59fc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: clear log message on failure during disk removal.
by derez＠redhat.com 03 Jan '13

03 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: clear log message on failure during disk removal. ...................................................................... core: clear log message on failure during disk removal. 1. changed message. 2. reduced audit log severity. Change-Id: I591c9f4cbb0aeb5fd6c646211e815bdd88fcadd8 Bug-Url: https://bugzilla.redhat.com/867849 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I591c9f4cbb0aeb5fd6c646211e815bdd88fcadd8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change Anonymous class to For Loop
by msalem＠redhat.com 03 Jan '13

03 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Change Anonymous class to For Loop ...................................................................... engine: Change Anonymous class to For Loop This patch changes the use of LinqUtils with a simple for loop, for simplicity and readability. Change-Id: Ifc68ade0e5f7e45d357bcbd394b2beec7805bd88 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 2 files changed, 30 insertions(+), 26 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc68ade0e5f7e45d357bcbd394b2beec7805bd88 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0