October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ReconstructMasterParameters - return removed initializ...
by amureini＠redhat.com 27 Oct '13

27 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ReconstructMasterParameters - return removed initialization ...................................................................... core: ReconstructMasterParameters - return removed initialization In change I3bb06f63b6fae8d4bc0c2b931cbfeb6b71a023a9, the initialization of the member privateNewMasterDomainId has been moved to the ctor. The issue is that the initialization was placed only in some of the ctors leading the unexpected behaviour when reconstruct is executed. Change-Id: I752c8065ee15faaeb6ffd41909d349297b8a3a58 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I752c8065ee15faaeb6ffd41909d349297b8a3a58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: expose ACTION_TYPE_FAILED_DISK_IS_NOT_VM_DISK code...
by mlipchuk＠redhat.com 27 Oct '13

27 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: expose ACTION_TYPE_FAILED_DISK_IS_NOT_VM_DISK code in UI ...................................................................... webadmin: expose ACTION_TYPE_FAILED_DISK_IS_NOT_VM_DISK code in UI Change-Id: I9dd47380594b27db7347e28fce27abcf11cf63ac Bug-Url: https://bugzilla.redhat.com/1021420 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Sergey Gotliv: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd47380594b27db7347e28fce27abcf11cf63ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Don't log unsynchronized unmanaged networks
by mkolesni＠redhat.com 27 Oct '13

27 Oct '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Don't log unsynchronized unmanaged networks ...................................................................... engine: Don't log unsynchronized unmanaged networks If the network is not synchronized, it should be logged only if it's managed. Otherwise, it's of no interest to us. Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20 Bug-Url: https://bugzilla.redhat.com/906393 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove advanced parameters from vNIC dialog
by lvernia＠redhat.com 27 Oct '13

27 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove advanced parameters from vNIC dialog ...................................................................... webadmin: Remove advanced parameters from vNIC dialog Since the port mirroring checkbox moved to the vNIC profile dialog, the advanced parameters section in the vNIC dialog only includes plug/unplug at the moment, rendering it quite unnecessary. Also rearranged some of the widget declarations so hitting tab will move between them in a more logical order. Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa Bug-Url: https://bugzilla.redhat.com/1011999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml 2 files changed, 40 insertions(+), 54 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added scrolling to vNIC section in add VM
by lvernia＠redhat.com 27 Oct '13

27 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC section in add VM ...................................................................... webadmin: Added scrolling to vNIC section in add VM Added a vertical scroll bar to the vNIC section in the add VM dialog. Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Bug-Url: https://bugzilla.redhat.com/1012798 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added scrolling to vNIC profiles
by lvernia＠redhat.com 27 Oct '13

27 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC profiles ...................................................................... webadmin: Added scrolling to vNIC profiles In add/edit network, added a vertical scroll bar to the vNIC profile section. Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 2 files changed, 7 insertions(+), 8 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: image cell - show tooltip only when needed
by derez＠redhat.com 27 Oct '13

27 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: image cell - show tooltip only when needed ...................................................................... webadmin: image cell - show tooltip only when needed StyledImageResourceCell -> title panel should be visible only when a title is available (i.e. != empty string). Example screenshot: http://i.imgur.com/oem3uNH.png Change-Id: If3ea9edf883dfffe59996ef31efe96a6d60f6ccf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3ea9edf883dfffe59996ef31efe96a6d60f6ccf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix the trimElements method of the OsRepo
by rgolan＠redhat.com 27 Oct '13

27 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: Fix the trimElements method of the OsRepo ...................................................................... core: Fix the trimElements method of the OsRepo Modifies the trimElements method of the OsRepositoryImpl class to filter out empty elements and correctly handle properties with empty lists as values. Change-Id: I16f6e387c231c78b43c76055748735ae456ab0fe Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16f6e387c231c78b43c76055748735ae456ab0fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: support nested plugins
by Alon Bar-Lev 26 Oct '13

26 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support nested plugins ...................................................................... core: support nested plugins Change-Id: I99c7eb33a258372e8fb8068a5d8271a999138c1d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/context.py 2 files changed, 14 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c7eb33a258372e8fb8068a5d8271a999138c1d Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: cleanup plugin load
by Alon Bar-Lev 26 Oct '13

26 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: cleanup plugin load ...................................................................... core: cleanup plugin load Change-Id: I8d0c7ae371f853b581a33a68718358e62c6c763c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 30 insertions(+), 35 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d0c7ae371f853b581a33a68718358e62c6c763c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0