October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: monitor: recognize additional vm states
by gpadgett＠redhat.com 25 Oct '13

25 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: monitor: recognize additional vm states ...................................................................... monitor: recognize additional vm states The 'waitforlaunch' state was seen on a vm, causing incorrect reporting that the vm was down. Upon further investigation, there were several unhandled vm states. These will be considered 'vm-up bad-health-status' by the engine health monitor, giving the host/vm a window of time to pass through the transient state before any action is taken by the agent. Change-Id: I1b73870306a559505d3441e9a2e57dfb0d191bae Bug-Url: https://bugzilla.redhat.com/1019468 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b73870306a559505d3441e9a2e57dfb0d191bae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: replace TBD string
by dougsland＠redhat.com 25 Oct '13

25 Oct '13

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: replace TBD string ...................................................................... engine_page: replace TBD string We must replace the TBD (To be defined) title when showing to users the Engine cert fingerprint. Change-Id: Idedcc24be983711f5b4a9372296fb4533badb480 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1022711 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved Alon Bar-Lev: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idedcc24be983711f5b4a9372296fb4533badb480 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: check for stale VM before creation
by sbonazzo＠redhat.com 25 Oct '13

25 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: check for stale VM before creation ...................................................................... packaging: setup: check for stale VM before creation Added a check for stale Hosted Engine VM before creating it. In normal execution flow, this should never happen. However, it is possible that the user starts again the VM manually after having installed the OS and forget to poweroff (destroy) the VM. Now the user will be warned to properly poweroff the VM started manually in order to continue the setup process. The poweroff is not issued automatically because the VM can be in a stale state after a failure and the user must be aware that the VM is still around in order to debug the issue. Bug-Url: https://bugzilla.redhat.com/1010980 Change-Id: I8d5dfc17e10e677959e903f03515a124d5e97611 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5dfc17e10e677959e903f03515a124d5e97611 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Clarifying CDA message of adding vnic profile
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Clarifying CDA message of adding vnic profile ...................................................................... engine: Clarifying CDA message of adding vnic profile The patch clarifies the can-do-action of adding a vnic profile to a non-vm network. Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc Bug-Url: https://bugzilla.redhat.com/1012009 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Prevent vnic live update for if network not on host
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Prevent vnic live update for if network not on host ...................................................................... engine: Prevent vnic live update for if network not on host The patch blocks updating a plugged vnic on a running vm to a network which doesn't exist on the host. It also fixes a bug of setting an empty vnic profile while updating a plugged vnic. Change-Id: I0c9d8f2202efa2e45a2144bbdb70d374bdb9ff6f Bug-Url: https://bugzilla.redhat.com/1017602 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 23 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9d8f2202efa2e45a2144bbdb70d374bdb9ff6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: no documentation message
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: no documentation message ...................................................................... engine: no documentation message - Fixed issue where the locale in the links would have an underscore, while the documentation would contain a dash. This caused the message to popup even though the documentation was installed. Fixed it so it no longer matters if the link has an underscore or dash in it, both will correctly determine if the language is available. Change-Id: Ic70eb10eb0264857568028f8307df4408dd36922 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011430 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic70eb10eb0264857568028f8307df4408dd36922 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Defer item selection 'til after items are set
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Defer item selection 'til after items are set ...................................................................... webadmin: Defer item selection 'til after items are set So far the selection was performed before the list of items was refreshed in the view, and (presumably because of GWT implementation) this caused the list of items to not be refreshed immediately. Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3 Bug-Url: https://bugzilla.redhat.com/999882 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: block editing migraion fields while VM !Down
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: block editing migraion fields while VM !Down ...................................................................... engine: block editing migraion fields while VM !Down While the VM isn't down block editing migration and pinToHost fields in engine, and add a tooltip in UI to explain that. Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a Bug-Url: https://bugzilla.redhat.com/735260 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 4 files changed, 12 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: select a host even if scheduling scoring failed
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: select a host even if scheduling scoring failed ...................................................................... engine: select a host even if scheduling scoring failed If no internal scoring function is selected it can result In no host selected at all, even if some hosts did pass the filtering stage. Select the first host if none has returned from the scoring functions. Change-Id: I96082ccdfd8759619e98bc437fdb468b3b583992 Bug-Url: https://bugzilla.redhat.com/1001986 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96082ccdfd8759619e98bc437fdb468b3b583992 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: external scheduler dont pass empty guid
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: external scheduler dont pass empty guid ...................................................................... engine: external scheduler dont pass empty guid When using external balance an empty string may return resulting in a 0000-00... guid, causing unnecessary logging of missing guid Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e Bug-Url: https://bugzilla.redhat.com/1017718 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0