November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: reports: moved favicon to theme
by ydary＠redhat.com 26 Nov '13

26 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: moved favicon to theme ...................................................................... reports: moved favicon to theme Change-Id: I9a498d86b7f3d75274f52dfabfe3904455408923 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/.folder.xml R reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/favicon.ico.data A reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/favicon.ico.xml 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a498d86b7f3d75274f52dfabfe3904455408923 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in mom[master]: Create new evaluator for each evaluation run
by alitke＠redhat.com 26 Nov '13

26 Nov '13

Adam Litke has submitted this change and it was merged. Change subject: Create new evaluator for each evaluation run ...................................................................... Create new evaluator for each evaluation run MoM used one evaluator for all the policy runs. That caused weird side effects because the stack already contained old values from previous runs. Policies could not be evaluated properly because we changed defvar semantic from set to setdefault in one of previous patches. Change-Id: I3d5343e94d8ecddca0e0c9dd7fc893d94e751378 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025845 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/21704 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Policy/Policy.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/21704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d5343e94d8ecddca0e0c9dd7fc893d94e751378 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in mom[master]: Reorder limit checks in grow quest
by alitke＠redhat.com 26 Nov '13

26 Nov '13

Adam Litke has submitted this change and it was merged. Change subject: Reorder limit checks in grow quest ...................................................................... Reorder limit checks in grow quest balloon_min is a computed value that can (and will) go over balloon_max. When the controller tries to use it VDSM reports exception. Reorder the checks so the balloon_max constant check is the latest one to limit the value. Change-Id: I3e542b5d1c165e32b8555e5510660ced136c6ab9 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/21726 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M doc/balloon.rules 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/21726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e542b5d1c165e32b8555e5510660ced136c6ab9 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3.1]: packaging: setup: update postgres service restart functionality
by ydary＠redhat.com 26 Nov '13

26 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update postgres service restart functionality ...................................................................... packaging: setup: update postgres service restart functionality Change-Id: I3aab88dfd754798515419453ddae77939c5915d3 Related-To: https://bugzilla.redhat.com/1029969 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 15 insertions(+), 11 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aab88dfd754798515419453ddae77939c5915d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: update postgres service restart functionality
by ydary＠redhat.com 26 Nov '13

26 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update postgres service restart functionality ...................................................................... packaging: setup: update postgres service restart functionality Change-Id: I3aab88dfd754798515419453ddae77939c5915d3 Related-To: https://bugzilla.redhat.com/1029969 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 15 insertions(+), 11 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aab88dfd754798515419453ddae77939c5915d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Optimize iteration over map (Findbugs)
by lvernia＠redhat.com 26 Nov '13

26 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Optimize iteration over map (Findbugs) ...................................................................... webadmin: Optimize iteration over map (Findbugs) Replaced the iteration over the map keys with an iteration over its entries, as a response to Findbugs warning WMI_WRONG_MAP_ITERATOR. Change-Id: I767b72fecfb8ec76d9c259f1b059c243ecf421fb Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I767b72fecfb8ec76d9c259f1b059c243ecf421fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: prevent unboxing of integer in AsyncDataProvider
by derez＠redhat.com 26 Nov '13

26 Nov '13

Daniel Erez has submitted this change and it was merged. Change subject: frontend: prevent unboxing of integer in AsyncDataProvider ...................................................................... frontend: prevent unboxing of integer in AsyncDataProvider It solves 2 findbugs warnings of type BX_UNBOXING_IMMEDIATELY_REBOXED Change-Id: I8c673f3afddb48b9982d3448f3603002e7a8cf6f Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c673f3afddb48b9982d3448f3603002e7a8cf6f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Hide commands when specific provider is chosen
by lvernia＠redhat.com 26 Nov '13

26 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Hide commands when specific provider is chosen ...................................................................... webadmin: Hide commands when specific provider is chosen When a specific provider is chosen in the system tree, the add/remove commands will now be hidden. Change-Id: I27246a01e72fb70735888e38fcf5db3442cfba0d Bug-Url: https://bugzilla.redhat.com/987999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27246a01e72fb70735888e38fcf5db3442cfba0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: remind user to install agent inside VM
by sbonazzo＠redhat.com 26 Nov '13

26 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: remind user to install agent inside VM ...................................................................... packaging: setup: remind user to install agent inside VM Change-Id: Idf5d860407e74b99127db1814c3e2e9ee9376091 Bug-Url: https://bugzilla.redhat.com/1034646 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/health.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf5d860407e74b99127db1814c3e2e9ee9376091 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: remind user to install agent inside VM
by sbonazzo＠redhat.com 26 Nov '13

26 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: remind user to install agent inside VM ...................................................................... packaging: setup: remind user to install agent inside VM Change-Id: Idf5d860407e74b99127db1814c3e2e9ee9376091 Bug-Url: https://bugzilla.redhat.com/1034646 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/health.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Pablo Iranzo Gómez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf5d860407e74b99127db1814c3e2e9ee9376091 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0