November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Don't track default profile name if overridden
by iheim＠redhat.com 06 Nov '13

06 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't track default profile name if overridden ...................................................................... webadmin: Don't track default profile name if overridden If user inputs a name for the default profile name, stop changing it according to the network's name. Change-Id: I468c3dcd4deb05aebaaaddf0035fac0e0d9509b7 Bug-Url: https://bugzilla.redhat.com/1025170 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I468c3dcd4deb05aebaaaddf0035fac0e0d9509b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: clear connection on import SD rollback
by iheim＠redhat.com 06 Nov '13

06 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: clear connection on import SD rollback ...................................................................... webadmin: clear connection on import SD rollback In order to avoid stale connections data in the DB, clear storage connection when an export/iso domain doesn't exist on the specified path (GetExistingStorageDomainList returns an empty list) Change-Id: Ia2e70353494ce97a6c2ae0ad74868c1f502a309c Bug-Url: https://bugzilla.redhat.com/1020812 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 13 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2e70353494ce97a6c2ae0ad74868c1f502a309c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: clean connection on new GlusterFS failure
by iheim＠redhat.com 06 Nov '13

06 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: clean connection on new GlusterFS failure ...................................................................... webadmin: clean connection on new GlusterFS failure StorageListModel -> saveNewGlusterStorage() -> AddStorageServerConnection: Set connection ID (using action's return value) to enable connection clean-up on failure [as 'StorageListModel -> cleanConnection()' invokes RemoveStorageServerConnection iff connection's ID exists]. Change-Id: Id50f5230e5548e50ff17a7bc6af1bf098ccb8c15 Bug-Url: https://bugzilla.redhat.com/1021882 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified Kanagaraj M: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id50f5230e5548e50ff17a7bc6af1bf098ccb8c15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: disks tab - add listeners on presenter
by iheim＠redhat.com 06 Nov '13

06 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: disks tab - add listeners on presenter ...................................................................... webadmin: disks tab - add listeners on presenter Adding disk type (All/Image/LUN) change event lister on 'MainTabDiskPresenter -> onReveal' in order to ensure listener subscription (currently, since the listeners are added in the view, it might get cleared upon staling the list model). Change-Id: I0a0e76d5c21c1420232b12a6cbf2d65ff2851c09 Bug-Url: https://bugzilla.redhat.com/1019659 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 2 files changed, 29 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a0e76d5c21c1420232b12a6cbf2d65ff2851c09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: move api from /api to /ovirt-engine/api
by mpastern＠redhat.com 06 Nov '13

06 Nov '13

Michael Pasternak has submitted this change and it was merged. Change subject: packaging: move api from /api to /ovirt-engine/api ...................................................................... packaging: move api from /api to /ovirt-engine/api part of the effort to make the ovirt-engine application well behaved application we would like to stop abusing root context of the web server. for backward compatibility /api/* will be forwarded into /ovirt-engine/api/* without redirect. the uris that will be returned in the response will reference to the /ovirt-engine/api namespace. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961677 Change-Id: I2ab8396359db608bb2eaae366f31b92034fa4413 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M ear/pom.xml M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py 6 files changed, 27 insertions(+), 9 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ab8396359db608bb2eaae366f31b92034fa4413 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change inner representation for tunnel migration
by ofrenkel＠redhat.com 06 Nov '13

06 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change inner representation for tunnel migration ...................................................................... core: change inner representation for tunnel migration Findbugs complained about setting tunnel-migration to null, when it was represented as Boolean. We used null value to indicate that the 'VdsProperties.TUNNELED' attribute should not be sent to VDSM (in order to maintain backward compatibility). This patch changes the representation of tunnel-migration from Boolean to boolean, and in MigrateBrokerVDSCommand we check again if the tunnel-migration feature is supported or not, and if it is not supported then we don't send the 'VdsProperties.TUNNELED' to VDSM. Change-Id: I9f1df36ec741f09f49a436854486d37c442fc042 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java 3 files changed, 17 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f1df36ec741f09f49a436854486d37c442fc042 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: agent: Report swap usage of the guests
by vfeenstr＠redhat.com 06 Nov '13

06 Nov '13

Vinzenz Feenstra has submitted this change and it was merged. Change subject: agent: Report swap usage of the guests ...................................................................... agent: Report swap usage of the guests Change-Id: I09f1c0dbbe12eee352637c97a4fa23835d14307a Bug-Url: https://bugzilla.redhat.com/1025845 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09f1c0dbbe12eee352637c97a4fa23835d14307a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix button availability
by gchaplik＠redhat.com 06 Nov '13

06 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix button availability ...................................................................... webadmin: fix button availability 'Remove' button on quota consumer should be enabled immediately, after click on user. Change-Id: Ib9305ef610dd860928bee1de5ee0526c8db388b1 Bug-Url: https://bugzilla.redhat.com/977524 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9305ef610dd860928bee1de5ee0526c8db388b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: check image status before ExportRepoImage
by amureini＠redhat.com 06 Nov '13

06 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: backend: check image status before ExportRepoImage ...................................................................... backend: check image status before ExportRepoImage Before running the ExportRepoImage command we should also check if the image is locked or illegal and in such case prevent the export. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024883 Change-Id: Ib0957a05db4a0fdcddf56a63b0a3da0b4d27db6d Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0957a05db4a0fdcddf56a63b0a3da0b4d27db6d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: radiobutton text is truncated & unaligned
by gchaplik＠redhat.com 06 Nov '13

06 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: radiobutton text is truncated & unaligned ...................................................................... webadmin: radiobutton text is truncated & unaligned Discovered in pt-BR locale Cluster dialog: radio buttons labels in "optimization" section are truncated and unaligned for long text Change-Id: I5bd4ef709ada858140cd33d909aed3dc3171f6df Bug-Url: https://bugzilla.redhat.com/1018382 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 3 files changed, 25 insertions(+), 16 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bd4ef709ada858140cd33d909aed3dc3171f6df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0