February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: build: NlsCheck - proper inner class
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck - proper inner class ...................................................................... build: NlsCheck - proper inner class Made the inner class QuotedString private static, as it is not used outside this class and does not require access to the enclosing class' members. Also removed the redundant semicolon at the end of the declaration. Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: NlsCheck - unwrap else clause
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck - unwrap else clause ...................................................................... build: NlsCheck - unwrap else clause Unwrapped a useless else clause, since the if clause does not terminate properly (it returns from the function). Change-Id: Ie0d43d0402f948dd5f0c45279fc19a2997d7f27b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d43d0402f948dd5f0c45279fc19a2997d7f27b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove useless null check
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove useless null check ...................................................................... webadmin: Remove useless null check Remove a useless null check from VdcQueryReturnValue_CustomFieldSerializer's serialize and deserialize methods. nulls are checked explicitly in the begging of the respective functions, so it cannot be null at their ends. Change-Id: I5a14e8a8705cdd3be8ea24b6da7288bedb01a453 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a14e8a8705cdd3be8ea24b6da7288bedb01a453 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DbFacadeUtils basic Java cleanup
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbFacadeUtils basic Java cleanup ...................................................................... core: DbFacadeUtils basic Java cleanup Some basic Java cleanup - removed useless commit message, added braces, and replaced FQCN with import. Change-Id: I55f89c0684ca67813c6cdfde1c3a938368c13a88 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeUtils.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f89c0684ca67813c6cdfde1c3a938368c13a88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE in AuditLogableBaseTest
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix NPE in AuditLogableBaseTest ...................................................................... core: Fix NPE in AuditLogableBaseTest AuditLogableBaseTest would print an annoying NullPointerException stacktrace due to getVm() trying to access VmNetworkInterfaceDao in getVm(). This patch adds a mock for that DAO (with no additional behavior, as to not change the test's semantics) to avoid this annoying output. Change-Id: I24940142c12e0259544f3e3cb8bc8bd8ca2c2cfa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24940142c12e0259544f3e3cb8bc8bd8ca2c2cfa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up exception in AuditLogDirectorTest
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean up exception in AuditLogDirectorTest ...................................................................... core: Clean up exception in AuditLogDirectorTest Fixed an Exception being printed in AuditLgDirectorTest, caused by the underlying AuditLogableBase trying to access DbFacade. Change-Id: I4ad2abc7c83bf199fc12d35a857cc44322cce0aa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ad2abc7c83bf199fc12d35a857cc44322cce0aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up Version.OpEquality
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean up Version.OpEquality ...................................................................... core: Clean up Version.OpEquality Proper handling of boolean values in OpEquality. Change-Id: Ib09be089763a101ff77e2bbf32970af827cd38df Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib09be089763a101ff77e2bbf32970af827cd38df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PropertyInfo method name
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: PropertyInfo method name ...................................................................... core: PropertyInfo method name Changes PropertyInfo' GetValue method to getValue, as per Java conventions. Change-Id: If29777eb963eeba10473ab0e2638ff80561549f9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If29777eb963eeba10473ab0e2638ff80561549f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix log modifiers in PropretyInfo
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix log modifiers in PropretyInfo ...................................................................... core: Fix log modifiers in PropretyInfo Fixed PropertyInfo's log to have correct modifiers, as per Java conventions. Change-Id: I0a3195d219d601065462f9ecc8a0c467e7561345 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a3195d219d601065462f9ecc8a0c467e7561345 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove PropertyCompat
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove PropertyCompat ...................................................................... core: Remove PropertyCompat PropertyCompat was an empty extension to PropertyInfo, with no additional logic of it's own, and hence pretty redundant. This patch removes it, replaces the single place it was used (TypeCompat) with PropertyInfo and renames the test accordingly. Change-Id: I21cfe23038e2647ee7ce816b532cb28f067ac826 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java R backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java 3 files changed, 7 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21cfe23038e2647ee7ce816b532cb28f067ac826 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0