February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: JUnit 4 style for PropertyCompatTest
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: JUnit 4 style for PropertyCompatTest ...................................................................... core: JUnit 4 style for PropertyCompatTest Fixed PropertyCompatTest to use JUnit 4 style instead of JUnit 3 style - stopped extending TestCase and added @Test annotations. Change-Id: I7d3ee0866a05301f354e366a046197b465796d1c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyCompatTest.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d3ee0866a05301f354e366a046197b465796d1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: TypeCompat - make log final
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: TypeCompat - make log final ...................................................................... core: TypeCompat - make log final Fixed the log's modifiers, as per proper Java conventions. Change-Id: Ia540ae7e42ad7a5315d02b46bba12cc5e6e8d5e5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia540ae7e42ad7a5315d02b46bba12cc5e6e8d5e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Add beanutils as dependency of utils
by juan.hernandez＠redhat.com 22 Feb '13

22 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add beanutils as dependency of utils ...................................................................... packaging: Add beanutils as dependency of utils This is needed by the OVF related code. Change-Id: I633a0a3b4762b808fad9a2bf047889bde37b17f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Federico Simoncelli: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I633a0a3b4762b808fad9a2bf047889bde37b17f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Use JBoss modules instead of class path
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Use JBoss modules instead of class path ...................................................................... tools: Use JBoss modules instead of class path Currently in order to run the tools we build the class path using mostly the "build-classpath" script and also some ad hoc searches. This tends to fail in environments where the jar files are installed in locations different than expected. This patch changes the scripts that starts the tools so that they use the JBoss modules launcher instead, thus manual class path building is no longer required. Change-Id: Id3e4f7a4bd9a3b31ceb453f9257b2ad8eaf03f5a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-config.sh M backend/manager/tools/src/main/shell/engine-manage-domains.sh M backend/manager/tools/src/main/shell/engine-notifier.sh M backend/manager/tools/src/main/shell/engine-prolog.sh.in 4 files changed, 61 insertions(+), 93 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3e4f7a4bd9a3b31ceb453f9257b2ad8eaf03f5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add jxpath as commons-configuration dep
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Add jxpath as commons-configuration dep ...................................................................... core: Add jxpath as commons-configuration dep The commons-configuration module provided by JBoss AS doesn't include commons-jxpath as a dependency, but engine-config needs it in order to parse configuration files, so we need to add a module for commons-jxpath and also override the commons-configuration module to include the dependency on commons-jxpath. Change-Id: I30b0ecc441062670b501d0e9bda1a23639919b5e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/apache/commons/configuration/main/module.xml A backend/manager/dependencies/src/main/modules/org/apache/commons/jxpath/main/module.xml 3 files changed, 69 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30b0ecc441062670b501d0e9bda1a23639919b5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add JBoss modules for libraries
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Add JBoss modules for libraries ...................................................................... core: Add JBoss modules for libraries This patch creates JBoss modules for the common, compat, dal, utils, tooks and searchbackend libraries. Change-Id: Ia14b6488b876ccc364d28b2355ccf6e8772b0627 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/modules/common/pom.xml A backend/manager/modules/common/src/main/modules/org/ovirt/engine/core/common/main/module.xml M backend/manager/modules/compat/pom.xml A backend/manager/modules/compat/src/main/modules/org/ovirt/engine/core/compat/main/module.xml M backend/manager/modules/dal/pom.xml A backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/searchbackend/pom.xml A backend/manager/modules/searchbackend/src/main/modules/org/ovirt/engine/core/searchbackend/main/module.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EngineEJBUtilsStrategy.java A backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M backend/manager/tools/pom.xml A backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml M ear/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M packaging/fedora/spec/ovirt-engine.spec.in M pom.xml 22 files changed, 304 insertions(+), 156 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia14b6488b876ccc364d28b2355ccf6e8772b0627 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: simplify VDSGroup.equals()
by dfediuck＠redhat.com 21 Feb '13

21 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: simplify VDSGroup.equals() ...................................................................... core: simplify VDSGroup.equals() Instead of manually doing a null-safe comparison for each VDSGroup object, use ObjectUtils.objectsEqual(). Also, optimize the order of comparison by looking at the id field first. Change-Id: Iecd1e2314d2791764a4c3456fe21fc7931fe224d Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java 1 file changed, 20 insertions(+), 94 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd1e2314d2791764a4c3456fe21fc7931fe224d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: engine-iso-uploader - small usage's output change
by kroberts＠redhat.com 21 Feb '13

21 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: engine-iso-uploader - small usage's output change ...................................................................... engine-iso-uploader - small usage's output change The usage printed to the screen now says that upload option requires FILE as mandatory parameter. Change-Id: Ibf303445c4035589322d2b69dbed8d00d11a64f8 Bug-Url: https://bugzilla.redhat.com/785670 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf303445c4035589322d2b69dbed8d00d11a64f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: make /export preserved name
by mpastern＠redhat.com 21 Feb '13

21 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: make /export preserved name ...................................................................... codegen: make /export preserved name Change-Id: I96072237f92f9d2cfc56ac576e1b3102388e9fca Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96072237f92f9d2cfc56ac576e1b3102388e9fca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Move dependencies to a JBoss module
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Move dependencies to a JBoss module ...................................................................... packaging: Move dependencies to a JBoss module Currently we package dependencies as .jar files in the lib directories of the .ear and in the .war of RESTAPI. This has the inconvenient that those dependencies don't have an associated artifact and also can't be shared from different applications. This patch moves all those dependencies to the dependencies jboss module, so that they are added to the corresponding artifact, and can then be easily installed and shared. Change-Id: I82a775915f4b2066ef14961cf69c2a35d0673133 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/ovirt/engine/core/dependencies/main/module.xml M backend/manager/modules/restapi/webapp/pom.xml M ear/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M packaging/fedora/spec/ovirt-engine.spec.in 6 files changed, 367 insertions(+), 250 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82a775915f4b2066ef14961cf69c2a35d0673133 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0