February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Singleton row mapper for vds_spm_id_map
by amureini＠redhat.com 27 Feb '13

27 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for vds_spm_id_map ...................................................................... core: Singleton row mapper for vds_spm_id_map Added a singleton row mapper for VdsSpmIdMapDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I04b439e9e2868d66f612144dd91e4f65becd9936 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDAODbFacadeImpl.java 1 file changed, 22 insertions(+), 39 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04b439e9e2868d66f612144dd91e4f65becd9936 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for VdsStatic
by amureini＠redhat.com 27 Feb '13

27 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for VdsStatic ...................................................................... core: Singleton row mapper for VdsStatic Added a singleton row mapper for VdsStaticDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I43133a64e7c7b62277464326606b376fd4306fbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43133a64e7c7b62277464326606b376fd4306fbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for AdGroups
by amureini＠redhat.com 27 Feb '13

27 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for AdGroups ...................................................................... core: Singleton row mapper for AdGroups Added a singleton row mapper for AdGroupsDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I94585c734c1cee7e5c29f16604b5d65135cf1061 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AdGroupDAODbFacadeImpl.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94585c734c1cee7e5c29f16604b5d65135cf1061 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix redundant storage server conn in db
by amureini＠redhat.com 27 Feb '13

27 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix redundant storage server conn in db ...................................................................... core: fix redundant storage server conn in db Fix several problems related to "orphan" storage server connections entries in DB. The redundant entries were inserted when AddStorageServerConnectionCommand succeeded, but another command that ran after it failed. Adding a new command that in case of failure deletes the connection entry from DB fixes the problem. As part of the fix, added assignment of the connection id in UI in StorageListModel after it is created, because otherwise it would not know which connection to delete in case of a failure. The fix takes care of use cases of NFS, POSIX and local storage operations originated from UI. Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8 Bug-Url: https://bugzilla.redhat.com/815083 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 5 files changed, 44 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove AutoLogin enum.
by mlipchuk＠redhat.com 27 Feb '13

27 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove AutoLogin enum. ...................................................................... core: Remove AutoLogin enum. AutoLogin enum is no longer used, and should be removed. Change-Id: I7b461f9ee8a5d6be159557c4d051a69877984e92 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 17 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b461f9ee8a5d6be159557c4d051a69877984e92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

1 0

Change in ovirt-engine[master]: core: Remove unused action type enum values.
by mlipchuk＠redhat.com 27 Feb '13

27 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused action type enum values. ...................................................................... core: Remove unused action type enum values. The removed enums do not have any references, and could be deleted. Change-Id: I8b837f7ba89ba3d78968c9b0b308405f6d2d2dbe Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b837f7ba89ba3d78968c9b0b308405f6d2d2dbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Hot-unplug fails when unplug nic and changing MAC ad...
by alkaplan＠redhat.com 27 Feb '13

27 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Hot-unplug fails when unplug nic and changing MAC address. ...................................................................... engine: Hot-unplug fails when unplug nic and changing MAC address. Hot-unplug fails when trying to unplug and change MAC address for nic under running VM. When unplugging a nic of a running vm- 1. The db is updated. 2. Unplug action is sent to the host. It means that the vdsm gets unplug with the new mac address (although the vnic is defined on the host with the old one). To solve this issue the old mac address should be sent to the vdsm. Change-Id: I185e5572501ea86443a93f4fdf309e0e05520646 Bug-Url: https://bugzilla.redhat.com/904840 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java 4 files changed, 26 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I185e5572501ea86443a93f4fdf309e0e05520646 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Use EnumTranslator for OS types tooltips
by rgolan＠redhat.com 27 Feb '13

27 Feb '13

Roy Golan has submitted this change and it was merged. Change subject: ui: Use EnumTranslator for OS types tooltips ...................................................................... ui: Use EnumTranslator for OS types tooltips Change-Id: I39d0e5437953d72e61f92a833a68aa297fdeed74 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39d0e5437953d72e61f92a833a68aa297fdeed74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: use real OS names
by rgolan＠redhat.com 27 Feb '13

27 Feb '13

Roy Golan has submitted this change and it was merged. Change subject: ui: use real OS names ...................................................................... ui: use real OS names Change the operating system field type to EnumLabel which is being already translated to the real name according to Enum.properties resource file. Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=895609 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml 2 files changed, 8 insertions(+), 15 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Add images for Windows 8 and 2012
by rgolan＠redhat.com 27 Feb '13

27 Feb '13

Roy Golan has submitted this change and it was merged. Change subject: ui: Add images for Windows 8 and 2012 ...................................................................... ui: Add images for Windows 8 and 2012 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=895609 Change-Id: I984e126e85581cc35815cf523bbb1ba95055d3f5 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/Windows2012x64.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/Windows8.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/Windows8x64.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/Windows2012x64.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/Windows8.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/Windows8x64.png 7 files changed, 18 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I984e126e85581cc35815cf523bbb1ba95055d3f5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0