February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add message when template does not exists.
by mlipchuk＠redhat.com 27 Feb '13

27 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add message when template does not exists. ...................................................................... core: Add message when template does not exists. If template does not exists when it is being edited we should return a CDA message which implies it. Change-Id: I1232c9bc9ef75610e58a31568f45fb0ea075088c Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1232c9bc9ef75610e58a31568f45fb0ea075088c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: shorten message for PM test (#909891)
by yzaslavs＠redhat.com 27 Feb '13

27 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: backend: shorten message for PM test (#909891) ...................................................................... backend: shorten message for PM test (#909891) http://bugzilla.redhat.com/909891 Change-Id: I1d9736c64cffba817fbfea7caa51eb0d8820ec32 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d9736c64cffba817fbfea7caa51eb0d8820ec32 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: trace export template command by job status
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: trace export template command by job status ...................................................................... restapi: trace export template command by job status This patch prevents a situation in which the REST reports that export template command was finished before the end-action event is added. This situation occured because the REST part monitored the command according to the statuses of its VDSM tasks - when they were done, it reports back to the user that the command has finished and gave him back the control (the command was invoked synchronously), sometimes before the engine managed to add the end-action event. This patch change the way the export template command is monitored by the REST to be according to the command's job status, that way we ensure that the end-action event is added before REST is reporting back to the user that the command is finished. Change-Id: I4442b337e0242aa756825243dbcf6db1a2b0559f Bug-Url: https://bugzilla.redhat.com/860194 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4442b337e0242aa756825243dbcf6db1a2b0559f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactor GlusterQueriesCommand Base
by sanjal＠redhat.com 27 Feb '13

27 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Refactor GlusterQueriesCommand Base ...................................................................... engine: Refactor GlusterQueriesCommand Base Introducting runVdsCommand() in the GlusterQueriesCommandBase and refactored GetGlusterVolumeProfileInfoQuery, GetGlusterVolumeOptionsInfoQuery and GetGlusterVolumeAdvancedDetailsQuery Moving this change to separate patch(from Gluster Hooks patch) - also removed reference to GlusterHooksDao Change-Id: If73701b7756de155c4917944ed43517e53f9b4e6 Signed-off-by: Sahina Bose <sahina(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQueryTest.java 7 files changed, 32 insertions(+), 29 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If73701b7756de155c4917944ed43517e53f9b4e6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move fkvalidator.sh to tools/dbutils
by yzaslavs＠redhat.com 27 Feb '13

27 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Move fkvalidator.sh to tools/dbutils ...................................................................... core: Move fkvalidator.sh to tools/dbutils fkvalidator uses SPs that should also be moved to the tools/dbscripts directory. Since the fkvalidator is used from the installer in the pre-upgrade step, it will fail if those SPs are not found. Change-Id: Ib4211b8ff2ab00c85d9f73bb4e7338324017878a Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912305 --- M backend/manager/dbscripts/common_sp.sql M backend/manager/tools/dbutils/fkvalidator.sh A backend/manager/tools/dbutils/fkvalidator_sp.sql 3 files changed, 56 insertions(+), 54 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4211b8ff2ab00c85d9f73bb4e7338324017878a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Event should log disk alias instead UNKNOWN.
by mlipchuk＠redhat.com 27 Feb '13

27 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Event should log disk alias instead UNKNOWN. ...................................................................... core: Event should log disk alias instead UNKNOWN. When removing a disk, we should indicate the disk name instead <UNKNOWN> string. The <UNKNOWN> is presented since engine tries to get the disk alias after the disk was already deleted. The fix is to initialize the disk parameter before the deletion. Change-Id: Id111a067819cd881ee6fd22b588562028087fee8 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id111a067819cd881ee6fd22b588562028087fee8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: check up server in gluster cluster guide me
by sanjal＠redhat.com 27 Feb '13

27 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: check up server in gluster cluster guide me ...................................................................... webadmin: check up server in gluster cluster guide me While showing the Guide Me popup for a gluster supported cluster which already contains some hosts in it, 'Add Another Host' and 'Select Host' action will be shown only if there is a host in Up status. Change-Id: I0cea3a3c2a64eca78740d921680faeeb0c5473c7 Bug-Url: https://bugzilla.redhat.com/906703 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java 1 file changed, 31 insertions(+), 3 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cea3a3c2a64eca78740d921680faeeb0c5473c7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: defend against malformed server reply
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: defend against malformed server reply ...................................................................... sdk: defend against malformed server reply Change-Id: I236863ab9fee7b5af43402f1beb055dc6ea0e39b Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/errors.py M src/ovirtsdk/infrastructure/proxy.py 4 files changed, 24 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I236863ab9fee7b5af43402f1beb055dc6ea0e39b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: codegen: implement generic URI processing
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: implement generic URI processing ...................................................................... codegen: implement generic URI processing Change-Id: I36d3914a0b8f639d0d6a32d1cc3ef18e6fb63541 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py 1 file changed, 24 insertions(+), 17 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d3914a0b8f639d0d6a32d1cc3ef18e6fb63541 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: codegen: move to template oriented concept
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: move to template oriented concept ...................................................................... codegen: move to template oriented concept Change-Id: I999f64d74f09a813d16ec5877efa8a4949db18c2 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/collection.py M src/codegen/collection/collectionexceptions.py D src/codegen/collection/resource.py M src/codegen/common/icodegen.py M src/codegen/doc/documentation.py M src/codegen/entrypoint/entrypoint.py D src/codegen/imp/imprt.py R src/codegen/imprt/__init__.py A src/codegen/imprt/imprt.py D src/codegen/infrastructure/collection.py D src/codegen/infrastructure/resource.py M src/codegen/infrastructure/staticdataholder.py C src/codegen/resource/__init__.py A src/codegen/resource/resource.py M src/codegen/rsdl/abstractrsdlcodegen.py M src/codegen/rsdl/rsdlcodegen.py M src/codegen/subcollection/subcollection.py D src/codegen/subcollection/subresource.py C src/codegen/subresource/__init__.py A src/codegen/subresource/subresource.py C src/codegen/templates/__init__.py A src/codegen/templates/abstracttemplate.py A src/codegen/templates/collectionaddtemplate A src/codegen/templates/collectionaddtemplate.py A src/codegen/templates/collectiongetcapabilitiestemplate A src/codegen/templates/collectiongetcapabilitiestemplate.py A src/codegen/templates/collectiongetdiskstemplate A src/codegen/templates/collectiongetdiskstemplate.py A src/codegen/templates/collectiongetnotsearchabletemplate A src/codegen/templates/collectiongetnotsearchabletemplate.py A src/codegen/templates/collectiongetsearchabletemplate A src/codegen/templates/collectiongetsearchabletemplate.py A src/codegen/templates/collectionlistcapabilitiestemplate A src/codegen/templates/collectionlistcapabilitiestemplate.py A src/codegen/templates/collectionlistnotsearchabletemplate A src/codegen/templates/collectionlistnotsearchabletemplate.py A src/codegen/templates/collectionlistsearchabletemplate A src/codegen/templates/collectionlistsearchabletemplate.py A src/codegen/templates/collectiontemplate A src/codegen/templates/collectiontemplate.py A src/codegen/templates/copyrighttemplate A src/codegen/templates/copyrighttemplate.py A src/codegen/templates/entrypointdyinamicmethodtemplate A src/codegen/templates/entrypointdyinamicmethodtemplate.py A src/codegen/templates/entrypointheadtemplate A src/codegen/templates/entrypointheadtemplate.py A src/codegen/templates/entrypointmethodstemplate A src/codegen/templates/entrypointmethodstemplate.py A src/codegen/templates/entrypointstaticmethodtemplate A src/codegen/templates/entrypointstaticmethodtemplate.py A src/codegen/templates/entrypointtemplate A src/codegen/templates/entrypointtemplate.py A src/codegen/templates/importstemplate A src/codegen/templates/importstemplate.py A src/codegen/templates/itemplate.py A src/codegen/templates/resourceactiontemplate A src/codegen/templates/resourceactiontemplate.py A src/codegen/templates/resourcedeletetemplate A src/codegen/templates/resourcedeletetemplate.py A src/codegen/templates/resourcedeletewithbodyandparamstemplate A src/codegen/templates/resourcedeletewithbodyandparamstemplate.py A src/codegen/templates/resourcedeletewithbodytemplate A src/codegen/templates/resourcedeletewithbodytemplate.py A src/codegen/templates/resourcedeletewithparamstemplate A src/codegen/templates/resourcedeletewithparamstemplate.py A src/codegen/templates/resourcetemplate A src/codegen/templates/resourcetemplate.py A src/codegen/templates/resourceupdatetemplate A src/codegen/templates/resourceupdatetemplate.py A src/codegen/templates/subcollectionaddtemplate A src/codegen/templates/subcollectionaddtemplate.py A src/codegen/templates/subcollectiongettemplate A src/codegen/templates/subcollectiongettemplate.py A src/codegen/templates/subcollectionlisttemplate A src/codegen/templates/subcollectionlisttemplate.py A src/codegen/templates/subcollectionlistwithparamstemplate A src/codegen/templates/subcollectionlistwithparamstemplate.py A src/codegen/templates/subcollectiontemplate A src/codegen/templates/subcollectiontemplate.py A src/codegen/templates/subresourceactiontemplate A src/codegen/templates/subresourceactiontemplate.py A src/codegen/templates/subresourcecollectionactiontemplate A src/codegen/templates/subresourcecollectionactiontemplate.py A src/codegen/templates/subresourcedeletetemplate A src/codegen/templates/subresourcedeletetemplate.py A src/codegen/templates/subresourcedeletewithbodytemplate A src/codegen/templates/subresourcedeletewithbodytemplate.py A src/codegen/templates/subresourcedeletewithurlparamsandbodytemplate A src/codegen/templates/subresourcedeletewithurlparamsandbodytemplate.py A src/codegen/templates/subresourcedeletewithurlparamstemplate A src/codegen/templates/subresourcedeletewithurlparamstemplate.py A src/codegen/templates/subresourcetemplate A src/codegen/templates/subresourcetemplate.py A src/codegen/templates/subresourceupdatetemplate A src/codegen/templates/subresourceupdatetemplate.py A src/codegen/utils/paramscontainer.py R src/codegen/xsd/README M src/codegen/xsd/abstractxsdcodegen.py R src/codegen/xsd/genparams.py R src/codegen/xsd/paramsconf.py M src/codegen/xsd/xsdcodegen.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/common.py M src/ovirtsdk/web/connection.py M src/ovirtsdk/web/httpsconnection.py 105 files changed, 2,819 insertions(+), 1,179 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I999f64d74f09a813d16ec5877efa8a4949db18c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0