May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: Proper error testing in EngineConfigCLITest
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: tools: Proper error testing in EngineConfigCLITest ...................................................................... tools: Proper error testing in EngineConfigCLITest Converted the error tests in EngineConfigCLITest to the proper JUnit form (with the expect parameter on the @Test annotation), instead of the awkward explicit fail before the catch block. Since the test methods have meaningful names, this change also allowed removing the System.out.println calls. Change-Id: Iad25eae4fd7b4535cc1b2d9570f142d6996b79d0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigCLIParserTest.java 1 file changed, 4 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad25eae4fd7b4535cc1b2d9570f142d6996b79d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Synthetic emulators EcryptionUtilsTest
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Synthetic emulators EcryptionUtilsTest ...................................................................... core: Synthetic emulators EcryptionUtilsTest Changed members visibility from private to protected to solve the synthetic emulators warning. This may slightly increase performance, but I doubt it will be noticeable. Change-Id: I5d17aa584e4b8c1d858d74c155265a9f30cf86d0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EncryptionUtilsTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d17aa584e4b8c1d858d74c155265a9f30cf86d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: EncryptoinUtilsTest @Before->@BeforeClass
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: EncryptoinUtilsTest @Before->@BeforeClass ...................................................................... core: EncryptoinUtilsTest @Before->@BeforeClass Replaced the @Before method with @BeforeClass. There is a single URL that won't change between test runs. Change-Id: I89ad4e12f08af5e0ef19e486bf21c350ad7f1015 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EncryptionUtilsTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89ad4e12f08af5e0ef19e486bf21c350ad7f1015 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed std from KDCLocatorTest
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed std from KDCLocatorTest ...................................................................... core: Removed std from KDCLocatorTest Removed printing of results with System.out.println - this is no way to handle robust logging. Change-Id: I37eac9646bcbabe3a80a563e41d7bd904de626cd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/KDCLocatorTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37eac9646bcbabe3a80a563e41d7bd904de626cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove stdout from SimpleAuthenticationCheck
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove stdout from SimpleAuthenticationCheck ...................................................................... core: Remove stdout from SimpleAuthenticationCheck Removed an old System.out.println call from the class - it was probably left there by mistake during debugging, and in any event has no place in production code. Change-Id: I1ac20e5aa5d9a8236a2a081c5cd0be68a25f724b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ipa/SimpleAuthenticationCheck.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ac20e5aa5d9a8236a2a081c5cd0be68a25f724b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine:Sync gluster hooks
by sanjal＠redhat.com 06 May '13

06 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine:Sync gluster hooks ...................................................................... engine:Sync gluster hooks This patch adds a periodic job to sync gluster hooks on servers in the cluster with the hooks stored in database. Every execution of the job - Retrieves the list of hooks from each server in the cluster - Compares the list with the saved data in database - If different, inserts or updates the database - Changes conflict status in db, if any status, content or missing conflict detected. Added GlusterHooksEnabled to GlusterFeatureSupported. Change-Id: I2766edd4e810677a200cf5c45d334cabef5f2924 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/dbscripts/gluster_hooks_sp.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 13 files changed, 661 insertions(+), 18 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2766edd4e810677a200cf5c45d334cabef5f2924 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Allow editing a bootable disk
by amureini＠redhat.com 05 May '13

05 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Allow editing a bootable disk ...................................................................... core: Allow editing a bootable disk Fixed a couple of bugs in getOtherVmDisks(Guid) to allow editing a bootable disk: 1. Once the list of disks is produced, it should be saved in the cache map 2. The break statement should be inside the if, not after it. Change-Id: I111de3ff5710d29d1301c0c47e12755d88e016b9 Bug-Url: https://bugzilla.redhat.com/959761 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified Liron Ar: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I111de3ff5710d29d1301c0c47e12755d88e016b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added encodingvalidator.sh to validation list
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added encodingvalidator.sh to validation list ...................................................................... packaging: Added encodingvalidator.sh to validation list This patch updates encodingvalidator.sh utility and adds it to the list of executed validators in validatedb.sh generic script. Change-Id: Ic89088c7738eb379b2bc88d8d59193d4ed20a295 Bug-Url: https://bugzilla.redhat.com/920565 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M backend/manager/tools/dbutils/encodingvalidator.sh M backend/manager/tools/dbutils/validatedb.sh 3 files changed, 11 insertions(+), 8 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic89088c7738eb379b2bc88d8d59193d4ed20a295 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: changed vm ip cloumn to text (#953148)
by ydary＠redhat.com 05 May '13

05 May '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: changed vm ip cloumn to text (#953148) ...................................................................... history: changed vm ip cloumn to text (#953148) This is to match the engine type and allow almost unlimited ip amount per vm. Bug-Url: https://bugzilla.redhat.com/953148 Change-Id: Ifdf493916b22cd53fc36b36ec128add43e655941 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.2.item M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.2.properties M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.2.item M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.2.properties M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.2.item M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.2.properties M data-warehouse/historydbscripts_postgres/create_views_3_0.sql M data-warehouse/historydbscripts_postgres/create_views_3_1.sql A data-warehouse/historydbscripts_postgres/upgrade/03_02_0070_changed_vm_ip_column_to_text.sql 9 files changed, 26 insertions(+), 22 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf493916b22cd53fc36b36ec128add43e655941 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: Adding fencing parameters to log print
by yzaslavs＠redhat.com 05 May '13

05 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Adding fencing parameters to log print ...................................................................... Adding fencing parameters to log print Change-Id: Ic14f3ae9e302ffaf8e4fc883f2a177864e512c4f Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic14f3ae9e302ffaf8e4fc883f2a177864e512c4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0