May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Support column resizing for all tables
by vszocs＠redhat.com 03 May '13

03 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Support column resizing for all tables ...................................................................... webadmin,userportal: Support column resizing for all tables This patch moves column resize implementation out of AbstractActionTable and into dedicated table widget, ColumnResizeCellTable. 1. All custom CellTable widgets now inherit from ColumnResizeCellTable: - ElementIdCellTable [ActionCellTable + EntityModelCellTable] - IVdcQueryableCellTable 2. ColumnResizeCellTable now contains enableColumnResizing() method, plus some other related/useful methods 3. Columns added to ColumnResizeCellTable automatically benefit from tooltip displayed when the given header has its content (text) truncated, i.e. after shrinking the column or with long header text 4. AbstractActionTable now just delegates to table/tableHeader widgets, plus code to synchronize both tables (during column resize, etc.) 5. AbstractCellWithTooltip now contains common tooltip-related logic used by different subclasses: - SafeHtmlCellWithTooltip [resizable + non-resizable header cells] - TextCellWithTooltip [textual body cells] 6. Minor ElementIdCellTable improvement: call configureElementId() for every insertColumn() call for better consistency AbstractCellWithTooltip does two kinds of content overflow detection: (a) scrollWidth with temporary CSS 'overflow:auto' (b) clientHeight with temporary CSS 'whiteSpace:normal' In practice, (a) is used for both header and body cells. In Firefox, header cells (SafeHtmlCellWithTooltip) use <div> with 'display:block' to work around Firefox-specific issue with scrollWidth. Change-Id: Ic69b597d7c5f2330cef5a93bc8812494af731734 Bug-Url: https://bugzilla.redhat.com/956378 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IVdcQueryableCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ElementIdCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithTooltip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlCellWithTooltip.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeaderCell.java 11 files changed, 530 insertions(+), 235 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic69b597d7c5f2330cef5a93bc8812494af731734 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Disabling WAN options for SPICE doesn't work
by tjelinek＠redhat.com 03 May '13

03 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Disabling WAN options for SPICE doesn't work ...................................................................... frontend: Disabling WAN options for SPICE doesn't work SPICE -> Enable WAN options causes 16bit color depth get kept for every console opening for whole browser session even after disabling this option in the console dialog. The problem was caused by not resetting the ColorDepth and DisabledEffects values after disabling WAN options to default values. Change-Id: Ie64779658796243f0182ac1209d9f5640b4370fc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=913183 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie64779658796243f0182ac1209d9f5640b4370fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Spice is always available
by tjelinek＠redhat.com 03 May '13

03 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Spice is always available ...................................................................... frontend: Spice is always available This patch removes the method ConsoleUtils.isSpiceAvailable because it is no longer needed as spice can be always invoked using the nonplugin way. This patch also moves configuration of spice implementations (by Configurator classes) and connect listener to the method responsible for switching implementations on the fly so that effect of these actions is not forgotten after switching spice implementation. Change-Id: Ice5c3f80988962c5fa5e39f51e91543938258912 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleManagerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 6 files changed, 19 insertions(+), 42 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice5c3f80988962c5fa5e39f51e91543938258912 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: WARNING: nonstandard use of escape in...
by yzaslavs＠redhat.com 03 May '13

03 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: WARNING: nonstandard use of escape in... ...................................................................... core: WARNING: nonstandard use of escape in... WARNING: nonstandard use of escape in a string literal Adding use of the escape string syntax for escapes, Change-Id: I168e1fe503c235d36b07aed18d88dc017726155e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958018 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I168e1fe503c235d36b07aed18d88dc017726155e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: User Event Notification dialog element IDs
by vszocs＠redhat.com 02 May '13

02 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: User Event Notification dialog element IDs ...................................................................... webadmin: User Event Notification dialog element IDs 1. UI infrastructure changes - created ElementIdCellTree that supports assigning DOM element IDs to tree nodes through HasElementId interface - EntityModelCellTree derives from ElementIdCellTree, so all model-bound trees now support node element IDs - ModelListTreeViewModel does the actual element ID assignment for the CheckboxCell - example tree node ID, e.g. 2nd child of 3rd root node: <prefix>_root2_node1 2. WebAdmin dialog changes - User Event Notification dialog (ManageEventsPopupView) now supports element IDs for Tree and Expand/Collapse buttons Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a Bug-Url: https://bugzilla.redhat.com/870993 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TreeNodeModel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ColumnWithElementId.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/ElementIdCellTree.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/TreeModelWithElementId.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SimpleSelectionTreeNodeModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EntityModelCellTree.java 11 files changed, 220 insertions(+), 88 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Adding parameters to delay fence based on host's load
by yzaslavs＠redhat.com 02 May '13

02 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Adding parameters to delay fence based on host's load ...................................................................... Adding parameters to delay fence based on host's load Before performing fencing to host, we wait TimeoutToResetVdsInSeconds. This patch adds a formula based on vms count and SPM status that calculates different timeout period before starting the fence. Change-Id: I69c15b254cb5323416aaa33756866218870056d2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=924801 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/tools/src/main/conf/engine-config.properties 4 files changed, 31 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69c15b254cb5323416aaa33756866218870056d2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: move profile to the end of the pom
by lhornyak＠redhat.com 02 May '13

02 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: tools: move profile to the end of the pom ...................................................................... tools: move profile to the end of the pom Moved the optional itests profile to the end of the pom file to make it more readable. Now, the regular build flow can be read without the conceptual interruption of an optional profile. Change-Id: I611035ea98c5254c1e5b86d057255447d1ce313e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/pom.xml 1 file changed, 15 insertions(+), 17 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I611035ea98c5254c1e5b86d057255447d1ce313e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: enable unit tests
by lhornyak＠redhat.com 02 May '13

02 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: tools: enable unit tests ...................................................................... tools: enable unit tests The tools package contains some useful unit tests, which are unfortunately disabled since they are intermixed with integration tests. This patch replaces the all-out disabling of the package's tests with a black list of component tests, allowing the unit tests to run in build time. Change-Id: Ic9205fd5d46fb8e44c0ad87cfbe4c3b5c7817dbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/pom.xml 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9205fd5d46fb8e44c0ad87cfbe4c3b5c7817dbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Override CommandBase.getJobMessageProperties
by sanjal＠redhat.com 02 May '13

02 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Override CommandBase.getJobMessageProperties ...................................................................... gluster: Override CommandBase.getJobMessageProperties The patch overrides the basic implementation of getJobMessageProperties with a concrete one relevant to Gluster commands: 1. Commands inherited from GlusterCommandBase define the Cluster name. 2. Commands inherited from GlusterVolumeCommandBase define Volume name as well as Cluster name. Change-Id: I393621e3f52b343b8dc5916f20497a0da3aa3bf1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 27 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I393621e3f52b343b8dc5916f20497a0da3aa3bf1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi:Correct rsdl for add bricks
by mpastern＠redhat.com 02 May '13

02 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi:Correct rsdl for add bricks ...................................................................... restapi:Correct rsdl for add bricks Add bricks command causes an exception in cli when passed a collection of bricks. Changed the rsdl to brick--COLLECTION as per Michael's suggestion Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Bug-Url: https://bugzilla.redhat.com/923169 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0