May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: fixup configuration preview alignment
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fixup configuration preview alignment ...................................................................... packaging: setup: fixup configuration preview alignment Change-Id: I9ae723f26fde5c1a85b45843a461460b37bc0b82 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ae723f26fde5c1a85b45843a461460b37bc0b82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fixed uninstall files handling
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fixed uninstall files handling ...................................................................... packaging: setup: fixed uninstall files handling - don't fail if we have empty uninstall file during cleanup - avoid to write an empty uninstall file while aborting setup Change-Id: Icc0135799f939327ec90adeafba67d47002c800a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/files/simple.py M packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc0135799f939327ec90adeafba67d47002c800a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: check engine version on upgrade
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: check engine version on upgrade ...................................................................... packaging: setup: check engine version on upgrade abort engine-setup-2 if upgrading with datacenters and clusters with unsupported versions. Change-Id: I76eac3e8c177291fea574024618f7feb6e12ff69 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/db/schema.py 3 files changed, 45 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76eac3e8c177291fea574024618f7feb6e12ff69 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fix local state dirs ownership
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fix local state dirs ownership ...................................................................... packaging: setup: fix local state dirs ownership - clean up /var/tmp/ovirt-engine if it contains at least one file not owned by engine - chown -Rh ovirt:ovirt /var/lib/ovirt-engine/deployments Previous versions mixed root/ovirt ownership in those directories Change-Id: I180fa0b1c3ded975c052405126819d91524a829f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/system/environment.py M packaging/setup/plugins/ovirt-engine-setup/system/__init__.py A packaging/setup/plugins/ovirt-engine-setup/system/localstate.py 4 files changed, 111 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I180fa0b1c3ded975c052405126819d91524a829f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: use Math.abs for more accurate floating point comp...
by shavivi＠redhat.com 29 May '13

29 May '13

Hello ovirt-engine-commits, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/15157 to review the following change. Change subject: findbugs: use Math.abs for more accurate floating point comparison ...................................................................... findbugs: use Math.abs for more accurate floating point comparison findbugs reason:findbugs reason:findbugs FE: Test for floating point equality (FE_FLOATING_POINT_EQUALITY) Change-Id: I6ce08ed47a51db05b61b56ea6facf3e9a7d33645 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/15157/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java index 493ed38..ee161a7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java @@ -985,7 +985,7 @@ if (QuotaStorage.UNLIMITED.equals(quotaStorage.getStorageSizeGB())) { storageLimit = QuotaStorage.UNLIMITED; // Do not break because usage is still counting } - if (storageLimit != QuotaStorage.UNLIMITED) { + if (Math.abs(storageLimit) != QuotaStorage.UNLIMITED) { storageLimit += quotaStorage.getStorageSizeGB(); } storageUsage += quotaStorage.getStorageSizeGBUsage(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java index e130cc2..37c55a4 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java @@ -198,7 +198,7 @@ // checks if it is an enabled value for (double i = slider.getMinValue(); i <= newValue; i += slider.getStepSize()) { - if (i == newValue) { + if (Math.abs(i) == Math.abs(newValue)) { return true; } } -- To view, visit http://gerrit.ovirt.org/15157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ce08ed47a51db05b61b56ea6facf3e9a7d33645 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: ovirt-engine-commits <engine-commits(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: Adds UserDefinedVMProperties validator to engine-conf...
by yzaslavs＠redhat.com 29 May '13

29 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Adds UserDefinedVMProperties validator to engine-config ...................................................................... tools: Adds UserDefinedVMProperties validator to engine-config Adds validator of UserDefinedVMProperties validator to engine-config to ensure that only valid values will be filled in UserDefinedVMProperties. Change-Id: I503c00fe005b35314af72564059242a95edb4aa6 Bug-Url: https://bugzilla.redhat.com/962666 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/UserDefinedVMPropertiesValueHelper.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 48 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I503c00fe005b35314af72564059242a95edb4aa6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Prepare custom device properties support in VmProperti...
by yzaslavs＠redhat.com 29 May '13

29 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Prepare custom device properties support in VmPropertiesUtils ...................................................................... core: Prepare custom device properties support in VmPropertiesUtils 1) Move org.ovirt.engine.core.utils.vmproperties.VmPropertiesUtils to org.ovirt.engine.core.utils.customprop package 2) Extract common functionality to abstract parent CustomPropertiesUtils to support custom device properties in following patches Change-Id: Ib18a622a1d02f444c6bdc1e22c2f92f93c52757e Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmCustomPropertiesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 14 files changed, 248 insertions(+), 230 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib18a622a1d02f444c6bdc1e22c2f92f93c52757e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: No Search for isVmTemlateWithSameNameExist
by amureini＠redhat.com 29 May '13

29 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: No Search for isVmTemlateWithSameNameExist ...................................................................... core: No Search for isVmTemlateWithSameNameExist Replaced VmTemplateCommand.isVmTemlateWithSameNameExist(String)'s implementation with a simple DAO call instead of invoking an expensive Search query. Change-Id: I5e9d57ad4d46b22d98529e07a2c67fed968d45cf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e9d57ad4d46b22d98529e07a2c67fed968d45cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated fkvalidator SP to drop function before re...
by emesika＠redhat.com 29 May '13

29 May '13

Eli Mesika has submitted this change and it was merged. Change subject: packaging: Updated fkvalidator SP to drop function before recreating ...................................................................... packaging: Updated fkvalidator SP to drop function before recreating This package updates the fkvalidator_sp with drop function call, so that this stored procedure can be loaded into older databases (the signature of the function changed, so it cannot be overwritten, only recreated). Change-Id: Ic20625ed61caf8f1aaff4860c18f048402b32353 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/tools/dbutils/fkvalidator_sp.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20625ed61caf8f1aaff4860c18f048402b32353 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: gluster mode - show cluster comp version
by kmayilsa＠redhat.com 29 May '13

29 May '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: gluster mode - show cluster comp version ...................................................................... webadmin: gluster mode - show cluster comp version Making the cluster Version combobox visible while running the Application in Gluster mode. Change-Id: I26cd483dd74858fe25df2f0f9153b31835a7e8ad Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26cd483dd74858fe25df2f0f9153b31835a7e8ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0