May 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: core: fix typo in environment exec dir
by Alon Bar-Lev 27 May '13

27 May '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: fix typo in environment exec dir ...................................................................... core: fix typo in environment exec dir Change-Id: I5e9f239f9b84efe59e1da5c315ef399e08c6ec8a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/constants.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e9f239f9b84efe59e1da5c315ef399e08c6ec8a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hide refresh triangle icon on sub-tabs
by derez＠redhat.com 27 May '13

27 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: hide refresh triangle icon on sub-tabs ...................................................................... webadmin: hide refresh triangle icon on sub-tabs Refresh options/menu triangle icon is redundant for sub-tabs since isTimerDisabled == true. I.e. refresh button for sub-tabs is relevant only for manual refresh. Hence, hide refresh menu icon on sub-tabs. Affected sub-tabs: Hosts -> Network Interfaces Storage -> Images Change-Id: I5c467e94bc7a2562bac4711b6b64e5f0b6699b53 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c467e94bc7a2562bac4711b6b64e5f0b6699b53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, root: Control scope of cookies in root webapp
by vszocs＠redhat.com 27 May '13

27 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,root: Control scope of cookies in root webapp ...................................................................... webadmin,root: Control scope of cookies in root webapp This patch ensures that both "langPageShown" and "locale" cookies are explicitly scoped to root webapp context URL, i.e. cookie path is "/". The reason for scoping both cookies to "/" path is to make them visible (available) to server-side code regardless of the current request (i.e. /docs/xxx). Change-Id: Id3beef969b96bad40bbeef86708c7f62b3b690ad Bug-Url: https://bugzilla.redhat.com/966525 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/SplashServlet.java 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3beef969b96bad40bbeef86708c7f62b3b690ad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixed typo in variable name
by emesika＠redhat.com 27 May '13

27 May '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Fixed typo in variable name ...................................................................... core: Fixed typo in variable name Not much to be said about it. Change-Id: I5a8c98049a79875a0eb31b09f3e586489b200494 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java 1 file changed, 27 insertions(+), 27 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/14761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a8c98049a79875a0eb31b09f3e586489b200494 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: add ignore for super.clone from VDS.clone ...
by shavivi＠redhat.com 27 May '13

27 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: add ignore for super.clone from VDS.clone method ...................................................................... findbugs: ignore: add ignore for super.clone from VDS.clone method findbugs complains that VDS clone() method is not calling it super class clone() method. we cannot call super.close() because this code compile to GWT as well, and GWT does not support CloneNotSupportedException which is thrown when adding this code. findbugs reason: CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) Change-Id: I9954242e24851df299c0d4d74f6466a66327120f Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A backend/manager/modules/common/exclude-filters.xml M backend/manager/modules/common/pom.xml 2 files changed, 29 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9954242e24851df299c0d4d74f6466a66327120f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: comparing two different types
by shavivi＠redhat.com 27 May '13

27 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: comparing two different types ...................................................................... findbugs: comparing two different types findbugs reason: EC: Call to equals() comparing different interface types (EC_UNRELATED_INTERFACES) Change-Id: If5d76c345e7a0f9c08e03c9b60fbcdd9fc1a4467 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5d76c345e7a0f9c08e03c9b60fbcdd9fc1a4467 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added Providers to system tree
by oourfali＠redhat.com 27 May '13

27 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Added Providers to system tree ...................................................................... webadmin: Added Providers to system tree Added new node under System node called Providers, below which will appear the providers that exist in the engine's database. Change-Id: I89c79d2789b1e6058c77404639f6c8b90f82d2a6 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_provider.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_providers.png 9 files changed, 79 insertions(+), 7 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c79d2789b1e6058c77404639f6c8b90f82d2a6 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : --parent-tag-id|name options doesn't exists in 'ad...
by mpastern＠redhat.com 27 May '13

27 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : --parent-tag-id|name options doesn't exists in 'add tag' options ...................................................................... restapi : --parent-tag-id|name options doesn't exists in 'add tag' options >From cli --parent-tag-id and --parent-tag-name options doesn't exists in 'add tag' options, they are working (should be added to autocompletion) Change-Id: I9e82ee769ba97f6e2765edb6990c4bdd6b88e29a Bug-Url: https://bugzilla.redhat.com/961371 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e82ee769ba97f6e2765edb6990c4bdd6b88e29a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : storage_format option doesn't exists in 'add stora...
by mpastern＠redhat.com 27 May '13

27 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : storage_format option doesn't exists in 'add storagedomain' options ...................................................................... restapi : storage_format option doesn't exists in 'add storagedomain' options storage_format is not displayed as one of the available options in cli for add storagedomain Change-Id: I018dc2f003f0c8e449adb596412d8d797785efda Bug-Url: https://bugzilla.redhat.com/961229 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I018dc2f003f0c8e449adb596412d8d797785efda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added Data Centers node in system tree
by oourfali＠redhat.com 27 May '13

27 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Added Data Centers node in system tree ...................................................................... webadmin: Added Data Centers node in system tree Added in between System node and specific Data Center nodes, as preparation for another category under the System node: Providers. Change-Id: I26665a6bb2d12b0e19567002d685d9821d15f53c Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/datacenters.png 7 files changed, 24 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26665a6bb2d12b0e19567002d685d9821d15f53c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0