June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: ignore Unwritten public fields
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore Unwritten public fields ...................................................................... findbugs: ignore Unwritten public fields This classes are GWT classes and will generated code that will write to this fields findbugs reason: UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD) Change-Id: I0453d3d7e4404727afe4d356f49547969cef951b Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A frontend/webadmin/modules/uicompat/exclude-filters.xml M frontend/webadmin/modules/uicompat/pom.xml 2 files changed, 40 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0453d3d7e4404727afe4d356f49547969cef951b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Log interface should not be the same as th...
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Log interface should not be the same as the implemented class name ...................................................................... findbugs: ignore: Log interface should not be the same as the implemented class name findbugs warns about using namespace interface 'Log' is the same name as the implemented interface name 'Log'. The class is deeply embedded in the code so we are ignoring findbugs warning for now Nm: Class names shouldn't shadow simple name of implemented interface (NM_SAME_SIMPLE_NAME_AS_INTERFACE) Change-Id: Icef5b803ad9aacaf5f6150f3e0744ccc22ec7936 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/exclude-filters.xml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef5b803ad9aacaf5f6150f3e0744ccc22ec7936 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename methods to start with lowercase
by amureini＠redhat.com 09 Jun '13

09 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename methods to start with lowercase ...................................................................... core: rename methods to start with lowercase Rename several methods to start with lowercase -java standard. Change-Id: I13d9f2ee1d107abaa78519f1714998f09317cab1 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 5 files changed, 9 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13d9f2ee1d107abaa78519f1714998f09317cab1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Some network cleanups
by masayag＠redhat.com 09 Jun '13

09 Jun '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Some network cleanups ...................................................................... engine: Some network cleanups Some cleanup for networks related code. Change-Id: I546f6081f285a758ea810de2b080bc2cb8c0d9a3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java 6 files changed, 11 insertions(+), 22 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/15448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I546f6081f285a758ea810de2b080bc2cb8c0d9a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use NetworkUtils.getEngineNetwork where possible
by masayag＠redhat.com 09 Jun '13

09 Jun '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use NetworkUtils.getEngineNetwork where possible ...................................................................... engine: Use NetworkUtils.getEngineNetwork where possible The patch replaces same logic for resolving the management network name with NetworkUtils.getEngineNetwork. Change-Id: I76bd3d0de7d5d2db1656f17670d820f6384c0712 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 9 files changed, 21 insertions(+), 25 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76bd3d0de7d5d2db1656f17670d820f6384c0712 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: "exit" command fails after "disconnect" from script #97...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: "exit" command fails after "disconnect" from script #971285 ...................................................................... cli: "exit" command fails after "disconnect" from script #971285 Change-Id: Ie4a3807e9016d7a6007d938c0ca9aad50f9c50d9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=971285 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4a3807e9016d7a6007d938c0ca9aad50f9c50d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: "exit" command fails after "disconnect" from script #97...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: "exit" command fails after "disconnect" from script #971285 ...................................................................... cli: "exit" command fails after "disconnect" from script #971285 Change-Id: Ie6579879fa45e97e2d13f2e32202ab5f17665b24 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=971285 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6579879fa45e97e2d13f2e32202ab5f17665b24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : memory_policy-guaranteed option doesn't exists in ...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : memory_policy-guaranteed option doesn't exists in 'add vm' autocompletion ...................................................................... restapi : memory_policy-guaranteed option doesn't exists in 'add vm' autocompletion >From cli --memory_policy-guaranteed option doesn't exists in 'add vm' autocompletion options, when it passed it is working (should be added to autocompletion options) Change-Id: I1e201343a782e0fb947ce3055a304db03950d6dd Bug-Url: https://bugzilla.redhat.com/962447 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e201343a782e0fb947ce3055a304db03950d6dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RSDL Missing 'fence_type' param - #969797
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL Missing 'fence_type' param - #969797 ...................................................................... restapi: RSDL Missing 'fence_type' param - #969797 For .../api/hosts/xxx/fence - fence_type is a mandatory parameter. Added this information to rsdl_metadata.yaml file. Bug-Url: http://bugzilla.redhat.com/969797 Change-Id: I2ee34a0698e9c6df9ae07b2c0665bacac86da845 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ee34a0698e9c6df9ae07b2c0665bacac86da845 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi: RSDL rename power_management.user_name-->username (...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL rename power_management.user_name-->username (#969097) ...................................................................... restapi: RSDL rename power_management.user_name-->username (#969097) Bug-Url: http://bugzilla.redhat.com/969097 Change-Id: Ibba24543d971b4950f0adc8712f33c7f30be7e89 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibba24543d971b4950f0adc8712f33c7f30be7e89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0