June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: RSDL rename power_management.user_name-->username (...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL rename power_management.user_name-->username (#969097) ...................................................................... restapi: RSDL rename power_management.user_name-->username (#969097) Bug-Url: http://bugzilla.redhat.com/969097 Change-Id: I4609f3a508a12fa1e833adbd03c005310211d95d Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4609f3a508a12fa1e833adbd03c005310211d95d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: fix for inaccurate floating point comparison
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: fix for inaccurate floating point comparison ...................................................................... findbugs: fix for inaccurate floating point comparison in commit 50680f0eb434080ad147dd2b479ced02375e50dc added a fix for floating point equality with a bug, comparing Double to long. This commit fix it to compare Double to Double. Change-Id: Icf3081c6d7d495dbfbd47a2092fe0e9a67be4299 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified ofri masad: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf3081c6d7d495dbfbd47a2092fe0e9a67be4299 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make GUID encoders singletons
by rgolan＠redhat.com 07 Jun '13

07 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: Make GUID encoders singletons ...................................................................... core: Make GUID encoders singletons The GUID encoders used in LDAP operations are stateless and can be reused, so we don't need to create a new instance each time we need them. This patch makes them singletons. Change-Id: If8683e90ac3a2a6c0ed129686c9e06ccb47ad82d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DefaultLdapGuidEncoder.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPALdapGuidEncoder.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSLdapGuidEncoder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSLdapGuidEncoder.java 6 files changed, 83 insertions(+), 68 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8683e90ac3a2a6c0ed129686c9e06ccb47ad82d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Multiple gateways test failure fixed
by lhornyak＠redhat.com 07 Jun '13

07 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Multiple gateways test failure fixed ...................................................................... engine: Multiple gateways test failure fixed Fixed failing junit tests 1) at org.junit.Assert.assertFalse(Assert.java:79) at org.ovirt.engine.core.bll.SetupNetworksParametersTest.validateParameters(SetupNetworksParametersTest.java:37) 2) NPE in gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest) Change-Id: Ie0f697a198b064dabc603f3ec438d5ea670b474e Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0f697a198b064dabc603f3ec438d5ea670b474e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: service: add debug when module returns
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: service: add debug when module returns ...................................................................... packaging: service: add debug when module returns Change-Id: I0edd674e408087dc772ff58c274c1bbe0f392469 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/service.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0edd674e408087dc772ff58c274c1bbe0f392469 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: use service debug instead of configuration
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: use service debug instead of configuration ...................................................................... novnc: use service debug instead of configuration Change-Id: I8cf66fcbd19a72bd3ffebb82984124dc9e51d83c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-websocket-proxy.conf.defaults.in M packaging/services/ovirt-websocket-proxy.py M packaging/services/service.py 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cf66fcbd19a72bd3ffebb82984124dc9e51d83c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: override get_target instead of new_client
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: override get_target instead of new_client ...................................................................... novnc: override get_target instead of new_client seems to better follow the base class implementation, and does not duplicate communication logic into our code. Change-Id: I55d72f8f51d4502feec045138b31eaf69b46a323 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-websocket-proxy.py 1 file changed, 9 insertions(+), 22 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55d72f8f51d4502feec045138b31eaf69b46a323 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: log file is actually trace file
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: log file is actually trace file ...................................................................... novnc: log file is actually trace file disable per default, do not have default for name Change-Id: I2c0f9568b911d9985b9375baf5dac648ab211ea7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-websocket-proxy.conf.defaults.in M packaging/services/ovirt-websocket-proxy.py 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c0f9568b911d9985b9375baf5dac648ab211ea7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: cleanup defaults file
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: cleanup defaults file ...................................................................... novnc: cleanup defaults file Change-Id: I7a88a18d1fac63385cfeb78c68bdd84b2b641d27 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-websocket-proxy.conf.defaults.in 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a88a18d1fac63385cfeb78c68bdd84b2b641d27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: no need to raise terminate exception on termination
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: no need to raise terminate exception on termination ...................................................................... novnc: no need to raise terminate exception on termination Change-Id: I95a23d72f87391bb4682a447c307129089bce3d2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-websocket-proxy.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95a23d72f87391bb4682a447c307129089bce3d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0