July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: broker: fix vdsClient connections
by gpadgett＠redhat.com 01 Aug '13

01 Aug '13

Greg Padgett has submitted this change and it was merged. Change subject: broker: fix vdsClient connections ...................................................................... broker: fix vdsClient connections Variable referenced before assignment Change-Id: If00acad80b6874fd9f84da4f672fb59ee6836bd8 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/submonitor_util.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If00acad80b6874fd9f84da4f672fb59ee6836bd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: ovirt-hosted-engine-ha: initial commit
by gpadgett＠redhat.com 31 Jul '13

31 Jul '13

Greg Padgett has submitted this change and it was merged. Change subject: ovirt-hosted-engine-ha: initial commit ...................................................................... ovirt-hosted-engine-ha: initial commit oVirt Hosted Engine HA initial commit This project is divided into 2 main pieces: - an HA agent, which considers the state of systems eligible to take part in HA and decides whether to run the engine or not - an HA broker, which manages communication to storage as well as various submonitors which are used to monitor the current host A few pending work items are remaining, marked FIXME in the code. Less important/longer-term fixup is marked TODO. Change-Id: I3853db529ed353e7d5080692029ab80262a02c91 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A .gitignore A COPYING A Makefile.am A README A autogen.sh A bin/Makefile.am A bin/ovirt-ha-agent A bin/ovirt-ha-broker A build/Makefile.am A build/python.inc A build/var_subst.inc A commit-template.txt A configure.ac A initscripts/Makefile.am A initscripts/ovirt-ha-agent.init.in A initscripts/ovirt-ha-agent.service A initscripts/ovirt-ha-broker.init.in A initscripts/ovirt-ha-broker.service A m4/ax_python_module.m4 A ovirt-hosted-engine-ha.spec.in A ovirt_hosted_engine_ha/Makefile.am A ovirt_hosted_engine_ha/__init__.py A ovirt_hosted_engine_ha/agent/Makefile.am A ovirt_hosted_engine_ha/agent/__init__.py A ovirt_hosted_engine_ha/agent/agent-log.conf.in A ovirt_hosted_engine_ha/agent/agent.py A ovirt_hosted_engine_ha/agent/brokerlink.py A ovirt_hosted_engine_ha/agent/config.py A ovirt_hosted_engine_ha/agent/constants.py.in A ovirt_hosted_engine_ha/agent/hosted_engine.py A ovirt_hosted_engine_ha/broker/Makefile.am A ovirt_hosted_engine_ha/broker/__init__.py A ovirt_hosted_engine_ha/broker/broker-log.conf.in A ovirt_hosted_engine_ha/broker/broker.py A ovirt_hosted_engine_ha/broker/constants.py.in A ovirt_hosted_engine_ha/broker/listener.py A ovirt_hosted_engine_ha/broker/monitor.py A ovirt_hosted_engine_ha/broker/storage_broker.py A ovirt_hosted_engine_ha/broker/submonitor_base.py A ovirt_hosted_engine_ha/broker/submonitor_util.py A ovirt_hosted_engine_ha/broker/submonitors/Makefile.am A ovirt_hosted_engine_ha/broker/submonitors/cpu_load.py A ovirt_hosted_engine_ha/broker/submonitors/engine_health.py A ovirt_hosted_engine_ha/broker/submonitors/mem_free.py A ovirt_hosted_engine_ha/broker/submonitors/mem_load.py A ovirt_hosted_engine_ha/broker/submonitors/mgmt_bridge.py A ovirt_hosted_engine_ha/broker/submonitors/ping.py A ovirt_hosted_engine_ha/broker/test/test_monitor.py A ovirt_hosted_engine_ha/lib/Makefile.am A ovirt_hosted_engine_ha/lib/__init__.py A ovirt_hosted_engine_ha/lib/exceptions.py A ovirt_hosted_engine_ha/lib/log_filter.py A ovirt_hosted_engine_ha/lib/util.py 53 files changed, 4,174 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3853db529ed353e7d5080692029ab80262a02c91 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing a storage connection without a VDS
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removing a storage connection without a VDS ...................................................................... core: Removing a storage connection without a VDS If a VDS ID is not supplied to the RemoveStorageServerConnectionCommand, it should be possible to remove the connection from the database without disconnecting it from the (non-existent) host. Change-Id: I6ddcf6cb6cd2aed85c23f0e7565ab0b597474a81 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommandTest.java 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ddcf6cb6cd2aed85c23f0e7565ab0b597474a81 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: Openstack Image -> OpenStack Image
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core,webadmin: Openstack Image -> OpenStack Image ...................................................................... core,webadmin: Openstack Image -> OpenStack Image Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987945 Change-Id: I0a8c92e7e2d5b78e64ba55bb9636e97d86c3a8f9 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenStackImageProviderProperties.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 12 files changed, 36 insertions(+), 36 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a8c92e7e2d5b78e64ba55bb9636e97d86c3a8f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: display import button only for glance
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: frontend: display import button only for glance ...................................................................... frontend: display import button only for glance Change-Id: Ie370a81f82ef4130e5afc06f234b9284d4e02462 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie370a81f82ef4130e5afc06f234b9284d4e02462 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal : User has insufficient permissions on url /domai...
by gchaplik＠redhat.com 31 Jul '13

31 Jul '13

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal : User has insufficient permissions on url /domain/domain_id/user ...................................................................... userportal : User has insufficient permissions on url /domain/domain_id/user >From user portal we should not be able to see all domain users. Those users who have manipulate_permissions should be able to see all user who have been added to the system. Change-Id: I2ff611309ec35c4bcca5fcea6457af139c86e8f4 Bug-Url: https://bugzilla.redhat.com/923197 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java 3 files changed, 84 insertions(+), 33 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ff611309ec35c4bcca5fcea6457af139c86e8f4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix QoS error messages
by gchaplik＠redhat.com 31 Jul '13

31 Jul '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix QoS error messages ...................................................................... core: Fix QoS error messages Fix The error messages for QoS commands Change-Id: Ibfbcecfec18f0f795ce23ba1ad88ea1a594c21ef Bug-Url: https://bugzilla.redhat.com/987967 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddNetworkQoSCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/NetworkQoSCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveNetworkQoSCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java 4 files changed, 12 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfbcecfec18f0f795ce23ba1ad88ea1a594c21ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: setTaskType according to TaskHandler
by yzaslavs＠redhat.com 31 Jul '13

31 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: setTaskType according to TaskHandler ...................................................................... core: setTaskType according to TaskHandler Change-Id: I142a098f081808b99a4e23c1b5cd01ad00da4fdb Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I142a098f081808b99a4e23c1b5cd01ad00da4fdb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix storage pool ID association with tasks
by yzaslavs＠redhat.com 31 Jul '13

31 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix storage pool ID association with tasks ...................................................................... core: fix storage pool ID association with tasks The following patch fixes the association of storage pool ID to its task after the task is created at VDSM. Without this fix, the storage_pool_id column at async_tasks table will have entries of EMPTY guids. Bare in mind that when a place holder is created, the async task creation info does not have the storage pool ID information. IRS broker commands (i.e - CopyImage) create an async task creation info object with storage pool ID, once the task is created at SPM and the task ID is returned to engine. Change-Id: I1b8f06e7c3b16504f76f6188f3d99fa5e80eedd4 Bug-Url: https://bugzilla.redhat.com/990524 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M packaging/dbscripts/async_tasks_sp.sql 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b8f06e7c3b16504f76f6188f3d99fa5e80eedd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: migrating vm count in host's vm column
by gchaplik＠redhat.com 31 Jul '13

31 Jul '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: migrating vm count in host's vm column ...................................................................... webadmin: migrating vm count in host's vm column In vm count column under host main tab, show migrating vm count as well. Bug-Url: https://bugzilla.redhat.com/970195 Change-Id: I1ad6796dec7986ea9394c54e46a08946adaf48ed Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmCountColumn.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/double_arrow.png 6 files changed, 53 insertions(+), 7 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ad6796dec7986ea9394c54e46a08946adaf48ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0