July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: improve disk configuration not supported message
by derez＠redhat.com 31 Jul '13

31 Jul '13

Daniel Erez has submitted this change and it was merged. Change subject: core: improve disk configuration not supported message ...................................................................... core: improve disk configuration not supported message ACTION_TYPE_FAILED_DISK_CONFIGURATION_NOT_SUPPORTED VdcBllMessage: adding disk's ${volumeFormat} and ${volumeType} values. Change-Id: If281b402fdc043696b7f206e47d86e50add7b3d8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 6 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If281b402fdc043696b7f206e47d86e50add7b3d8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: A Burden <aburden(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Validate NfsTimeo and NfsRetrans
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Validate NfsTimeo and NfsRetrans ...................................................................... engine: Validate NfsTimeo and NfsRetrans Added @Max and @Min validations on nfsTimeo and nfsRetrans in order to offer a better value validation instead of just failing the command in VDSM side if a negative value is given. Note: This patch just improves the error handling, it does not fix the underlying issue described in the BZ, which should be handled by the REST-API layer, or possibly by the JAXB implementation. Related-to: https://bugzilla.redhat.com/962442 Change-Id: I15d35b2547bb36d17e29c90a05854fe6f897d5d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 18 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15d35b2547bb36d17e29c90a05854fe6f897d5d2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: A Burden <aburden(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Make EJB dependency in root explicit
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make EJB dependency in root explicit ...................................................................... core: Make EJB dependency in root explicit The EJB dependency is needed by the WelcomeServlet class. Explicitly defining it in pom.xml makes the pom easier to understand and solves some hickups some IDEs have with it. Change-Id: I621ec30aea05ddce6f9cce97b637198ecb76b77a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/root/pom.xml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I621ec30aea05ddce6f9cce97b637198ecb76b77a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove useless main from GlusterService
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove useless main from GlusterService ...................................................................... core: Remove useless main from GlusterService All the main(String[]) function does is print out a randomly generated Guid. Change-Id: I1260921814b76ae4f48d51feae41bf6e5250c2e2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1260921814b76ae4f48d51feae41bf6e5250c2e2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Exceptions in FenceOptionsParserTest
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Exceptions in FenceOptionsParserTest ...................................................................... restapi: Exceptions in FenceOptionsParserTest Used proper expectations mechanism introduced in JUnit 4 in order to make the code cleaner and easier to understand. Change-Id: I464438a6952bf06b13e41d2bb4933cfe3f9a0127 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/FenceOptionsParserTest.java 1 file changed, 6 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I464438a6952bf06b13e41d2bb4933cfe3f9a0127 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: reduce use of lists
by oschreib＠redhat.com 31 Jul '13

31 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: reduce use of lists ...................................................................... packaging: setup: reduce use of lists Change-Id: I871127099cde1466fbe3c9b13a4b07e82a60c37b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/dialog.py M packaging/setup/plugins/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-common/core/offlinepackager.py M packaging/setup/plugins/ovirt-engine-common/dialog/titles.py M packaging/setup/plugins/ovirt-engine-remove/config/ca.py M packaging/setup/plugins/ovirt-engine-remove/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/files/simple.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/core.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/firewall.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py M packaging/setup/plugins/ovirt-engine-setup/apache/root.py M packaging/setup/plugins/ovirt-engine-setup/apache/ssl.py M packaging/setup/plugins/ovirt-engine-setup/config/appmode.py M packaging/setup/plugins/ovirt-engine-setup/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/config/database.py M packaging/setup/plugins/ovirt-engine-setup/config/domain_type.py M packaging/setup/plugins/ovirt-engine-setup/config/hostname.py M packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py M packaging/setup/plugins/ovirt-engine-setup/config/macrange.py M packaging/setup/plugins/ovirt-engine-setup/config/options.py M packaging/setup/plugins/ovirt-engine-setup/config/protocols.py M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/dialog/titles.py M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/image_upload.py M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/legacy/apache.py M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py M packaging/setup/plugins/ovirt-engine-setup/legacy/datadomain.py M packaging/setup/plugins/ovirt-engine-setup/legacy/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/legacy/isodomain.py M packaging/setup/plugins/ovirt-engine-setup/network/firewall.py M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py M packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py M packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/upgrade/dbvalidations.py 46 files changed, 260 insertions(+), 260 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I871127099cde1466fbe3c9b13a4b07e82a60c37b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in otopi[master]: core: consider tuple as mutli-string
by Alon Bar-Lev 31 Jul '13

31 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: consider tuple as mutli-string ...................................................................... core: consider tuple as mutli-string Change-Id: Ib4dcbacb103dbf08567de82e70acb3ff48e0a259 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/common.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4dcbacb103dbf08567de82e70acb3ff48e0a259 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: cleanup engine-prolog.sh.in
by oschreib＠redhat.com 31 Jul '13

31 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: cleanup engine-prolog.sh.in ...................................................................... packaging: setup: cleanup engine-prolog.sh.in last script that does not meet shell conventions. Change-Id: I94cba648255f1c424db731c231d74c22067ff4aa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-prolog.sh.in 1 file changed, 21 insertions(+), 26 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94cba648255f1c424db731c231d74c22067ff4aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: services: ovirt-engine: support jvm args via conf...
by oschreib＠redhat.com 31 Jul '13

31 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: support jvm args via config ...................................................................... packaging: services: ovirt-engine: support jvm args via config Change-Id: I46c85c415975c4e6e287375ad7bc0a5bd43bf693 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46c85c415975c4e6e287375ad7bc0a5bd43bf693 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: no need for both %dir and directory in %fil...
by oschreib＠redhat.com 31 Jul '13

31 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: no need for both %dir and directory in %files ...................................................................... packaging: spec: no need for both %dir and directory in %files Change-Id: I5da475c83ec94d00084940aa856647e52d4f39d9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5da475c83ec94d00084940aa856647e52d4f39d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0