July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: change VM status icons
by tjelinek＠redhat.com 12 Jul '13

12 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: change VM status icons ...................................................................... frontend: change VM status icons Web Admin Changes: - Added titles for the VM statuses - Added the following new status icons: - paused - migration - pause when VM started in run once - suspended - The following status icons copied from User Portal to Web Admin with adjusted sizes: - Up - Starting - Waiting - Added the following new icons for VM types (not statuses) - Stateless desktop - Stateless server User Portal Changes: - Changed the "Paused" label to "Suspended" when VM is suspended - Added different icons when VM is running and is running as "run once" - Added new image for migration - Added new image for paused In both UP and WA the not responding status icon has been changed from down (red rectangle) to question mark. Change-Id: I82b16f63527158d4cd44b0b39aed5010d61c2115 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResources.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/vm_freeze.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/vm_migration.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/vm_run_runonce.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/paused.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/running.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/starting.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/stopping.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/vm_freeze.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/vm_migration.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/vm_run_runonce.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/wait.png R frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/desktop.gif R frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/server.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/vm_desktop_stateless.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/vm_server_stateless.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/wait.png 24 files changed, 267 insertions(+), 36 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82b16f63527158d4cd44b0b39aed5010d61c2115 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: restyle VM dialog header
by tjelinek＠redhat.com 12 Jul '13

12 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: restyle VM dialog header ...................................................................... frontend: restyle VM dialog header Changes to the header: - 2px border around the whole header - no padding around it - different background color and different border color Change-Id: If51788855a6e39b7549dd44206cccf5d0256ddf1 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If51788855a6e39b7549dd44206cccf5d0256ddf1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: fix remove multiple VMs
by tjelinek＠redhat.com 12 Jul '13

12 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: fix remove multiple VMs ...................................................................... userportal: fix remove multiple VMs If multiple VMs were selected in UP extended view only the first one was actually deleted. Change-Id: I460eb5d6f0bead1df87fe9b0f221c66747cbea47 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947831 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 31 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I460eb5d6f0bead1df87fe9b0f221c66747cbea47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix NPEx in new vm dialog when the DC is unitializ...
by tjelinek＠redhat.com 12 Jul '13

12 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix NPEx in new vm dialog when the DC is unitialized ...................................................................... frontend: Fix NPEx in new vm dialog when the DC is unitialized This patch adds a null check that avoids NPEx after trying to add a new VM when there is no initialized DC. Change-Id: I04349ddfe9ce164d85c818c439c8c4f89ae01019 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/16766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04349ddfe9ce164d85c818c439c8c4f89ae01019 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: typo fix
by lhornyak＠redhat.com 12 Jul '13

12 Jul '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: tools: typo fix ...................................................................... tools: typo fix typo fix in README.developer Change-Id: I03111047642f1fb0e4d19772c6e5425de11e2d29 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M README.developer 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03111047642f1fb0e4d19772c6e5425de11e2d29 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused columns from the users table
by juan.hernandez＠redhat.com 11 Jul '13

11 Jul '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove unused columns from the users table ...................................................................... core: Remove unused columns from the users table The columns session_count and desktop_device on the users table don't have any use currently, so they can be removed. Change-Id: If6ab5fc98bb9be9d9fb4cf5af42bb58e60a7152b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0400_remove_unused_colums_from_user.sql 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6ab5fc98bb9be9d9fb4cf5af42bb58e60a7152b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change warning message when import VM
by mlipchuk＠redhat.com 11 Jul '13

11 Jul '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change warning message when import VM ...................................................................... core: Change warning message when import VM changing warning message to be more clear when importing a VM which based on a template. Change-Id: I01300139bca2a278331f56bef7f7d17593f884d5 Bug-Url:https://bugzilla.redhat.com/964647 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01300139bca2a278331f56bef7f7d17593f884d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add CDA message when domain is inactive
by mlipchuk＠redhat.com 11 Jul '13

11 Jul '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add CDA message when domain is inactive ...................................................................... core: Add CDA message when domain is inactive When creating a VM from template and one of the domains sent by the user is inactive. engine should add a validation message for the user that the storage is not active and fail the operation gracefully. Change-Id: Ie443ccc36b2e7ccbf889f52e2b4c661269bc9aa5 Bug-Url:https://bugzilla.redhat.com/975053 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie443ccc36b2e7ccbf889f52e2b4c661269bc9aa5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use images instead of volumes at CDA message
by mlipchuk＠redhat.com 11 Jul '13

11 Jul '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use images instead of volumes at CDA message ...................................................................... core: Use images instead of volumes at CDA message The following message might be misleading since it uses the word "volume", which could be related to gluster: "Cannot remove Data Center while there are volumes on it. -Please remove all VMs and Templates first." There is also no need to indicate Vms or Templates since there could be also floating disks. Rephrasing the message to be "Cannot remove Data Center while in contains Disks. Please remove them first." Change-Id: I2cf86b6f968c4a6ff7178b742eb57077543d6143 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/955557 --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cf86b6f968c4a6ff7178b742eb57077543d6143 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: miniyum: force forget current state when rollback
by Alon Bar-Lev 11 Jul '13

11 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: miniyum: force forget current state when rollback ...................................................................... miniyum: force forget current state when rollback Change-Id: Ifca7382ecee93f16c722c61a0c0300bbd9114970 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifca7382ecee93f16c722c61a0c0300bbd9114970 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0