July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: print a message if no product update
by oschreib＠redhat.com 23 Jul '13

23 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: print a message if no product update ...................................................................... packaging: setup: print a message if no product update Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987001 Change-Id: I89b1170d053ecb514a07f7b918d599489c1a10a2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b1170d053ecb514a07f7b918d599489c1a10a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: display message when rollback
by Alon Bar-Lev 23 Jul '13

23 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: display message when rollback ...................................................................... packagers: yum: display message when rollback Change-Id: I88e97a7fd0cf8a9868810dfb0ee03a7d4ecce874 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e97a7fd0cf8a9868810dfb0ee03a7d4ecce874 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extract method to be with meaningful name.
by mlipchuk＠redhat.com 23 Jul '13

23 Jul '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Extract method to be with meaningful name. ...................................................................... core: Extract method to be with meaningful name. Use meaningful method name to increase readability of the code in importVmCommand. Change-Id: I6d5c52ab800a252c644852b5f90900e9d59cc8f8 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5c52ab800a252c644852b5f90900e9d59cc8f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Sync VM disks with new guid when importing a VM.
by mlipchuk＠redhat.com 23 Jul '13

23 Jul '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Sync VM disks with new guid when importing a VM. ...................................................................... core: Sync VM disks with new guid when importing a VM. Currently ImportVmCommand use three different kinds of containers when importing a VM: image id, disk id, and the new disk which is about to be added to the DB. The use of those containers has dependency with each other, and should be reflected in only one container so it will remain in sync. the following fix, put those parameters into one map, and use this map when copying a new disk into the Data Center. Change-Id: I5e25c75b95e08bbb5955b4d96a17baff59336e68 Bug-Url: https://bugzilla.redhat.com/970485 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 40 insertions(+), 19 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e25c75b95e08bbb5955b4d96a17baff59336e68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use the ou=People dn for openldap users
by yzaslavs＠redhat.com 23 Jul '13

23 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: use the ou=People dn for openldap users ...................................................................... core: use the ou=People dn for openldap users In openldap deployments the ou=People dn is more widely used than cn=Users,cn=Accounts (more freeipa-like). Until we wait for this parameter to be configurable let's switch it to ou=People. Change-Id: I84707ad92bdd2427f9acb7974149859ed79a751a Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SimpleLdapTemplateWrapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84707ad92bdd2427f9acb7974149859ed79a751a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: package display version within log
by oschreib＠redhat.com 23 Jul '13

23 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: package display version within log ...................................................................... packaging: setup: package display version within log Change-Id: I168fe5e6ae52cd595f44dd352464d787b2010eb3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/config.py.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/core/misc.py 3 files changed, 10 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I168fe5e6ae52cd595f44dd352464d787b2010eb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: support legacy ovirt-engine config preserv...
by oschreib＠redhat.com 23 Jul '13

23 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: support legacy ovirt-engine config preserve on rollback ...................................................................... packaging: setup: support legacy ovirt-engine config preserve on rollback do not backup/remove previous as we will not read these anyway, and wish to reduce complexity. Change-Id: I5f7a054b96823a283c5e8267267597e316b5b5cc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/legacy/config.py 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f7a054b96823a283c5e8267267597e316b5b5cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: reinstate clear database
by oschreib＠redhat.com 23 Jul '13

23 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: reinstate clear database ...................................................................... packaging: setup: reinstate clear database commit 1156dad0 introduced cleandb at dbscripts, however when we upgrade, dbscript may be rolled back before we rollback the database. this change is partial rollback, with the addition of adding the function drop syntax generation, so even in minimal database we will be able to reproduce this syntax. Change-Id: I14ac6a43ac4d5510c2664e82283ae03cd22456ba Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 124 insertions(+), 18 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14ac6a43ac4d5510c2664e82283ae03cd22456ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Specify GWT module in pom.xml
by vszocs＠redhat.com 23 Jul '13

23 Jul '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Specify GWT module in pom.xml ...................................................................... webadmin,userportal: Specify GWT module in pom.xml It might happen that gwt-maven-plugin auto-discovers other (support) modules (like GwtCommon) besides the main application module (like WebAdmin). This patch specifies the main module explicitly in pom.xml file. Change-Id: I18482f5c69072183501116e55ff36ee603dc8fc0 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18482f5c69072183501116e55ff36ee603dc8fc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixed lexo-numeric comparator for big numbers
by masayag＠redhat.com 23 Jul '13

23 Jul '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Fixed lexo-numeric comparator for big numbers ...................................................................... core: Fixed lexo-numeric comparator for big numbers The lexo-numeric comparator was using Integer class which is very limited to parse numbers, and would cause an exception if the sequence of numbers if too long. Change to BigInteger which is unlimited in size, and has the required functionality. There doesn't seem to be any adverse effect on the performance of the comparison. Change-Id: I52ec8c73e85b2505314a4043206d5883e2a43e37 Bug-Url: https://bugzilla.redhat.com/986979 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparatorTest.java 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52ec8c73e85b2505314a4043206d5883e2a43e37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0