July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: avoid traceback adding data domain
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: avoid traceback adding data domain ...................................................................... packaging: setup: avoid traceback adding data domain Fixed the call to to ovirtsdk api using kwargs instead of positional arguments ensuring the path is passed to the correct variable. Change-Id: I617b30d16e0eb28d60a3ce9feb32c47df38eff1d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I617b30d16e0eb28d60a3ce9feb32c47df38eff1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: services: move defaults to services
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: services: move defaults to services ...................................................................... packaging: services: move defaults to services move each default configuration to service location so that the unit can be maintain at one place, and reduce build complexity. Change-Id: If8e14cfc5587a795c5a82ea1a94cb8c0b2250fb3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in M packaging/services/ovirt-engine-notifier/config.py.in R packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py M packaging/services/ovirt-engine/config.py.in R packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py R packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.conf.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py 11 files changed, 45 insertions(+), 27 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e14cfc5587a795c5a82ea1a94cb8c0b2250fb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: introduce the ovirt-engine-lib package
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: introduce the ovirt-engine-lib package ...................................................................... packaging: introduce the ovirt-engine-lib package a python library, and in future can be more, to be used by any component, not locked by versionlock so it can be used by all but must be backward compatible. Change-Id: I4847f4fdbac5eb46d2a8f8780b9e515ff8a27982 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M README.developer M ovirt-engine.spec.in M packaging/check.sh C packaging/pythonlib/ovirt_engine/__init__.py A packaging/pythonlib/ovirt_engine/base.py A packaging/pythonlib/ovirt_engine/configfile.py R packaging/pythonlib/ovirt_engine/service.py C packaging/pythonlib/ovirt_engine/util.py C packaging/services/ovirt-engine-notifier/__init__.py R packaging/services/ovirt-engine-notifier/config.py.in R packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py R packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.systemd.in R packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in R packaging/services/ovirt-engine/__init__.py C packaging/services/ovirt-engine/config.py.in R packaging/services/ovirt-engine/ovirt-engine-logging.properties.in R packaging/services/ovirt-engine/ovirt-engine.py R packaging/services/ovirt-engine/ovirt-engine.systemd.in R packaging/services/ovirt-engine/ovirt-engine.sysv.in R packaging/services/ovirt-engine/ovirt-engine.xml.in D packaging/services/ovirt-websocket-proxy.systemd.in C packaging/services/ovirt-websocket-proxy/__init__.py C packaging/services/ovirt-websocket-proxy/config.py.in R packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py A packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.systemd.in R packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in R packaging/setup/bin/ovirt-engine-setup.env.in M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/plugins/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-common/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/legacy/config.py 33 files changed, 359 insertions(+), 362 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4847f4fdbac5eb46d2a8f8780b9e515ff8a27982 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:fkvalidator.sh - some args are not honoured
by emesika＠redhat.com 22 Jul '13

22 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: core:fkvalidator.sh - some args are not honoured ...................................................................... core:fkvalidator.sh - some args are not honoured Adding -l LOGFILE support Adding support for -v flag When -v is used the number of violates records and the query how to get them is displayed. Example: ./fkvalidator.sh -u postgres -d engine_964197 Constraint violation found in event_subscriber (event_up_name) ./fkvalidator.sh -u postgres -d engine_964197 -v Constraint violation found in event_subscriber (event_up_name) Please run the following SQL to get the 1 violated record/s: select (event_up_name) from event_subscriber where (event_up_name) IS NOT NULL and (event_up_name) not in (select (event_up_name) from event_map); " Change-Id: I759dc11424bda345e14e7bc7bdf81d41515a0847 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=964197 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/setup/dbutils/fkvalidator.sh M packaging/setup/dbutils/fkvalidator_sp.sql 2 files changed, 25 insertions(+), 12 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759dc11424bda345e14e7bc7bdf81d41515a0847 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Show usage when no args is passed to mng domains
by juan.hernandez＠redhat.com 22 Jul '13

22 Jul '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Show usage when no args is passed to mng domains ...................................................................... packaging: Show usage when no args is passed to mng domains This patch adds a check and if no argument is passed, the usage function is executed causing the print of the help Bug-Url: https://bugzilla.redhat.com/983245 Change-Id: I8d4ed902971498318b7304d9a4b60164d4056eb1 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/bin/engine-manage-domains.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d4ed902971498318b7304d9a4b60164d4056eb1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Report when vm gets less then Guaranteed memory
by dfediuck＠redhat.com 22 Jul '13

22 Jul '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Report when vm gets less then Guaranteed memory ...................................................................... engine: Report when vm gets less then Guaranteed memory Currently vm might get less than the guaranteed memory. In they future they will be migrated, but for now we will only log the issue. Change-Id: I47d32f291f39f0ab51c4e5d20a34ab01b47db562 Bug-Url: https://bugzilla.redhat.com/967574 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 7 files changed, 85 insertions(+), 25 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47d32f291f39f0ab51c4e5d20a34ab01b47db562 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: JDK7 impl. for LastTimeUsedAsMasterComp
by amureini＠redhat.com 22 Jul '13

22 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: JDK7 impl. for LastTimeUsedAsMasterComp ...................................................................... core: JDK7 impl. for LastTimeUsedAsMasterComp Used the JDK7 standard implementation, now that BLL supports JDK7. Change-Id: I8bc24521c02c5198a510086a017ccef0c17a2e2c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bc24521c02c5198a510086a017ccef0c17a2e2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Serializable LastTimeUsedAsMasterComp
by amureini＠redhat.com 22 Jul '13

22 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Serializable LastTimeUsedAsMasterComp ...................................................................... core: Serializable LastTimeUsedAsMasterComp Made LastTimeUsedAsMasterComp Serializeable, as per the FindBugs warning. Change-Id: I5a30def7a132a7d53a57e57acbf9b61132a9bff6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a30def7a132a7d53a57e57acbf9b61132a9bff6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: logging: port notifier to logrotate
by yzaslavs＠redhat.com 22 Jul '13

22 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: packaging: logging: port notifier to logrotate ...................................................................... packaging: logging: port notifier to logrotate Change-Id: If0c14f88fdca4ac61e22a1e2585e2cf163b3dbbd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in M packaging/etc/notifier/log4j.xml.in A packaging/sys-etc/logrotate.d/ovirt-engine-notifier.in 5 files changed, 13 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c14f88fdca4ac61e22a1e2585e2cf163b3dbbd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move toByteArray() from GuidUtils to Guid
by juan.hernandez＠redhat.com 22 Jul '13

22 Jul '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Move toByteArray() from GuidUtils to Guid ...................................................................... core: Move toByteArray() from GuidUtils to Guid This method will soon be needed from classes that are in the common module. Change-Id: Ib8e1b69107c042ff16a404fa1bf365a5f3f4a688 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/GuidTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java 5 files changed, 33 insertions(+), 38 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e1b69107c042ff16a404fa1bf365a5f3f4a688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0