July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: update temp pgpass for non-default usernam...
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: update temp pgpass for non-default username ...................................................................... packaging: setup: update temp pgpass for non-default username Current implementation creates temp pgpass file in the beginning of the setup/upgrade flow. This causes problems when there are already DB/username present on the system and not empty. The setup then generates a new username/DB name, but pgpass is left with original credentials, which causes external tools to fail. This new implementation updates the temp pgpass file at the correct stage so it is correct for external tools execution. Change-Id: I22c2003ff3ccd9fa3a5ea0554518982d6302f5ba Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/db/pgpass.py M packaging/setup/plugins/ovirt-engine-remove/db/clear.py M packaging/setup/plugins/ovirt-engine-setup/config/database.py M packaging/setup/plugins/ovirt-engine-setup/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/upgrade/dbvalidations.py 7 files changed, 49 insertions(+), 20 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22c2003ff3ccd9fa3a5ea0554518982d6302f5ba Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: seutp: perform schema rollback using transaction
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: seutp: perform schema rollback using transaction ...................................................................... packaging: seutp: perform schema rollback using transaction if new database - clean database. if upgrade - clean and restore. Change-Id: I869bc425ef6728a0e2a9ac5a9f17a22fc38bc958 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/db/schema.py 1 file changed, 100 insertions(+), 61 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I869bc425ef6728a0e2a9ac5a9f17a22fc38bc958 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: remove logs from database utilities
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: remove logs from database utilities ...................................................................... packaging: setup: remove logs from database utilities Change-Id: I11f2a760f2ebaf0719695c6269b5acb5a756b6cf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py M packaging/setup/plugins/ovirt-engine-remove/db/clear.py 2 files changed, 3 insertions(+), 8 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11f2a760f2ebaf0719695c6269b5acb5a756b6cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: do not clean database twice on restore
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: do not clean database twice on restore ...................................................................... packaging: setup: do not clean database twice on restore Change-Id: I7abba4b6553e49957704ae77e1215936a284b767 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7abba4b6553e49957704ae77e1215936a284b767 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: services: support metalog as syslog
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: services: support metalog as syslog ...................................................................... packaging: services: support metalog as syslog stricter message format. Change-Id: I0b9c97dcf45c32ff30b9d2c8b93091435a57914c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/service.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9c97dcf45c32ff30b9d2c8b93091435a57914c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: updated early statement for /api
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: updated early statement for /api ...................................................................... packaging: setup: updated early statement for /api The current proxy configuration removes Expect headers incorrectly: 1) The 'early' statement removed by the commit 4acbcb524 is still required. 2) According to mod_headers documentation at [1], the directive cannot be used as nested in <Location>: "Because early directives are processed before the request path's configuration is traversed, early headers can only be set in a main server or virtual host context. Early directives cannot depend on a request path, so they will fail in contexts such as <Directory> or <Location>" The new implementation brings back the 'early' directive and relocates the statement into main context. [1] http://httpd.apache.org/docs/current/mod/mod_headers.html Change-Id: I4dda234b7669dcd6c6eb76728a8536ba49247393 Bug-Url: https://bugzilla.redhat.com/849442 Related-To: https://bugzilla.redhat.com/979737 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/conf/ovirt-engine-proxy.conf.v2.in 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dda234b7669dcd6c6eb76728a8536ba49247393 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: upgrade firewalld config
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: upgrade firewalld config ...................................................................... packaging: setup: upgrade firewalld config upgrade firewalld configuration from legacy 3.2.z where there was an ovirt service that is not used anymore from 3.3.0. Change-Id: I9adc2a32e17d687f0eae546c83685e4a7f5b38e7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/legacy/__init__.py A packaging/setup/plugins/ovirt-engine-setup/legacy/firewalld.py 3 files changed, 95 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9adc2a32e17d687f0eae546c83685e4a7f5b38e7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: backup previous ca when creating new one
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: backup previous ca when creating new one ...................................................................... pki: backup previous ca when creating new one Change-Id: Ie4111dee70ea746dbb481d0a7597898ad51ec13d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-create-ca.sh 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4111dee70ea746dbb481d0a7597898ad51ec13d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: remove pki artifacts on failure
by oschreib＠redhat.com 22 Jul '13

22 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: remove pki artifacts on failure ...................................................................... packaging: setup: remove pki artifacts on failure the existence of pki files, especially ca.pem marks a valid pki configuration. if we fail installation we should also revert pki, however since we do not have a method of reverting pki artifacts (legacy), we can just remove these for now when failure is detected. Change-Id: I1de80122a3d5894009319e9418733e444ed7fe9c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 1 file changed, 29 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1de80122a3d5894009319e9418733e444ed7fe9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: host-deploy: ovirt-node: do not activate bridge plugin in no...
by masayag＠redhat.com 22 Jul '13

22 Jul '13

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: ovirt-node: do not activate bridge plugin in non-legacy nodes ...................................................................... host-deploy: ovirt-node: do not activate bridge plugin in non-legacy nodes ovirt-node will be provided with or without the bridge per interface, in case we do not have these bridges we can allow the engine post installation to setup the networking. Change-Id: I1ecbec6c34a8a38518c0c36d1674c5fe820aac2b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 17 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ecbec6c34a8a38518c0c36d1674c5fe820aac2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0