July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: restart websocket proxy in upgrade only if...
by oschreib＠redhat.com 11 Jul '13

11 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: restart websocket proxy in upgrade only if available ...................................................................... packaging: setup: restart websocket proxy in upgrade only if available Change-Id: Id962920b0f6cf9a2db21791e66a285ed8b4d1387 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 11 insertions(+), 12 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id962920b0f6cf9a2db21791e66a285ed8b4d1387 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: do not add duplicate files into websocket-p...
by oschreib＠redhat.com 11 Jul '13

11 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: do not add duplicate files into websocket-proxy ...................................................................... packaging: spec: do not add duplicate files into websocket-proxy Change-Id: I2d070ca2849ec9b2cf46b7f79f0be36bb3f310bd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d070ca2849ec9b2cf46b7f79f0be36bb3f310bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: add branding support
by oschreib＠redhat.com 11 Jul '13

11 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: add branding support ...................................................................... packaging: setup: add branding support Change-Id: I2ad442ed67d7c89625791961285adfc66c008358 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/branding/ovirt.brand/messages.properties A packaging/setup/ovirt_engine_setup/branding.py M packaging/setup/ovirt_engine_setup/constants.py 3 files changed, 96 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ad442ed67d7c89625791961285adfc66c008358 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: do not fail if /etc/exports is missing
by oschreib＠redhat.com 11 Jul '13

11 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: do not fail if /etc/exports is missing ...................................................................... packaging: setup: do not fail if /etc/exports is missing Change-Id: Ie16fe7909ea61ec2f893f4ed88c324daa40f3cbf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/nfsutils.py 1 file changed, 11 insertions(+), 10 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie16fe7909ea61ec2f893f4ed88c324daa40f3cbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: services: websocket-proxy: supress stdout on sysv
by oschreib＠redhat.com 11 Jul '13

11 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: services: websocket-proxy: supress stdout on sysv ...................................................................... packaging: services: websocket-proxy: supress stdout on sysv Change-Id: I1611f7a6d57c4038732f4525c5bc9b09f349603d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-websocket-proxy.py M packaging/services/ovirt-websocket-proxy.sysv.in 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1611f7a6d57c4038732f4525c5bc9b09f349603d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: reorder service stop
by oschreib＠redhat.com 11 Jul '13

11 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: reorder service stop ...................................................................... packaging: setup: reorder service stop use Service.available() instead of Service.isServiceAvailable() as it works at both systemd and sysv. also check service exists before attempt stop. Change-Id: I909591f5b92def2b04252012f906e39052276b04 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 3 files changed, 16 insertions(+), 13 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I909591f5b92def2b04252012f906e39052276b04 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend, engine: inherit template permissions on VM creation
by tjelinek＠redhat.com 10 Jul '13

10 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend,engine: inherit template permissions on VM creation ...................................................................... frontend,engine: inherit template permissions on VM creation A new checkbox "Copy Permissions" has been introduced into the new VM dialog and make template dialog. For new VM dialog: It is visible only when a non blank template is selected and only in advanced mode. If it is checked, all the template permissions (only the direct ones not the inherited) are copied to the VM. For make tamplate dialog: Always visible If checked all permissions of the VM are copied to the template. Change-Id: I6e6fddcea410ab8fee5851468980b8eeb0dad428 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 15 files changed, 138 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e6fddcea410ab8fee5851468980b8eeb0dad428 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: do not fallback if ENGINE_PGPASS is specified
by emesika＠redhat.com 10 Jul '13

10 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: db: do not fallback if ENGINE_PGPASS is specified ...................................................................... db: do not fallback if ENGINE_PGPASS is specified existence of ENGINE_PGPASS within environment tells us to use a specific file, do not fallback to anything else in this mode. Change-Id: I0a92784c12d9fc8fcde6a57043c15cb2e7cc37db Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/backup.sh M packaging/dbscripts/dbcustomfunctions.sh 2 files changed, 8 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a92784c12d9fc8fcde6a57043c15cb2e7cc37db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Integrate SPICE-HTML5 client
by tjelinek＠redhat.com 10 Jul '13

10 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Integrate SPICE-HTML5 client ...................................................................... engine: Integrate SPICE-HTML5 client This patch integrates SPICE-HTML5 client in the engine. It makes use of the websocket proxy integrated in I44e9870b. Invocation by this client can be enabled in the console popup. For this to be enabled, the websocket proxy must be set in the engine. Moreover this patch adds parameter ssl_target to the ticket which is passed to the proxy. This parameter is necessary for telling the proxy that the (SPICE) endpoint uses ssl. The format of the ticket has changed from positional style to encoded json. Change-Id: I490cb57f5d23a7a763807d3bee00ea0e4c032338 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/root/src/main/webapp/ovirt-engine-novnc-main.html A backend/manager/modules/root/src/main/webapp/ovirt-engine-spicehtml5-main.html M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebClientConsoleInvoker.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebsocketProxyConfig.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceHtml5.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M packaging/conf/engine.conf.defaults.in M packaging/conf/ovirt-engine-proxy.conf.v2.in M packaging/services/ovirt-websocket-proxy.py 18 files changed, 456 insertions(+), 153 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/15257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I490cb57f5d23a7a763807d3bee00ea0e4c032338 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: bll: do not allow host activation with no unique id
by yzaslavs＠redhat.com 10 Jul '13

10 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: bll: do not allow host activation with no unique id ...................................................................... bll: do not allow host activation with no unique id partial installation of host for various of reasons will leave a host with no uuid. these hosts should not be allowed to be activated. for developers, if the InstallVds option is false, this validation will be disabled. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=978906 Change-Id: I9a15416ae21c2371ebfb12cecb1551b73c98d88f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 16 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a15416ae21c2371ebfb12cecb1551b73c98d88f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0