July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove IVdcUser
by juan.hernandez＠redhat.com 10 Jul '13

10 Jul '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove IVdcUser ...................................................................... core: Remove IVdcUser This interface only has one implementation, and there are no plans to have more so it can be removed, and that will simplify a bit the user management in the engine. Change-Id: I95315c0a31a1da9fbb2f758557bd0ec4ec3fc961 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractUserQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackendTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/session/SessionDataContainerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ThreadLocalParamsContainer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 20 files changed, 63 insertions(+), 129 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95315c0a31a1da9fbb2f758557bd0ec4ec3fc961 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent selection of "cpu pinning" and "manual migrati...
by dfediuck＠redhat.com 10 Jul '13

10 Jul '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: prevent selection of "cpu pinning" and "manual migration" ...................................................................... core: prevent selection of "cpu pinning" and "manual migration" Cpu pinning and migration (manual or automat) should be mutually excluded. Currently only the use of automatic migration is checked. this patch adds a check for manual migration as well. Change-Id: I906ae6c46e7ce520fedc172be1601b4c61735bf8 Bug-Url: https://bugzilla.redhat.com/926962 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I906ae6c46e7ce520fedc172be1601b4c61735bf8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: NPE when executing RunVmOnceCommand from rest
by derez＠redhat.com 10 Jul '13

10 Jul '13

Daniel Erez has submitted this change and it was merged. Change subject: core: NPE when executing RunVmOnceCommand from rest ...................................................................... core: NPE when executing RunVmOnceCommand from rest RunVmOnceCommand -> reportCompleted: 'getParameters().getRunAndPause()' can be null when starting a VM from the rest-api. Hence, an NPE is thrown. ['runAndPause' variable has been changed to Boolean in: Ib1fe46a9946f7914095310ddac9ab1a9e5a6564b] Change-Id: Id9a1b2b290c2c642ed3f1891582ac679a3a336c9 Bug-Url: https://bugzilla.redhat.com/974999 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9a1b2b290c2c642ed3f1891582ac679a3a336c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Tell VDSM the guaranteed amount of memory for VM
by dfediuck＠redhat.com 10 Jul '13

10 Jul '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Tell VDSM the guaranteed amount of memory for VM ...................................................................... engine: Tell VDSM the guaranteed amount of memory for VM Give VDSM the data about the guaranteed memory size so it can pass it to MoM and use it in the Balloon memory optimization. Change-Id: If597a4be7a8cd1552c9c7c61175d8d6513c267ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=967574 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If597a4be7a8cd1552c9c7c61175d8d6513c267ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix NPE in New VM dialog
by tjelinek＠redhat.com 10 Jul '13

10 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix NPE in New VM dialog ...................................................................... webadmin: Fix NPE in New VM dialog Regression caused by 416cd92a94bbc95c8e5bca17f3707d2016208668 which expected that the selected item is always set in VmListModel.onSave(). The problem was that it is true only for edit VM - not for new. Change-Id: I1e653f428f8a058532030483e7bb115961d706c3 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/16655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e653f428f8a058532030483e7bb115961d706c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: use ENGINE_PGPASS in db validations
by emesika＠redhat.com 10 Jul '13

10 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: packaging: setup: use ENGINE_PGPASS in db validations ...................................................................... packaging: setup: use ENGINE_PGPASS in db validations align with other dbscript utilities. Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff Signed-off-by: Alex Lourie <alourie(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/dbutils/common.sh 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: move dbutils to packaging
by emesika＠redhat.com 10 Jul '13

10 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: packaging: move dbutils to packaging ...................................................................... packaging: move dbutils to packaging Change-Id: I5ccbb956fd78ab6e891dcc2bf2e04eb9ea69552b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in M packaging/fedora/setup/basedefs.py R packaging/setup/dbutils/common.sh R packaging/setup/dbutils/encodingvalidator.sh R packaging/setup/dbutils/fkvalidator.sh R packaging/setup/dbutils/fkvalidator_sp.sql R packaging/setup/dbutils/taskcleaner.sh R packaging/setup/dbutils/taskcleaner_sp.sql R packaging/setup/dbutils/validatedb.sh 10 files changed, 2 insertions(+), 14 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ccbb956fd78ab6e891dcc2bf2e04eb9ea69552b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Small fix in HorizontalSplitTable
by alkaplan＠redhat.com 10 Jul '13

10 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Small fix in HorizontalSplitTable ...................................................................... webadmin: Small fix in HorizontalSplitTable Forgot to reuse a helper method rather than rewrite the logic. Change-Id: I3ea52dc35260affb3669c4bab1ca8d56d3224002 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ea52dc35260affb3669c4bab1ca8d56d3224002 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added Import command to Networks main tab
by alkaplan＠redhat.com 10 Jul '13

10 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added Import command to Networks main tab ...................................................................... webadmin: Added Import command to Networks main tab This command is a variation of the network provider Discover dialog, only here one may choose provider among available network providers within the dialog. This is more general than Discover, so DiscoverNetworksModel now inherits from ImportNetworksModel. Change-Id: I1c84085e19576f6d7de98bccfaf30dc5b70a9621 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderNetworkListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ProviderModule.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/DiscoverNetworkPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/ImportNetworksPopupPresenterWidget.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/DiscoverNetworkPopupView.ui.xml R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java 17 files changed, 335 insertions(+), 187 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c84085e19576f6d7de98bccfaf30dc5b70a9621 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: vdsm: packages: also start cgconfig if available
by Alon Bar-Lev 10 Jul '13

10 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: also start cgconfig if available ...................................................................... vdsm: packages: also start cgconfig if available Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=982306 Change-Id: I484b4f1fca0e5baab2050264716b1e0fa28c03f9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/packages.py 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I484b4f1fca0e5baab2050264716b1e0fa28c03f9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>

1 0