August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Set miimon=100 for preset bonding options
by masayag＠redhat.com 26 Aug '13

26 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Set miimon=100 for preset bonding options ...................................................................... webadmin: Set miimon=100 for preset bonding options So far it hasn't been set by default, which would apparently cause the kernel to not poll for the status of the bonded NICs. Change-Id: If4a6070639d6566f9ebb5e30adf16d63128eb820 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4a6070639d6566f9ebb5e30adf16d63128eb820 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Slight refactoring
by masayag＠redhat.com 26 Aug '13

26 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Slight refactoring ...................................................................... webadmin: Slight refactoring An if clause was ill-formatted and another variable name wasn't quite right. Change-Id: Icd25f099e634c8017123820e4cf21daf6548122b Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd25f099e634c8017123820e4cf21daf6548122b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Revert findbugs fix that caused regression
by masayag＠redhat.com 26 Aug '13

26 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Revert findbugs fix that caused regression ...................................................................... webadmin: Revert findbugs fix that caused regression A findbugs fix removed a "redundant" null check, which caused the Setup Host Networks dialog to malfunction. There was indeed a redundant null check, but not the one that was removed. Bug-Url: https://bugzilla.redhat.com/975886 Change-Id: I8b19c8588168281734e76e08ce98105ae5721941 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b19c8588168281734e76e08ce98105ae5721941 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: copy virtio files if they exist
by oschreib＠redhat.com 26 Aug '13

26 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: copy virtio files if they exist ...................................................................... packaging: setup: copy virtio files if they exist Current implementation didn't load the image_upload plugin correctly. Additionally, the plugin itself checked its own relevance before NFS export was created. New implementation loads the plugin correctly and moves NFS check to the validation stage, where NFS creation/export configuration step already have passed. Change-Id: Ie35c5a3ad38b2f7bdae88c1f8d0790d1a8c988c2 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/__init__.py M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/image_upload.py 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie35c5a3ad38b2f7bdae88c1f8d0790d1a8c988c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: status command description need to rephrase
by mpastern＠redhat.com 26 Aug '13

26 Aug '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: status command description need to rephrase ...................................................................... cli: status command description need to rephrase help ping command has oVirt manager in the help text needs to be product specific Change-Id: I728b3e23b96694bf1349fbfb7c10b7940a7666ed Bug-Url: https://bugzilla.redhat.com/957624 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/ping.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I728b3e23b96694bf1349fbfb7c10b7940a7666ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: wrong error message appears after running 'show event -...
by mpastern＠redhat.com 26 Aug '13

26 Aug '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: wrong error message appears after running 'show event --id <wrong id>' ...................................................................... cli: wrong error message appears after running 'show event --id <wrong id>' wrong error message appears after running 'show event --id <wrong id>' show event --id 12345 Shows error message error: event "[12345]" does not exist. It should be error: event 12345 does not exist. Change-Id: I8184e083d9dcc84ca42282046c76513032590b03 Bug-Url: https://bugzilla.redhat.com/980855 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/show.py 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8184e083d9dcc84ca42282046c76513032590b03 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Initialize array 'imageParameters' in VdcActionParam...
by amureini＠redhat.com 26 Aug '13

26 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Initialize array 'imageParameters' in VdcActionParametersBase ...................................................................... engine: Initialize array 'imageParameters' in VdcActionParametersBase Currently this non initialized array causes NullPointerException when trying to create VM from Template without disks. Change-Id: I0fdaf131ed3d1bbfadcdd60df3feb6b828c05d0c Bug-Url: https://bugzilla.redhat.com/1000789 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fdaf131ed3d1bbfadcdd60df3feb6b828c05d0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Make coverity happy
by yzaslavs＠redhat.com 26 Aug '13

26 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Make coverity happy ...................................................................... core: Make coverity happy Some recent changes have introduced a construct that forces the java compiler to infer the type of a generic method from its use inside the condition of an if, for example: if(Config.GetValue(ConfigValues.ExternalSchedulerEnabled)) { ... } The usual (which doesn't mean nice) syntax for this is the following: if(Config.<Boolean> GetValue(ConfigValues.ExternalSchedulerEnabled)) { ... } While the recently introduced syntax is nicer, unfortunatelly it makes coverity choke. This patch reverts to the old style, just to make coverity happy. Change-Id: I2eb133de6fab92eaaf0edd8a99af2fc406f6b088 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2eb133de6fab92eaaf0edd8a99af2fc406f6b088 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[master]: supporting OVF directory structure
by kroberts＠redhat.com 26 Aug '13

26 Aug '13

Keith Robertson has submitted this change and it was merged. Change subject: supporting OVF directory structure ...................................................................... supporting OVF directory structure Adding support for OVF directories as exported from the oVirt engine, in addition to the current support for such compressed OVF directories. Change-Id: I6dbffed3037c66b015489ea1cb03b2b4d92a098f Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M src/__main__.py M src/engine-image-uploader.8 2 files changed, 55 insertions(+), 35 deletions(-) Approvals: Keith Robertson: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/18462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dbffed3037c66b015489ea1cb03b2b4d92a098f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: remove dependency of openssh
by oschreib＠redhat.com 26 Aug '13

26 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: remove dependency of openssh ...................................................................... packaging: setup: remove dependency of openssh openssh dependency was left only for getting public key fingerprint. as we have the logic of doing that anyway because of old rhel server, we can calc the fingerprint our own. the ssh-keygen -l is also ugly as it does not support piping the key and forcing use of temp file... so best manage without it. Change-Id: Ifa4893d8f9b034642d2428d926d41dd677a23565 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py 2 files changed, 45 insertions(+), 38 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa4893d8f9b034642d2428d926d41dd677a23565 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0