August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: change VM status icons
by vszocs＠redhat.com 22 Aug '13

22 Aug '13

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: change VM status icons ...................................................................... frontend: change VM status icons Changes: - up/down and suspend action buttons changed to correspond the status icons - suspended icon changed to moon - paused icon is || - added specific icon for rebooting state - saving and restoring state have a wait icon - wait for lunch has a grey starting icon - up and down states are now up/down icons - run once icon has an up arrow with a gear Change-Id: I33daac391e547d5874343ca6fd6199dc505f05a4 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResources.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/icn_suspend_disabled.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/icn_suspend_enabled.png D frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/pause.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/play.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/play_Disabled.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/stop.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/stop_Disabled.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/RUNNING.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/STARTING.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/STOPPED.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/STOPPING.png D frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/pause_icon.png R frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/rebooting.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/suspended.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/suspendedOverlay.png D frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/vm_freeze.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/vm_migration.png M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/vm_run_runonce.png C frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/status/waitforlaunch.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_pause.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_pause_disabled.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_play.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_play_disabled.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_stop.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_stop_disabled.png C frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_suspend_disabled.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_suspend_enabled.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/down.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/paused.png C frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/rebootInProgress.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/running.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/starting.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/stopping.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/suspened.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/vm_freeze.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/vm_migration.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/vm_run_runonce.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/waitForLaunch.png 48 files changed, 60 insertions(+), 31 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33daac391e547d5874343ca6fd6199dc505f05a4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: Fix --ticket-number option.
by knesenko＠redhat.com 22 Aug '13

22 Aug '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Fix --ticket-number option. ...................................................................... Fix --ticket-number option. Bug-Url: https://bugzilla.redhat.com/977836 Change-Id: Ia5425f88392f309df2b6278b927d78b957220a61 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M src/__main__.py 1 file changed, 28 insertions(+), 4 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5425f88392f309df2b6278b927d78b957220a61 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: pool dialog templates not updated according to DC
by vszocs＠redhat.com 22 Aug '13

22 Aug '13

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: pool dialog templates not updated according to DC ...................................................................... frontend: pool dialog templates not updated according to DC If the DC has been changed the templates have not been updated. There were two issues which caused this: 1: the list of templates has not been updated after the DC has been changed 2: the ListModelTypeAheadListBox handled the setValue() differently than other ListModelListBox. The ListModelListBox if gets a value in setValue() which is not part of the acceptable values adds it as one of them (in ValueListBox.updateListBox()). The ListModelTypeAheadListBox have ignored this values as incorrect ones. The problem is that UiCommonEditorVisitor first calls the setValue() and then the setAcceptableValues() which works correctly only the first time. Fixed by aligning the ListModelTypeAheadListBox to work the same as the ListModelListBox. Bug-Url: https://bugzilla.redhat.com/987819 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> Change-Id: I0ab81ee7165f9855de3d843fcf7ead0fc3db512a --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 2 files changed, 11 insertions(+), 16 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ab81ee7165f9855de3d843fcf7ead0fc3db512a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: ListModelTypeAheadListBox adjustements
by vszocs＠redhat.com 22 Aug '13

22 Aug '13

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: ListModelTypeAheadListBox adjustements ...................................................................... frontend: ListModelTypeAheadListBox adjustements This patch contains the following changes: 1: changed the styling of the suggestions to make the size proportional to the content 2: changed the styling (added bottom borders and changed the coloring) 3: the selected item is now the one set as setValue() Change-Id: I4ff487d93b752540feb7b9e9392fae1479662d59 Bug-Url: https://bugzilla.redhat.com/997422 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.ui.xml 3 files changed, 51 insertions(+), 3 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ff487d93b752540feb7b9e9392fae1479662d59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core:[ExternalTasks] Cannot add sub-step under...
by emesika＠redhat.com 22 Aug '13

22 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core:[ExternalTasks] Cannot add sub-step under... ...................................................................... core:[ExternalTasks] Cannot add sub-step under... [ExternalTasks] Cannot add sub-step under existing (parent) step 1) Fixing mandatory parameters step.parentStep.id => parentStep.id 2) Adding handling to the add method to inject the step parent Change-Id: Ibc610d6f295a688ceec1b038107c07d43390b431 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988082 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc610d6f295a688ceec1b038107c07d43390b431 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: QueryData2 generates slow SQL for...
by emesika＠redhat.com 22 Aug '13

22 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: QueryData2 generates slow SQL for... ...................................................................... core: QueryData2 generates slow SQL for... QueryData2 generates slow SQL for AuditLog with no parameters This patch fixes two issues When the inner query condition of getting the events is empty it omits the inner query. i.e. Instead of SELECT * FROM (SELECT * FROM audit_log WHERE ( audit_log_id > 0 and audit_log_id IN (SELECT audit_log.audit_log_id FROM audit_log ) and not deleted) ORDER BY audit_log_id DESC ,audit_log_id DESC ) as T1 OFFSET (1 -1) LIMIT 100 Perform: SELECT * FROM (SELECT * FROM audit_log WHERE ( audit_log_id > 0 and not deleted) ORDER BY audit_log_id DESC ,audit_log_id DESC ) as T1 OFFSET (1 -1) LIMIT 100; In addition, this patch fixes the redundancy in the SORT , so final query is : SELECT * FROM (SELECT * FROM audit_log WHERE ( audit_log_id > 0 and not deleted) ORDER BY audit_log_id DESC) as T1 OFFSET (1 -1) LIMIT 100; Change-Id: Id148adcc734c5742548c74ea754fb70252155e34 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960831 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 22 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id148adcc734c5742548c74ea754fb70252155e34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: [ExternalTasks] Cannot end existing job
by emesika＠redhat.com 22 Aug '13

22 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: [ExternalTasks] Cannot end existing job ...................................................................... core: [ExternalTasks] Cannot end existing job Enable to set the JobId or Step Id as parameters to commands that are not monitored but handle the External Job/Tasks : EndExternalJobCommand ClearExternalJobCommand EndExternalStepCommand Change-Id: I78f72cd619e32e5763f46391932ec70730a2b4b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988094 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78f72cd619e32e5763f46391932ec70730a2b4b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: [ExternalTasks] When adding new step...
by emesika＠redhat.com 22 Aug '13

22 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: [ExternalTasks] When adding new step... ...................................................................... core: [ExternalTasks] When adding new step... [ExternalTasks] When adding new step, state is always STARTED Removing the state parameter when adding a new step, it is really set implicitly to STARTED. Change-Id: I16ad3d25d527360b8cfb9eaefc66569700a3e4b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988087 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddExternalStepCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java 4 files changed, 5 insertions(+), 18 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ad3d25d527360b8cfb9eaefc66569700a3e4b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Underscores in tag names break tags
by emesika＠redhat.com 22 Aug '13

22 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Underscores in tag names break tags ...................................................................... core: Underscores in tag names break tags Fixing tag regular expression matching in TagHandler. We are adding backslashes for the SQL search query but should remove them when the regular expression is matched. Change-Id: I0925cdba0ed34e3dc68a8396eca0b17589dfa853 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949484 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0925cdba0ed34e3dc68a8396eca0b17589dfa853 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Search query sortby return some wrongly...
by emesika＠redhat.com 22 Aug '13

22 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Search query sortby return some wrongly... ...................................................................... core: Search query sortby return some wrongly... Search query sortby return some wrongly sorted results Adding explicitly "NULLS LAST" when DESC ORDER BY is used This is the ORDER BY Syntax : ORDER BY sort_expression1 [ASC | DESC] [NULLS { FIRST | LAST }] [, sort_expression2 [ASC | DESC] [NULLS { FIRST | LAST }] ...] The NULLS FIRST and NULLS LAST options can be used to determine whether nulls appear before or after non-null values in the sort ordering. By default, null values sort as if larger than any non-null value; that is, NULLS FIRST is the default for DESC order, and NULLS LAST otherwise. Change-Id: Ib1f25076ffe7c0c6e1dbd609f7b175c8c9e34ac5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=962560 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1f25076ffe7c0c6e1dbd609f7b175c8c9e34ac5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0