August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine Use VmNic within ChangeVMClusterCommand
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine Use VmNic within ChangeVMClusterCommand ...................................................................... engine Use VmNic within ChangeVMClusterCommand The patch uses the VmNic backend internal entity for vnic related actions, specifically for fetching the entity from the database. Change-Id: I864201b27d1572bf73a40d692ef3bb503a0f36ca Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 19 insertions(+), 18 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I864201b27d1572bf73a40d692ef3bb503a0f36ca Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: revert 925aeee7 Add vnic custom properties
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: revert 925aeee7 Add vnic custom properties ...................................................................... restapi: revert 925aeee7 Add vnic custom properties The custom properties per device will be managed on vnic profile level instead for vm nic. The motivation of reverting this patch is not to commit to custom properties api on vnic level, unless a strong use-case for it which isn't satisfied by the vnic profile is presented. Therefore the commit which adds it should be reverted. Change-Id: Ie893f50addf631e72dc52f1c740cf9bb41305dfd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NicMapperTest.java 5 files changed, 4 insertions(+), 29 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie893f50addf631e72dc52f1c740cf9bb41305dfd Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove unused method isValidVmNetwork
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove unused method isValidVmNetwork ...................................................................... engine: Remove unused method isValidVmNetwork Since vnic profile introduced there is no more use of VmInterfaceManager.isValidVmNetwork() method and it is being removed. Change-Id: If8e042587216fdf3d0bf724d987c116c84605fc6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 2 files changed, 0 insertions(+), 51 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e042587216fdf3d0bf724d987c116c84605fc6 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract vnic profile resolution to VmInterfaceManager
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract vnic profile resolution to VmInterfaceManager ...................................................................... engine: Extract vnic profile resolution to VmInterfaceManager The patch extracts the vnic profile resolution to VmInterfaceManager for re-usability by the ImportVmTemplate. Change-Id: I7588ca75a766927bffcafed86490e68fdb7bce05 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java 2 files changed, 114 insertions(+), 97 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7588ca75a766927bffcafed86490e68fdb7bce05 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Update the vnic profile resolution of ImportVmTempalte
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Update the vnic profile resolution of ImportVmTempalte ...................................................................... engine: Update the vnic profile resolution of ImportVmTempalte Since vnic profile is introduced, a different method should be used to resolve the vnic profile which should be used by a vnic of a template. Change-Id: I59004e5c61d2fc98c6d6e26fdb16dc0c469acaf4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java 3 files changed, 12 insertions(+), 17 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59004e5c61d2fc98c6d6e26fdb16dc0c469acaf4 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: minor cleanup for ImportVmTemplateCommand
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: minor cleanup for ImportVmTemplateCommand ...................................................................... engine: minor cleanup for ImportVmTemplateCommand Replaced an incorrect variable name with a proper one and moved the network name resolution few lines lower. Change-Id: I962b89eef095a1ff8451b705e8d2ec7bf0115943 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 2 files changed, 13 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I962b89eef095a1ff8451b705e8d2ec7bf0115943 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Refactor resolution of vnic profile for a vnic
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor resolution of vnic profile for a vnic ...................................................................... engine: Refactor resolution of vnic profile for a vnic The patch refactors the logic of updating a vnic's profile id so the code could be extracted into the VmInterfaceManager for the sake of sharing it between ImportVmCommand and ImportVmTemplateCommand. Change-Id: I26f1764db23555f5a284c427d36639d4ef4f6f5f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 60 insertions(+), 37 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26f1764db23555f5a284c427d36639d4ef4f6f5f Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Import VM configure the vnic profile
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Import VM configure the vnic profile ...................................................................... engine: Import VM configure the vnic profile The patch consider the vnic profile as it is provided by the OVF for a vnic. Change-Id: I890a214e879c740dd1dbdebca25529786231cbd6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 97 insertions(+), 11 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I890a214e879c740dd1dbdebca25529786231cbd6 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adding VnicProfileName to exported OVF
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Adding VnicProfileName to exported OVF ...................................................................... engine: Adding VnicProfileName to exported OVF The patch adds the vnic profile name for each vnic (vm or template). The vnic profile name will be kept on OtherResourceType field. Change-Id: Icec2002238f446503403b1ef936f26543d188bc2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icec2002238f446503403b1ef936f26543d188bc2 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Read vnic profile name from the OVF
by masayag＠redhat.com 08 Aug '13

08 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Read vnic profile name from the OVF ...................................................................... engine: Read vnic profile name from the OVF The patch assign the vnic profile name from the OVF as read from OtherResourceType element to the VmNetworkInterface entity so it could be handled when the vm or template are being imported. Change-Id: I284e5bdecbd0bc6d47a1bead27ac378169e1ad42 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I284e5bdecbd0bc6d47a1bead27ac378169e1ad42 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0