September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix QoS dialog indentation
by gchaplik＠redhat.com 23 Sep '13

23 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix QoS dialog indentation ...................................................................... webadmin: fix QoS dialog indentation Labels will be positions above the fields, instead of next to it (to avoid other locale issues). Also fixed unnecessary dialog scroll bars, and adjusted dialog width. Change-Id: Ifbcfa6849284d2e087c6884aa79cd77d9f4c3096 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml 2 files changed, 74 insertions(+), 57 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbcfa6849284d2e087c6884aa79cd77d9f4c3096 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Changed arrow sign from text to image
by gchaplik＠redhat.com 23 Sep '13

23 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Changed arrow sign from text to image ...................................................................... webadmin: Changed arrow sign from text to image Used to have the Unicode characters for triangles as the label of a button, but would come out garbled in non-English locales. Now using an image instead, with the help of ShapedButton. Also took the chance to give HorizontalSplitTable and ImportNetworksPopupView a tighter look with the help of a designer. Change-Id: I55f73d3edc261e4e16c19a7e345dbb1dc105c9b2 Bug-Url: https://bugzilla.redhat.com/1000285 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_click.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_disabled.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_normal.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_over.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_click.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_disabled.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_normal.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_over.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml 13 files changed, 60 insertions(+), 29 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f73d3edc261e4e16c19a7e345dbb1dc105c9b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added ShapedButton class
by gchaplik＠redhat.com 23 Sep '13

23 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Added ShapedButton class ...................................................................... webadmin: Added ShapedButton class It represents a custom-shaped button whose faces change according to supplied image files. Change-Id: I83eafafa7ca480b350d4b1b96aa560fd184acbad Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/ShapedButton.java 1 file changed, 48 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83eafafa7ca480b350d4b1b96aa560fd184acbad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed image resources no longer in use
by gchaplik＠redhat.com 23 Sep '13

23 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Removed image resources no longer in use ...................................................................... webadmin: Removed image resources no longer in use The arrow images were removed from the VM boot sequence buttons, but their ImageResource fetch methods were forgotten. Change-Id: I34ee07c7cc0b9f10e08d2b59038bc7020f614f20 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34ee07c7cc0b9f10e08d2b59038bc7020f614f20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: InitVdsOnUp - proceed regardless of problematic iso/ex...
by tnisan＠redhat.com 23 Sep '13

23 Sep '13

Tal Nisan has submitted this change and it was merged. Change subject: core: InitVdsOnUp - proceed regardless of problematic iso/export domain ...................................................................... core: InitVdsOnUp - proceed regardless of problematic iso/export domain Prior to this patch, when host reported iso/export domain as problematic during the InitVdsOnUp flow it didn't move to status UP. As currently when ISO/Export domains are reported as problematic by some of the hosts those hosts remain UP and doesn't move to NonOperational, the behaviour between those two flows should be unified - therefore it was decided that when hosts reports iso/export domain as in problem it won't stop it from moving to UP. Change-Id: I32372aa80d7193a814f2500231d4545d2b1a5fc3 Bug-Url: https://bugzilla.redhat.com/967604 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 2 files changed, 22 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32372aa80d7193a814f2500231d4545d2b1a5fc3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Revert artifact version to 3.3.0-SNAPSHOT
by oschreib＠redhat.com 23 Sep '13

23 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: core: Revert artifact version to 3.3.0-SNAPSHOT ...................................................................... core: Revert artifact version to 3.3.0-SNAPSHOT Revert commit 270afce27645691acb36054ccbe6d15062dfdc55, as 3.3 branch has been rebased. Change-Id: I3220d515e3813d3720ca6ec4885c64c434afd6db Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M pom.xml M version.mak 39 files changed, 44 insertions(+), 44 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3220d515e3813d3720ca6ec4885c64c434afd6db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixed a bug in disks allocation when importing a VM
by tnisan＠redhat.com 23 Sep '13

23 Sep '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed a bug in disks allocation when importing a VM ...................................................................... webadmin: Fixed a bug in disks allocation when importing a VM When importing a VM without collapse snapshots the allocation should fit the original allocation and should not be changeable, when moving to collapse snapshots the allocation should be changeable and keep the same logic when switching from with or without collapse snapshot option Change-Id: Iff56b64302b4f0a07a4c6bbcfb0cccdf9533e292 Bug-Url: https://bugzilla.redhat.com/965170 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportDiskData.java 1 file changed, 8 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff56b64302b4f0a07a4c6bbcfb0cccdf9533e292 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Attempt to add a 3.2 host into 3.3 env fails but t...
by yzaslavs＠redhat.com 23 Sep '13

23 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed ...................................................................... webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed When a 3.2 host is added to 3.3 env the server returns NonOperationalReason___CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER message. Since this message is not available in the frontend there is an exception thrown when a user clicks on the row for the host. So the row is not selected resulting in the action buttons not being activated. This patch adds a new message to LocalizedEnums Change-Id: I407154df67d51f28117f7aaf51f8030e39934678 Bug-Url: https://bugzilla.redhat.com/1004675 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I407154df67d51f28117f7aaf51f8030e39934678 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Prevent NPE when getting statistics
by mpastern＠redhat.com 23 Sep '13

23 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Prevent NPE when getting statistics ...................................................................... restapi: Prevent NPE when getting statistics VDSM doesn't report statistics for all of the network interfaces (i.e. vlans, see [1] for more details) therefore the restapi shouldn't expect a wrapper not to be null and prevent autoboxing to avoid NPE. [1] https://bugzilla.redhat.com/675560 Change-Id: Iab3422ef11f35b7a75d39f62cc5caa6f827ac7f4 Bug-Url: https://bugzilla.redhat.com/993123 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/RxTxCalculator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab3422ef11f35b7a75d39f62cc5caa6f827ac7f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: allow reverting ssl config
by oschreib＠redhat.com 23 Sep '13

23 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: allow reverting ssl config ...................................................................... packaging: setup: allow reverting ssl config Allow reverting the ssl config change using engine-cleanup. Change-Id: I204c6ffa92a0e3507b27e9779e1534048625b6b9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/apache/ssl.py 1 file changed, 21 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I204c6ffa92a0e3507b27e9779e1534048625b6b9 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0