September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Calculate 'procedureName' just once.
by amureini＠redhat.com 17 Sep '13

17 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Calculate 'procedureName' just once. ...................................................................... engine: Calculate 'procedureName' just once. Change-Id: Ia79e6b239f99416e4d2e21cf44d002f1447e9b70 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia79e6b239f99416e4d2e21cf44d002f1447e9b70 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to start with lowercase
by amureini＠redhat.com 17 Sep '13

17 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename method to start with lowercase ...................................................................... core: rename method to start with lowercase Change-Id: I55adeeec30119d3ef307628bdf753c4786f8b754 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55adeeec30119d3ef307628bdf753c4786f8b754 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: /var/lib/ovirt-engine/backups does not need...
by oschreib＠redhat.com 17 Sep '13

17 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: /var/lib/ovirt-engine/backups does not need to be owned by ovirt ...................................................................... packaging: spec: /var/lib/ovirt-engine/backups does not need to be owned by ovirt Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007751 Change-Id: I9ec6806b17e70b9e5bf9b2f29a3504737a6be0a3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ec6806b17e70b9e5bf9b2f29a3504737a6be0a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: search fix for storage pool
by oschreib＠redhat.com 17 Sep '13

17 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: engine: search fix for storage pool ...................................................................... engine: search fix for storage pool The database field is called 'free_text_comment', not 'comment' Change-Id: I7a8e17380c4e4079c22260af2202daf1db97aa24 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolFieldAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8e17380c4e4079c22260af2202daf1db97aa24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: application touches a file to detect un orderly shut...
by oschreib＠redhat.com 17 Sep '13

17 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: engine: application touches a file to detect un orderly shutdown ...................................................................... engine: application touches a file to detect un orderly shutdown Used to diagnose unexpected engine stop by the notification service. Previously we used the pid file, buy this solution becomes irrelevant for systemd. Change-Id: Ic8de64637299e7932a5a2761c7bb495373c418aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=743660 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py 4 files changed, 37 insertions(+), 14 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8de64637299e7932a5a2761c7bb495373c418aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: build: move version of ws-commons-util to master pom
by oschreib＠redhat.com 17 Sep '13

17 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: build: move version of ws-commons-util to master pom ...................................................................... build: move version of ws-commons-util to master pom Change-Id: Ib0e5c840ba5d83cc5d21f418bbb92dc7bc652948 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dependencies/pom.xml M pom.xml 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0e5c840ba5d83cc5d21f418bbb92dc7bc652948 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: tune: iosched: modify udev trigger to change event
by Alon Bar-Lev 17 Sep '13

17 Sep '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: tune: iosched: modify udev trigger to change event ...................................................................... packaging: tune: iosched: modify udev trigger to change event rhel initscripts does not distinguish where udev even comes from, so triggering hotplug even in all cases. change udev trigger to issue change event, as current initscripts ignores this event. current targeted udev rules handle change events so uneffected. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005278 Change-Id: I626c30eb1f281cf14a753f657c9313144df1b0db Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/tune/iosched.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved Assaf Muller: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I626c30eb1f281cf14a753f657c9313144df1b0db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: spec: split ovirt-host-deploy-offline into own spec
by Alon Bar-Lev 17 Sep '13

17 Sep '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: split ovirt-host-deploy-offline into own spec ...................................................................... packaging: spec: split ovirt-host-deploy-offline into own spec rpm dependencies are quite primitive and set at build time and not at install time, the dmidecode dependency cannot be use as it is platform specific in noarch package. rpm does not allow building base package as noarch while subpackages as arch specific, we cannot have the offline subpackage depend on arch specific packages. the reasonable solutions are: 1. make the entire package arch specific, it is illogical to accept rpm limitation and enforce it on good package. 2. create a package that provides dmidecode, so it can be installed at archs that do not provide dmidecode. this again is ugly. 3. move ovirt-host-deploy-offline into own arch specific primary package. solution 3 was implemented. a target of offline-tarball was added to create a tarball that can be served as source for packaging. Change-Id: I26513d02fd1c95a2a515781884a7283e77a5c2ff Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am M configure.ac A ovirt-host-deploy-offline.spec.in M ovirt-host-deploy.spec.in 4 files changed, 77 insertions(+), 18 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26513d02fd1c95a2a515781884a7283e77a5c2ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>

1 0

Change in ovirt-engine[master]: core: share a tranlation table of osinfo with DWH
by rgolan＠redhat.com 17 Sep '13

17 Sep '13

Roy Golan has submitted this change and it was merged. Change subject: core: share a tranlation table of osinfo with DWH ...................................................................... core: share a tranlation table of osinfo with DWH Added table dwh_osinfo table with os_id, os_name On boot, engine loads osinfo, truncates the table and populate it from what osinfo loaded. Change-Id: Iad8fc58166534abba0f22d81a733a69bcfaf385b Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/977440 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A packaging/dbscripts/dwh_translation_tables_sp.sql A packaging/dbscripts/upgrade/03_03_0880_add_dwh_osinfo_table.sql 4 files changed, 50 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad8fc58166534abba0f22d81a733a69bcfaf385b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix unit test paths
by ecohen＠redhat.com 16 Sep '13

16 Sep '13

Einav Cohen has submitted this change and it was merged. Change subject: engine: fix unit test paths ...................................................................... engine: fix unit test paths - Fixed unit tests that would fail if working path had a strange character in it like @ Change-Id: I0f52947d052a3eb5c228fee9b4260b827a2e0de5 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/branding/BrandingCascadingResourceServletTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/branding/BrandingManagerTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/branding/BrandingServletTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/branding/BrandingThemeTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoaderTest.java 5 files changed, 25 insertions(+), 20 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f52947d052a3eb5c228fee9b4260b827a2e0de5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0